Page MenuHomePhabricator
Create Task
Maniphest T389234

Replace Less variable negation `-@` with CSS `calc()`
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Background

While the Less compiler allows to negate a Less var independently of the contents, CSS custom properties don't work that way.

With the introduction of T387778: [breaking change] Font modes: Introduce font modes to Codex, the @size-icon-* and @font-size-* token values are changing to feature custom properties.

  • -@size CodeSearch
  • @font-size isn't used with negations, no occurrences of -@font-size

Goal

Replace negations with calc( -1 * @design-token-name )

Acceptance criteria

  • All cases of negation are replaced

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
styles: Harden design token usage in calculations by using `calc()`mediawiki/skins/Vectormaster+6 -4
Update Codex from v1.21.1 to v1.22.0mediawiki/coremaster+97 -66
styles, docs: Harden design token usage in calculationsdesign/codexmain+36 -22
styles: Harden design token usage in calculationsmediawiki/extensions/CommunityRequestsmaster+1 -1
styles: Harden design token usage in calculationsmediawiki/extensions/CheckUsermaster+4 -2
styles: Harden design token usage in calculationsmediawiki/extensions/GrowthExperimentsmaster+4 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Mar 18 2025, 5:32 PM
Restricted Application edited projects, added Design-System-Team; removed Design-System-Team (DST-Sprint-43 (2025-03-17 to 2025-03-28)). · View Herald TranscriptMar 18 2025, 5:32 PM
Volker_E updated the task description. (Show Details)Mar 19 2025, 4:35 PM
CCiufo-WMF triaged this task as High priority.Mar 19 2025, 10:58 PM
CCiufo-WMF moved this task from Inbox to Needs Refinement on the Design-System-Team board.
gerritbot added a comment.Mar 20 2025, 2:19 AM

Change #1129589 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/CommunityRequests@master] styles: Harden design token usage in calculations

https://gerrit.wikimedia.org/r/1129589

gerritbot added a project: Patch-For-Review.Mar 20 2025, 2:19 AM
gerritbot added a comment.Mar 20 2025, 2:48 AM

Change #1129590 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/GrowthExperiments@master] styles: Harden design token usage in calculations

https://gerrit.wikimedia.org/r/1129590

gerritbot added a comment.Mar 20 2025, 3:19 AM

Change #1129598 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] styles: Harden design token usage in calculations

https://gerrit.wikimedia.org/r/1129598

gerritbot added a comment.Mar 20 2025, 3:34 AM

Change #1129600 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/CheckUser@master] styles: Harden design token usage in calculations

https://gerrit.wikimedia.org/r/1129600

gerritbot added a comment.Mar 20 2025, 3:53 AM

Change #1129602 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Vector@master] styles: Harden design token usage in calculations

https://gerrit.wikimedia.org/r/1129602

Volker_E edited projects, added Design-System-Team (DST-Sprint-43 (2025-03-17 to 2025-03-28)); removed Design-System-Team.Mar 20 2025, 3:54 AM
Volker_E set the point value for this task to 1.
Volker_E moved this task from Committed to In Progress on the Design-System-Team (DST-Sprint-43 (2025-03-17 to 2025-03-28)) board.
Volker_E moved this task from In Progress to Code Review on the Design-System-Team (DST-Sprint-43 (2025-03-17 to 2025-03-28)) board.
gerritbot added a comment.Mar 20 2025, 9:19 AM

Change #1129590 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] styles: Harden design token usage in calculations

https://gerrit.wikimedia.org/r/1129590

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.22; 2025-03-25).Mar 20 2025, 10:00 AM
gerritbot added a comment.Mar 20 2025, 4:11 PM

Change #1129600 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] styles: Harden design token usage in calculations

https://gerrit.wikimedia.org/r/1129600

gerritbot added a comment.Mar 26 2025, 6:39 PM

Change #1129589 merged by jenkins-bot:

[mediawiki/extensions/CommunityRequests@master] styles: Harden design token usage in calculations

https://gerrit.wikimedia.org/r/1129589

Volker_E mentioned this in rECORb919c43e0e09: styles: Harden design token usage in calculations.Mar 26 2025, 6:52 PM
ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.23; 2025-04-01); removed MW-1.44-notes (1.44.0-wmf.22; 2025-03-25).Mar 26 2025, 7:00 PM
lwatson subscribed.Mar 26 2025, 10:28 PM
gerritbot added a comment.Mar 27 2025, 10:20 PM

Change #1129598 merged by jenkins-bot:

[design/codex@main] styles, docs: Harden design token usage in calculations

https://gerrit.wikimedia.org/r/1129598

Volker_E moved this task from Code Review to Blocked on the Design-System-Team (DST-Sprint-43 (2025-03-17 to 2025-03-28)) board.Mar 27 2025, 10:59 PM

Putting to 'blocked' column as the last bit is Web team review.

CCiufo-WMF moved this task from DST-Sprint-43 (2025-03-17 to 2025-03-28) to Up Next on the Design-System-Team board.Mar 31 2025, 4:57 PM
CCiufo-WMF edited projects, added Design-System-Team; removed Design-System-Team (DST-Sprint-43 (2025-03-17 to 2025-03-28)).
CCiufo-WMF changed the task status from Open to In Progress.Mar 31 2025, 5:21 PM
CCiufo-WMF assigned this task to Volker_E.
CCiufo-WMF moved this task from Up Next to DST-Sprint-44 (2025-03-31 to 2025-04-11) on the Design-System-Team board.Mar 31 2025, 5:27 PM
CCiufo-WMF edited projects, added Design-System-Team (DST-Sprint-44 (2025-03-31 to 2025-04-11)); removed Design-System-Team.
CCiufo-WMF moved this task from Committed to Code Review on the Design-System-Team (DST-Sprint-44 (2025-03-31 to 2025-04-11)) board.
gerritbot added a comment.Apr 1 2025, 11:10 PM

Change #1133258 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Update Codex from v1.21.1 to v1.22.0

https://gerrit.wikimedia.org/r/1133258

PatchDemoBot added a comment.Apr 1 2025, 11:18 PM

Test wiki created on Patch demo by Eric C Gardner using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/59d55f2723/w/

gerritbot added a comment.Apr 2 2025, 12:31 AM

Change #1133258 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.21.1 to v1.22.0

https://gerrit.wikimedia.org/r/1133258

gerritbot added a comment.Apr 3 2025, 4:04 PM

Change #1129602 merged by jenkins-bot:

[mediawiki/skins/Vector@master] styles: Harden design token usage in calculations by using `calc()`

https://gerrit.wikimedia.org/r/1129602

Maintenance_bot removed a project: Patch-For-Review.Apr 3 2025, 4:30 PM
Volker_E closed this task as Resolved.Apr 3 2025, 4:56 PM
Volker_E updated the task description. (Show Details)
Volker_E moved this task from Code Review to Pending Release on the Design-System-Team (DST-Sprint-44 (2025-03-31 to 2025-04-11)) board.

Resolving this, as the Codex part has already been part of the last v1.22.0 release and only Vector patch, which was merged today was the remainder.

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.24; 2025-04-08); removed MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Apr 3 2025, 5:00 PM
AnneT added a project: Codex 2.0.Apr 3 2025, 5:35 PM
CCiufo-WMF moved this task from Backlog to Breaking Changes Updates on the Codex 2.0 board.Apr 3 2025, 5:36 PM
PatchDemoBot added a comment.May 16 2025, 7:28 PM

Test wiki on Patch demo by Eric C Gardner using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/59d55f2723/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits