Message box appears unstyled in Flagged revisions edit
Closed, ResolvedPublic1 Estimated Story PointsFeature
Actions

Assigned To

Authored By

	Jdlrobson-WMF
	Mar 18 2025, 9:11 PM

Description

Thanks @Izno for the report

Steps to replicate the issue (include links if applicable):

https://en.wikipedia.org/wiki/List_of_colors_(alphabetical)?action=edit&veswitched=1
Make sure source editor selected

What happens?:
Unstyled message box

What should have happened instead?:

Styled.
Relates to this code:
https://gerrit.wikimedia.org/g/mediawiki/extensions/FlaggedRevs/+/e090bb478989e1955d0730dfb374c89ef34fd3e3/includes/frontend/FlaggablePageView.php#943

There are various instances of code adding message boxes without the appropriate style pack

FlaggedRevsHTML::addMessageBox
https://gerrit.wikimedia.org/g/mediawiki/extensions/FlaggedRevs/+/e090bb478989e1955d0730dfb374c89ef34fd3e3/includes/frontend/FlaggablePageView.php#557

Adding $out->AddModuleStyles( 'mediawiki.codex.messagebox.styles' ); where these methods are used will fix the issue.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	FlaggablePageView: style protection warning as block instead of inline	mediawiki/extensions/FlaggedRevs	master	+1 -4
	FlaggablePageView: add module styles for Codex message box	mediawiki/extensions/FlaggedRevs	master	+9 -0

Customize query in gerrit

Related Objects

Mentioned In: T388847: Please report unstyled Codex message boxes

Event Timeline

Jdlrobson-WMF created this task.Mar 18 2025, 9:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2025, 9:11 PM

Jdlrobson-WMF mentioned this in T388847: Please report unstyled Codex message boxes.Mar 18 2025, 9:11 PM

Novem_Linguae set the point value for this task to 1.Mar 18 2025, 9:19 PM

Change #1130208 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/FlaggedRevs@master] FlaggablePageView: add module styles for Codex message box

https://gerrit.wikimedia.org/r/1130208

gerritbot added a project: Patch-For-Review.Mar 21 2025, 11:10 PM

Looking at this again, I think this is a misunderstanding. The message is being styled as an inline warning
So if that's correct, this should be declined.
If not, this task should be repurposed as a feature request that it should be a block message not inline.

https://doc.wikimedia.org/codex/latest/components/demos/message.html#message-layout

Inline:

Screenshot 2025-03-24 at 9.13.14 AM.png (349×1 px, 96 KB)

Block:

Screenshot 2025-03-24 at 9.13.28 AM.png (528×1 px, 149 KB)

Didn't realize inline has no styling (which is fine), so yes this is not a bug. (It did seem weird that it was live on en but the patch cutting styles wasn't yet.)

I think it makes sense to style this as block. Probably notify (like in your screenshot) or yellow level (not red).

Change #1130208 abandoned by Novem Linguae:

[mediawiki/extensions/FlaggedRevs@master] FlaggablePageView: add module styles for Codex message box

Reason:

ticket requirements changed

https://gerrit.wikimedia.org/r/1130208

Change #1130784 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/FlaggedRevs@master] FlaggablePageView: style protection warning as block instead of inline

https://gerrit.wikimedia.org/r/1130784

On a page with pending changes on huwiki, your change would look like:

Screenshot 2025-03-25 at 11-06-45 Editing Kovács Győző (sportoló) - Wikipédia.png (327×958 px, 70 KB)

What about combining all of FlaggedRevs’ notices in one box?

Screenshot 2025-03-25 at 11-07-51 Editing Kovács Győző (sportoló) - Wikipédia.png (282×974 px, 68 KB)

I've updated the patch. How's this look?

I don’t think you should combine inline and block message boxes: this is no longer Codex. FlaggedRevs already has some almost-but-not-quite-Codex layout, we shouldn’t increase the number of them. Your first attempt with the separate message boxes is more acceptable to me, as it’s real Codex, even if a bit larger than what I’d wish.

By the way, in the pre-Codex version, simply the <p>s were concatenated in a common box (which is also what I proposed), without any icons or extra bolding. A screenshot from a dev wiki I haven’t updated for a while:

Before I make a 4th attempt, would you please tell me exactly how you would like this coded to get a +1 from you please?

I’ve made a suggestion on Gerrit.

Novem_Linguae closed this task as Resolved.Mar 27 2025, 10:59 PM

Novem_Linguae claimed this task.

Change #1130784 merged by jenkins-bot: