Page MenuHomePhabricator

icons: Add 'userTemporaryLocation' icon to Codex and OOUI
Closed, ResolvedPublic

Description

Background & Goal

Description:

The Trust and Safety Product (TSP) team is building a tool that will allow functionaries to automatically reveal the IP addresses of temporary accounts. Once enabled, "IP Auto-reveal mode" remains active for a limited time. Users can click a persistent icon button in the bottom dock of screen to launch a panel (similar to Help Panel) which will show a countdown timer and buttons to extend duration by +10 mins or turn off the mode. The icon used in the button needs to convey the idea of automatically revealing IPs of temporary accounts.

History:

User testing has taken place via Discord channels and Phabricator, primarily with Stewards (who are key users of this feature). The proposed icon in this task is one that was chosen by Stewards due to it conveying the idea of temporary accounts (temp user icon) and location (pin icon).

Known use case

The use case is for the IP Auto-reveal feature currently being built by TSP.

image.png (1×2 px, 531 KB)

Considerations:

We would like an icon in place before we can deploy the bottom dock panel.

User stories

As a user with rights to reveal IP addresses, I would like to see an icon that conveys temporary accounts and location, in order to understand and have a visual reminder that I am in "IP Auto-reveal mode".

Proposal

image.png (318×640 px, 35 KB)

Design spec

Once the icon spec sheet has been created, the Figma file should be included here.

SVG icon


Acceptance criteria for Done

Design

  • The design of the new icon is ready, and it follows our icon system guidelines
  • The new icon has been reviewed with help from the DST
  • An RTL icon has been created (if needed)
  • The icon is recognizable on low DPI resolutions
  • The icon has been exported as an optimized SVG and added to this task’s description
  • The new icon has been included and published in our Icon System Figma library

Code

  • Add icon in Codex
  • Add icon in OOUI

Documentation

Event Timeline

KColeman-WMF renamed this task from [IconName]: Add [IconName] icon to Codex and OOUI to IP Auto-reveal: Add IP Auto-reveal icon to Codex and OOUI.Mar 19 2025, 12:10 AM
CCiufo-WMF subscribed.

We'll discuss this at our next refinement session.

We'll discuss this at our next refinement session.

Thanks! I have chatted to @DTorsani-WMF about this and I'm happy to work on adding it to Figma (with DST support).

CCiufo-WMF renamed this task from IP Auto-reveal: Add IP Auto-reveal icon to Codex and OOUI to icons: Add IP Auto-reveal icon to Codex and OOUI.Mar 25 2025, 4:22 PM

@KColeman-WMF we're happy to help add this. Could you please provide a design spec and SVG file for the icon? Thanks!

CCiufo-WMF triaged this task as Medium priority.Mar 26 2025, 5:20 PM

Thank you @DTorsani-WMF for reviewing the icon and helping me figure out how to get it into the Figma library!

I will see if a TSP engineer can add the icon to Codex and OOUI.

As discussed with @Tchanders - Trust and Safety Product team can add the icon to Codex and OOUI. We will pull this into our current sprint.

Do we have a name for this icon, something generic enough for re-use by other features?

Do we have a name for this icon, something generic enough for re-use by other features?

Good question. It's comprised of temporary user + location/map pin icons. So perhaps UserTemporaryLocation?

Volker_E subscribed.

Do we have a name for this icon, something generic enough for re-use by other features?

Good question. It's comprised of temporary user + location/map pin icons. So perhaps UserTemporaryLocation?

I like that more than 'autoreveal'!

Moving to "Blocked" until someone in TSP picks this up; and also until Codex 2.0.0rc1 (scheduled for next Tue) is out successfully. We aim to put only breaking changes into the release in order to contain a possible rollback better.

Do we have a name for this icon, something generic enough for re-use by other features?

Good question. It's comprised of temporary user + location/map pin icons. So perhaps UserTemporaryLocation?

I like that more than 'autoreveal'!

@Volker_E @KColeman-WMF Thinking about it, is this generic enough to be upstreamed into the Codex library? Looking at the other user icons, and none of the other user types have a user/location variant: https://doc.wikimedia.org/codex/main/icons/all-icons.html

Do we have a name for this icon, something generic enough for re-use by other features?

Good question. It's comprised of temporary user + location/map pin icons. So perhaps UserTemporaryLocation?

I like that more than 'autoreveal'!

@Volker_E @KColeman-WMF Thinking about it, is this generic enough to be upstreamed into the Codex library? Looking at the other user icons, and none of the other user types have a user/location variant: https://doc.wikimedia.org/codex/main/icons/all-icons.html

In the Codex way of dealing with icons, we're not carrying performance burden by adding icons. The more, the merrier for a wide-ranging codex-icon package therefore.

Tchanders renamed this task from icons: Add IP Auto-reveal icon to Codex and OOUI to icons: Add UserTemporaryLocation icon to Codex and OOUI.May 7 2025, 7:33 PM

Change #1143182 had a related patch set uploaded (by Tchanders; author: Tchanders):

[design/codex@main] icons: Add UserTemporaryLocation icon

https://gerrit.wikimedia.org/r/1143182

Change #1143575 had a related patch set uploaded (by Tchanders; author: Tchanders):

[oojs/ui@master] icons: Add UserTemporaryLocation icon

https://gerrit.wikimedia.org/r/1143575

Change #1143575 merged by jenkins-bot:

[oojs/ui@master] icons: Add UserTemporaryLocation icon

https://gerrit.wikimedia.org/r/1143575

Change #1143182 merged by jenkins-bot:

[design/codex@main] icons: Add UserTemporaryLocation icon

https://gerrit.wikimedia.org/r/1143182

Volker_E renamed this task from icons: Add UserTemporaryLocation icon to Codex and OOUI to icons: Add 'userTemporaryLocation' icon to Codex and OOUI.May 9 2025, 4:33 AM

@Volker_E when would the next Codex release go out with the new icon?

Change #1143838 had a related patch set uploaded (by LWatson; author: LWatson):

[oojs/ui@master] icons: remove unnecessary fill-rule and clip-rule

https://gerrit.wikimedia.org/r/1143838

Change #1143838 merged by jenkins-bot:

[oojs/ui@master] icons: remove unnecessary `fill-rule` and `clip-rule` in 'userTemporaryLocation'

https://gerrit.wikimedia.org/r/1143838

Change #1143981 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] icons: remove unnecessary `fill-rule` and `clip-rule` in 'userTemporaryLocation'

https://gerrit.wikimedia.org/r/1143981

Change #1143981 merged by jenkins-bot:

[design/codex@main] icons: remove unnecessary `fill-rule` and `clip-rule` in 'userTemporaryLocation'

https://gerrit.wikimedia.org/r/1143981

Change #1148969 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Update Codex from v2.0.0-rc.1 to v2.0.0-rc.2

https://gerrit.wikimedia.org/r/1148969

Test wiki created on Patch demo by EGardner (WMF) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/7aa598f12d/w/

Test wiki created on Patch demo by EGardner (WMF) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/19abcf333d/w/

Test wiki on Patch demo by EGardner (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/19abcf333d/w/

Test wiki created on Patch demo by EGardner (WMF) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/b0226e7578/w/

Test wiki created on Patch demo by EGardner (WMF) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/1711107665/w/

@KColeman-WMF The mobile tool menu that we're updating in T393643: IP auto-reveal: Use the UserTemporaryLocation icon in the tool menu on mobile uses OOUI icons, rather than Codex icons.

Here's where the icons module used by the user tool menu is defined: note that it uses OOUIIconPackModule.

Therefore, in order to use this icon we'll need:

@Volker_E Would you be able to help?

Test wiki created on Patch demo by Volker E. (WMF) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/f6d7eb37f0/w/

Change #1156368 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update OOUI to v0.52.0

https://gerrit.wikimedia.org/r/1156368

Change #1156368 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.52.0

https://gerrit.wikimedia.org/r/1156368

Test wiki on Patch demo by EGardner (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org//wikis/1711107665/w/

Test wiki on Patch demo by EGardner (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org//wikis/7aa598f12d/w/

Test wiki on Patch demo by EGardner (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org//wikis/b0226e7578/w/

Test wiki on Patch demo by Volker E. (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org//wikis/f6d7eb37f0/w/