Page MenuHomePhabricator
Create Task
Maniphest T389343

[Darkmode] Find mapping for #72777d in `h1 .wikibase-title-id`
Closed, ResolvedPublic
Actions

Description

Per comment in the Figma file, we need to find a mapping for the item ID in the page headings. Currently hard-coded to #72777d, which potentially maps to color-placeholder

2025-03-19-121727_370x139_scrot.png (370×139 px, 10 KB)

Acceptance Criteria

  • h1 .wikibase-title-id is mapped to a codex token
  • other hard-coded references to #72777d are mapped to appropriate codex tokens.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Use @color-disabled for references headingLucas Werkmeister (WMDE)mediawiki/extensions/Wikibasemaster+1 -1
Use Codex token for .wikibase-toolbarbutton-disabledLucas Werkmeister (WMDE)mediawiki/extensions/Wikibasemaster+1 -1
Remove long-unused .wikibase-toolbarlabel stylesLucas Werkmeister (WMDE)mediawiki/extensions/Wikibasemaster+0 -9
Update colour for .wikibase-title-id to a codex tokenArthur taylormediawiki/extensions/Wikibasemaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

ArthurTaylor created this task.Mar 19 2025, 11:20 AM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptMar 19 2025, 11:20 AM
ArthurTaylor added a parent task: T369385: Colours on Wikidata Items and Properties are not appearing correctly in dark mode on Vector 2022.Mar 19 2025, 11:21 AM
ArthurTaylor moved this task from Incoming to The Backlog on the Wikidata-Omega board.
ArthurTaylor claimed this task.Mar 19 2025, 12:12 PM
ArthurTaylor moved this task from The Backlog to The Board on the Wikidata-Omega board.
ArthurTaylor edited projects, added: Wikidata-Omega (The Board); removed: Wikidata-Omega.
ArthurTaylor moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Mar 19 2025, 12:27 PM

Change #1129235 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Update colour for .wikibase-title-id to a codex token

https://gerrit.wikimedia.org/r/1129235

gerritbot added a project: Patch-For-Review.Mar 19 2025, 12:27 PM
ArthurTaylor added a comment.Mar 19 2025, 12:31 PM

Heading looks somewhat better now:

2025-03-19-132742_475x163_scrot.png (475×163 px, 11 KB)

There are a couple of other references to the colour value (.wikibase-toolbarbutton-disabled, .wikibase-toolbarlabel.ui-state-disabled and .wikibase-statementview-references-heading), but they don't appear to correspond to elements in the UX.

ArthurTaylor removed ArthurTaylor as the assignee of this task.Mar 19 2025, 12:31 PM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.
• Lucas_Werkmeister_WMDE claimed this task.EditedMar 19 2025, 4:20 PM
• Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
• Lucas_Werkmeister_WMDE subscribed.
In T389343#10651644, @ArthurTaylor wrote:

There are a couple of other references to the colour value (.wikibase-toolbarbutton-disabled, .wikibase-toolbarlabel.ui-state-disabled and .wikibase-statementview-references-heading), but they don't appear to correspond to elements in the UX.

  • .wikibase-toolbarbutton-disabled is e.g. the “save” button right after you’ve clicked “edit” (it becomes disabled once you make changes): image.png (143×27 px, 2 KB)
  • .wikibase-toolbarlabel appears to have become unused with Refactored toolbars, a mere decade ago. Let’s remove those styles.
  • .wikibase-statementview-references-heading can probably have its color removed, AFAICT the only contents is the “x reference(s)” toggler that has its own color (which was fixed in T389345).
gerritbot added a comment.Mar 19 2025, 4:31 PM

Change #1129316 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove long-unused .wikibase-toolbarlabel styles

https://gerrit.wikimedia.org/r/1129316

gerritbot added a comment.Mar 19 2025, 4:38 PM

Change #1129318 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use Codex token for .wikibase-toolbarbutton-disabled

https://gerrit.wikimedia.org/r/1129318

• Lucas_Werkmeister_WMDE added a comment.Mar 19 2025, 4:55 PM
In T389343#10653029, @Lucas_Werkmeister_WMDE wrote:
  • .wikibase-statementview-references-heading can probably have its color removed, AFAICT the only contents is the “x reference(s)” toggler that has its own color (which was fixed in T389345).

Aha, the color is still in effect when JavaScript is disabled! (Found in this 2016 commit via git blame. Note that the “diff and old revisions” part mentioned there no longer applies, those also get functional togglers nowadays.) So we should keep it and ask UX what the right value is.

gerritbot added a comment.Mar 19 2025, 6:25 PM

Change #1129235 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update colour for .wikibase-title-id to a codex token

https://gerrit.wikimedia.org/r/1129235

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.22; 2025-03-25).Mar 19 2025, 7:00 PM
gerritbot added a comment.Mar 20 2025, 9:19 AM

Change #1129316 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove long-unused .wikibase-toolbarlabel styles

https://gerrit.wikimedia.org/r/1129316

gerritbot added a comment.Mar 20 2025, 3:04 PM

Change #1129851 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use @color-disabled for references heading

https://gerrit.wikimedia.org/r/1129851

• Lucas_Werkmeister_WMDE removed • Lucas_Werkmeister_WMDE as the assignee of this task.Mar 20 2025, 3:54 PM
• Lucas_Werkmeister_WMDE moved this task from In Peer Review to Ready for Peer Review on the Wikidata-Omega (The Board) board.
ArthurTaylor claimed this task.Mar 21 2025, 7:35 AM
ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
ArthurTaylor removed ArthurTaylor as the assignee of this task.Mar 21 2025, 7:40 AM
ArthurTaylor moved this task from In Peer Review to Product Verification on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Mar 21 2025, 8:00 AM

Change #1129851 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use @color-disabled for references heading

https://gerrit.wikimedia.org/r/1129851

gerritbot added a comment.Mar 21 2025, 8:00 AM

Change #1129318 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use Codex token for .wikibase-toolbarbutton-disabled

https://gerrit.wikimedia.org/r/1129318

Maintenance_bot removed a project: Patch-For-Review.Mar 21 2025, 8:29 AM
Arian_Bozorg closed this task as Resolved.Mar 24 2025, 12:16 PM
Arian_Bozorg claimed this task.
Arian_Bozorg moved this task from Product Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.
Arian_Bozorg subscribed.

Looks good to me

karapayneWMDE edited projects, added: Wikidata-Omega (Completed Tasks); removed: Wikidata-Omega (The Board).Apr 11 2025, 8:01 AM
karapayneWMDE moved this task from Newly completed tasks to 2025 Q1 on the Wikidata-Omega (Completed Tasks) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits