Page MenuHomePhabricator
Create Task
Maniphest T389345

[Darkmode] Fix the colour of 'In more languages' toggler / dropdown
Closed, ResolvedPublic
Actions

Description

The 'In more languages' dropdown has the hard-coded colour value #0645ad, which doesn't map to any codex token. In the Figma file this is mapped to color-progressive, but the colour value is set in ./view/lib/wikibase-data-values-value-view/lib/jquery.ui/jquery.ui.toggler.css, which belongs to data-values/value-view and is a CSS file (so no LESS variables are available).

2025-03-19-122159_454x258_scrot.png (454×258 px, 20 KB)

Investigate changing this token to the correct colour value - decide whether to use CSS variables or to change the CSS file to a LESS file.

Acceptance Criteria

  • The 'In more languages' link is mapped to the correct codex token (color-progressive)
  • (Optional) other hard-coded colour-values in data-values/value-view are identified and replaced with their codex equivalents.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Bump wikibase-data-values-value-view to HEADLucas Werkmeister (WMDE)mediawiki/extensions/Wikibasemaster+1 -1
Use `color-progressive` codex token for toggler colourArthur taylordata-values/value-viewmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

ArthurTaylor created this task.Mar 19 2025, 11:29 AM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptMar 19 2025, 11:29 AM
ArthurTaylor added a parent task: T369385: Colours on Wikidata Items and Properties are not appearing correctly in dark mode on Vector 2022.Mar 19 2025, 11:30 AM
ArthurTaylor moved this task from Incoming to The Backlog on the Wikidata-Omega board.Mar 19 2025, 11:37 AM
ArthurTaylor claimed this task.Mar 19 2025, 12:32 PM
ArthurTaylor moved this task from The Backlog to The Board on the Wikidata-Omega board.
ArthurTaylor edited projects, added: Wikidata-Omega (The Board); removed: Wikidata-Omega.
ArthurTaylor moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Mar 19 2025, 12:44 PM

Change #1129238 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[data-values/value-view@master] Use `color-progressive` codex token for toggler colour

https://gerrit.wikimedia.org/r/1129238

gerritbot added a project: Patch-For-Review.Mar 19 2025, 12:44 PM
ArthurTaylor added a comment.Mar 19 2025, 12:46 PM

Added a change to data-values/value-view. The submodule reference in Wikibase will need to be bumped to make the change live once it's been merged to data-values/value-view.

ArthurTaylor removed ArthurTaylor as the assignee of this task.Mar 19 2025, 12:47 PM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.
• Lucas_Werkmeister_WMDE claimed this task.Mar 19 2025, 12:59 PM
• Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
• Lucas_Werkmeister_WMDE added a comment.Mar 19 2025, 1:05 PM

Note: the attached patch fixes not just “in more languages” but also “x reference(s)” (evidently that’s also a toggler).

gerritbot added a comment.Mar 19 2025, 1:10 PM

Change #1129238 merged by jenkins-bot:

[data-values/value-view@master] Use `color-progressive` codex token for toggler colour

https://gerrit.wikimedia.org/r/1129238

gerritbot added a comment.Mar 19 2025, 1:13 PM

Change #1129248 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Bump wikibase-data-values-value-view to HEAD

https://gerrit.wikimedia.org/r/1129248

• Lucas_Werkmeister_WMDE removed • Lucas_Werkmeister_WMDE as the assignee of this task.Mar 19 2025, 1:13 PM
• Lucas_Werkmeister_WMDE moved this task from In Peer Review to Ready for Peer Review on the Wikidata-Omega (The Board) board.
• Lucas_Werkmeister_WMDE subscribed.
ArthurTaylor claimed this task.Mar 19 2025, 1:27 PM
ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
ArthurTaylor removed ArthurTaylor as the assignee of this task.Mar 19 2025, 1:35 PM
ArthurTaylor moved this task from In Peer Review to Product Verification on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Mar 19 2025, 2:10 PM

Change #1129248 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Bump wikibase-data-values-value-view to HEAD

https://gerrit.wikimedia.org/r/1129248

Maintenance_bot removed a project: Patch-For-Review.Mar 19 2025, 2:30 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.22; 2025-03-25).Mar 19 2025, 3:00 PM
• Lucas_Werkmeister_WMDE mentioned this in T389343: [Darkmode] Find mapping for #72777d in `h1 .wikibase-title-id`.Mar 19 2025, 4:20 PM
Arian_Bozorg closed this task as Resolved.Mar 24 2025, 9:59 AM
Arian_Bozorg claimed this task.
Arian_Bozorg moved this task from Product Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.
Arian_Bozorg subscribed.

Looks good!

karapayneWMDE removed a project: Wikidata-Omega (The Board).Apr 11 2025, 8:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits