Page MenuHomePhabricator
Create Task
Maniphest T389361

Inserting an external link in source mode creates incorrect wikitext
Closed, ResolvedPublic
Actions

Description

  1. Open VE in source mode. Place the cursor in an empty paragraph.
  2. Open the link tool, type a url into the external tab http://example.org, and press insert.

Observed
[http://example.org]http://example.org is inserted
Expected
[http://example.org] is inserted (a numbered external link, matching visual mode)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
MWWikitextLinkAnnotationInspector: Improve external link behaviourmediawiki/extensions/VisualEditormaster+26 -16
Customize query in gerrit

Event Timeline

Esanders created this task.Mar 19 2025, 1:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2025, 1:53 PM
gerritbot added a comment.Mar 19 2025, 3:13 PM

Change #1129294 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] MWWikitextLinkAnnotationInspector: Improve external link behaviour

https://gerrit.wikimedia.org/r/1129294

gerritbot added a project: Patch-For-Review.Mar 19 2025, 3:13 PM
DLynch assigned this task to Esanders.Mar 21 2025, 3:04 PM
DLynch added projects: Editing-team (Kanban Board), Editing QA.
DLynch moved this task from Inbox to QA on the Editing-team (Kanban Board) board.
gerritbot added a comment.Mar 21 2025, 3:50 PM

Change #1129294 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] MWWikitextLinkAnnotationInspector: Improve external link behaviour

https://gerrit.wikimedia.org/r/1129294

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.22; 2025-03-25).Mar 21 2025, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 21 2025, 4:30 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Mar 25 2025, 10:15 PM
Ryasmeen edited projects, added Verified; removed Editing QA.
VPuffetMichel closed this task as Resolved.Apr 26 2025, 3:39 PM
VPuffetMichel edited projects, added Essential-Work; removed Verified, MW-1.44-notes (1.44.0-wmf.22; 2025-03-25), Editing-team (Kanban Board), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor.
Aklapper added projects: Verified, MW-1.44-notes (1.44.0-wmf.22; 2025-03-25), Editing-team (Kanban Board), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor.May 1 2025, 9:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits