Page MenuHomePhabricator

Code cleanup: Remove stable API for extending Overlay and View classes
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

We want to move MobileFrontend onto Vue eventually. Previously this was difficult as we had many extensions extending its functionality. In T381627 we removed the last consumer. This work is important as it helps us gradually move onto Vue.js and move off of Webpack

User story

As a maintainer of web team products I want to move MobileFrontend to Vue.js so that teams can build features cross platform.

Requirements

  • require( 'mobile.startup' ).View.make should exist
  • require( 'mobile.startup' ).Overlay.make should exist
  • new require( 'mobile.startup' ).View() should throw an error
  • new require( 'mobile.startup' ).Overlay() should throw an error
  • Modules inside MobileFrontend can access classes via new new require( 'mobile.startup' ).class.View interface.

BDD

  • For QA engineer to fill out

Test Steps

  • For QA engineer to fill out

Design

  • Add mockups and design requirements

Acceptance criteria

  • Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.2.0 of the Web team task template using phabulous

Event Timeline

Jdlrobson-WMF renamed this task from Remove stable API for extending Overlay and View classes to Code cleanup: Remove stable API for extending Overlay and View classes.Mar 19 2025, 10:24 PM
Jdlrobson-WMF updated the task description. (Show Details)

Change #1128901 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Do not expose View and Overlay to external extensions

https://gerrit.wikimedia.org/r/1128901

Jdlrobson-WMF changed the task status from Open to In Progress.Mar 19 2025, 10:26 PM
Jdlrobson-WMF set the point value for this task to 1.

Per team estimation. The sooner we can do this the less work on the long term.

Jdlrobson-WMF changed the task status from In Progress to Open.Mar 31 2025, 5:16 PM
Jdlrobson-WMF raised the priority of this task from Medium to High.EditedApr 24 2025, 6:04 AM
Jdlrobson-WMF moved this task from Q4 to Sprint Backlog on the Web-Team board.

The MediaWiki release is coming up (this will probably have to be backported since it missed sprint 2).

MSantos subscribed.

Today is the last day before the train rides for 1.44.0-wmf.28 [1] and the alpha branch release [2] will soon be announced.

I'm flagging this task as a non-blocker, but if that's not right, please make sure this is resolved and backported before the release is complete in a few weeks.

https://www.mediawiki.org/wiki/MediaWiki_1.44/wmf.28
https://www.mediawiki.org/wiki/MediaWiki_1.44/Roadmap

Change #1128901 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Do not expose View and Overlay to external extensions

https://gerrit.wikimedia.org/r/1128901