Maniphest T389478

ContributionsPager: Special:Contributions displays an empty pair of parentheses at the end of rows
Closed, ResolvedPublic
Actions

Description

Summary

As part of T388377: Special:GlobalContributions on mobile/Minerva displays an empty pair of parentheses at the end of (non-central-wiki) rows, we updated how the usernames are shown in the list of global contributions in order to use CSS instead of $this->msg( 'parentheses' ) to style how user links are shown.
However, the same approach is also used in core's ContributionsPager, therefore it should be also updated to use CSS classes instead to prevent problems when using the Minerva skin.

Acceptance criteria

User links in Special:Contributions are styled using CSS instead of hardcoded parenthesis in the HTML output.
Empty parenthesis are not shown in Special:Contributions when using the Minerva skin

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	contributions: Use CSS classes for user links	Harroyo-wmf	mediawiki/core	master	+7 -5

Customize query in gerrit

Related Objects

Mentioned Here: T388377: Special:GlobalContributions on mobile/Minerva displays an empty pair of parentheses at the end of (non-central-wiki) rows

Event Timeline

• hector.arroyo created this task.Mar 20 2025, 11:07 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2025, 11:07 AM

• hector.arroyo added a project: MinervaNeue.Mar 20 2025, 11:09 AM

• hector.arroyo edited projects, added: Trust and Safety Product Sprint (Sprint Chocolate Cake (March 24 - April 11)); removed: Trust and Safety Product Sprint (Sprint Lemon Meringue (March 3 - 21)).Mar 20 2025, 11:13 AM

A_smart_kitten added a project: MediaWiki-Special-pages.Mar 20 2025, 4:58 PM

A_smart_kitten moved this task from To triage to Special:Contributions / Special:DeletedContributions on the MediaWiki-Special-pages board.

A_smart_kitten subscribed.

• hector.arroyo updated the task description. (Show Details)Mar 20 2025, 5:30 PM

Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.Apr 3 2025, 11:25 AM

• hector.arroyo claimed this task.Apr 4 2025, 12:32 PM

• hector.arroyo moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Chocolate Cake (March 24 - April 11)) board.

Change #1134220 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/core@master] contributions: Use CSS classes for user links

https://gerrit.wikimedia.org/r/1134220

gerritbot added a project: Patch-For-Review.Apr 4 2025, 1:05 PM

• hector.arroyo moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Chocolate Cake (March 24 - April 11)) board.Apr 4 2025, 1:27 PM

Change #1134220 merged by jenkins-bot:

[mediawiki/core@master] contributions: Use CSS classes for user links

https://gerrit.wikimedia.org/r/1134220

Maintenance_bot removed a project: Patch-For-Review.Apr 4 2025, 6:30 PM

• hector.arroyo moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Chocolate Cake (March 24 - April 11)) board.Apr 4 2025, 6:33 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.24; 2025-04-08).Apr 4 2025, 7:00 PM

QA is completed, and the new code has been implemented and is functioning as expected (Special:Contributions does not display an empty pair of parentheses at the end of rows).

kostajh closed this task as Resolved.Apr 14 2025, 8:04 AM

	F58878215: image.png
	Mar 20 2025, 11:07 AM

ContributionsPager: Special:Contributions displays an empty pair of parentheses at the end of rowsClosed, ResolvedPublicActions