Page MenuHomePhabricator
Create Task
Maniphest T389506

Use of MediaWiki\Title\Title::getPageViewLanguage was deprecated in MediaWiki 1.42
Open, Needs TriagePublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Visit one of the skins tagged in this bug report

What happens?:

  • Note Deprecated: Use of MediaWiki\Title\Title::getPageViewLanguage was deprecated in MediaWiki 1.42. [Called from CavendishTemplate::execute in /Users/jdlrobson/git/core/skins/Cavendish/CavendishTemplate.php at line 299] in /Users/jdlrobson/git/core/includes/debug/MWDebug.php on line 386 in page or logs (depending on how your MediaWiki is configured)

What should have happened instead?:

No deprecation notice

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATEDmediawiki/skins/TruglassREL1_43+2 -2
Replace deprecated getPageViewLanguage with getViewLanguagemediawiki/skins/Cavendishmaster+1 -1
Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATEDmediawiki/skins/MetrolookREL1_42+1 -2
Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATEDmediawiki/skins/MetrolookREL1_43+1 -2
Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATEDmediawiki/skins/Bouquetmaster+1 -1
Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATEDmediawiki/skins/Duskmaster+1 -1
Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED, require MW 1.43+mediawiki/skins/DuskToDawnmaster+4 -10
Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATEDmediawiki/skins/Gamepressmaster+1 -1
Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED and other updates for (and now requires) MW 1.43(+)mediawiki/skins/GreyStuffmaster+3 -6
Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATEDmediawiki/skins/Maskmaster+1 -1
Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATEDmediawiki/skins/Metrolookmaster+1 -2
Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATEDmediawiki/skins/Truglassmaster+2 -2
Fix: Replace deprecated Title::getPageViewLanguage methodmediawiki/skins/Cavendishmaster+1 -1
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson-WMF created this task.Mar 20 2025, 4:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2025, 4:40 PM
Jdlrobson-WMF added a project: Bouquet.Mar 20 2025, 4:41 PM
Jdlrobson-WMF added a project: DuskToDawn.
Jdlrobson-WMF added a project: Gamepress.Mar 20 2025, 4:44 PM
Jdlrobson-WMF added projects: HasSomeColours, patch-welcome, good first task.Mar 20 2025, 5:33 PM
Restricted Application added a comment. · View Herald TranscriptMar 20 2025, 5:33 PM

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

NirSikron subscribed.Mar 22 2025, 7:33 AM
This comment was removed by NirSikron.
NirSikron added a comment.Mar 22 2025, 7:34 AM

This is my first task!

Aklapper added a comment.Mar 22 2025, 7:54 AM

Hi and welcome. Please see https://www.mediawiki.org/wiki/New_Developers#Communication_tips

Gerges subscribed.Mar 23 2025, 5:26 PM
Restricted Application added a subscriber: alaa. · View Herald TranscriptMar 23 2025, 5:26 PM
ParvC claimed this task.Mar 24 2025, 12:06 PM
gerritbot added a comment.Mar 25 2025, 4:34 PM

Change #1131046 had a related patch set uploaded (by ParvC; author: ParvC):

[mediawiki/skins/Cavendish@master] Fix: Replace deprecated Title::getPageViewLanguage method (T389506)

https://gerrit.wikimedia.org/r/1131046

gerritbot added a project: Patch-For-Review.Mar 25 2025, 4:34 PM
gerritbot added a comment.Mar 25 2025, 9:07 PM

Change #1131046 had a related patch set uploaded (by Pppery; author: ParvC):

[mediawiki/skins/Cavendish@master] Fix: Replace deprecated Title::getPageViewLanguage method

https://gerrit.wikimedia.org/r/1131046

gerritbot added a comment.Mar 27 2025, 10:26 AM

Change #1131046 merged by jenkins-bot:

[mediawiki/skins/Cavendish@master] Fix: Replace deprecated Title::getPageViewLanguage method

https://gerrit.wikimedia.org/r/1131046

Pppery mentioned this in rSCAVf4efd3dd3545: Fix: Replace deprecated Title::getPageViewLanguage method.Mar 27 2025, 10:29 AM
Pppery removed ParvC as the assignee of this task.Mar 27 2025, 3:13 PM
Pppery removed projects: Patch-For-Review, MediaWiki-skins-Cavendish.
Pppery added subscribers: ParvC, Pppery.

(Leaving open for the other skins - feel free to reclaim if you want to work on one of those too)

Pppery unsubscribed.Mar 27 2025, 3:14 PM
Jdlrobson-WMF awarded a token.Mar 27 2025, 3:59 PM
ashley added projects: Dusk, Truglass, Metrolook, GreyStuff, Mask.Mar 30 2025, 11:32 AM
gerritbot added a comment.Apr 6 2025, 10:46 AM

Change #1134360 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/skins/Bouquet@master] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1134360

gerritbot added a project: Patch-For-Review.Apr 6 2025, 10:46 AM

Change #1134361 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/skins/Dusk@master] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1134361

gerritbot added a comment.Apr 6 2025, 10:47 AM

Change #1134362 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/skins/DuskToDawn@master] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED, require MW 1.43+

https://gerrit.wikimedia.org/r/1134362

gerritbot added a comment.Apr 6 2025, 10:48 AM

Change #1134363 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/skins/Gamepress@master] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1134363

gerritbot added a comment.Apr 6 2025, 10:48 AM

Change #1134364 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/skins/GreyStuff@master] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED and other updates for (and now requires) MW 1.43(+)

https://gerrit.wikimedia.org/r/1134364

gerritbot added a comment.Apr 6 2025, 10:49 AM

Change #1134365 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/skins/Mask@master] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1134365

gerritbot added a comment.Apr 6 2025, 10:50 AM

Change #1134366 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/skins/Metrolook@master] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1134366

gerritbot added a comment.Apr 6 2025, 10:51 AM

Change #1134367 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/skins/Truglass@master] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1134367

gerritbot added a comment.Apr 9 2025, 12:33 PM

Change #1134367 merged by jenkins-bot:

[mediawiki/skins/Truglass@master] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1134367

gerritbot added a comment.Apr 9 2025, 12:34 PM

Change #1134366 merged by jenkins-bot:

[mediawiki/skins/Metrolook@master] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1134366

gerritbot added a comment.Apr 9 2025, 12:35 PM

Change #1134365 merged by jenkins-bot:

[mediawiki/skins/Mask@master] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1134365

gerritbot added a comment.Apr 9 2025, 12:36 PM

Change #1134364 merged by jenkins-bot:

[mediawiki/skins/GreyStuff@master] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED and other updates for (and now requires) MW 1.43(+)

https://gerrit.wikimedia.org/r/1134364

gerritbot added a comment.Apr 9 2025, 12:37 PM

Change #1134363 merged by jenkins-bot:

[mediawiki/skins/Gamepress@master] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1134363

gerritbot added a comment.Apr 9 2025, 12:38 PM

Change #1134362 merged by jenkins-bot:

[mediawiki/skins/DuskToDawn@master] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED, require MW 1.43+

https://gerrit.wikimedia.org/r/1134362

gerritbot added a comment.Apr 9 2025, 12:40 PM

Change #1134361 merged by jenkins-bot:

[mediawiki/skins/Dusk@master] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1134361

gerritbot added a comment.Apr 9 2025, 12:41 PM

Change #1134360 merged by jenkins-bot:

[mediawiki/skins/Bouquet@master] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1134360

gerritbot added a comment.Oct 6 2025, 4:15 PM

Change #1193895 had a related patch set uploaded (by Paladox; author: Jack Phoenix):

[mediawiki/skins/Metrolook@REL1_43] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1193895

gerritbot added a comment.Oct 6 2025, 4:17 PM

Change #1193896 had a related patch set uploaded (by Paladox; author: Jack Phoenix):

[mediawiki/skins/Metrolook@REL1_42] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1193896

gerritbot added a comment.Oct 6 2025, 4:19 PM

Change #1193895 merged by jenkins-bot:

[mediawiki/skins/Metrolook@REL1_43] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1193895

alex-mashin subscribed.EditedOct 6 2025, 4:22 PM

I've been informed that the bug is a duplicate of T389506; and a patch has been merged: https://gerrit.wikimedia.org/r/c/mediawiki/skins/Metrolook/+/1134366; yet it hasn't made it to REL1_43: https://gerrit.wikimedia.org/r/c/mediawiki/skins/Metrolook/+/1193895 has not been merged.

gerritbot added a comment.Oct 6 2025, 5:45 PM

Change #1193896 merged by Paladox:

[mediawiki/skins/Metrolook@REL1_42] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1193896

Pppery removed a project: Patch-For-Review.Jan 11 2026, 4:19 PM

Anything left to do here?

Suraj_Seth claimed this task.Jan 13 2026, 1:59 PM
Suraj_Seth subscribed.

"I am working on this task."

gerritbot added a comment.Jan 13 2026, 3:04 PM

Change #1226273 had a related patch set uploaded (by Suraj Seth; author: Suraj Seth):

[mediawiki/skins/Cavendish@master] Replace deprecated getPageViewLanguage with getLanguage

https://gerrit.wikimedia.org/r/1226273

gerritbot added a project: Patch-For-Review.Jan 13 2026, 3:05 PM
gerritbot added a comment.Mar 1 2026, 11:54 AM

Change #1246746 had a related patch set uploaded (by Lewis Cawte; author: Jack Phoenix):

[mediawiki/skins/Truglass@REL1_43] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1246746

gerritbot added a comment.Mar 1 2026, 12:01 PM

Change #1246746 merged by jenkins-bot:

[mediawiki/skins/Truglass@REL1_43] Remove calls to MediaWiki\Title\Title::getPageViewLanguage to avoid E_DEPRECATED

https://gerrit.wikimedia.org/r/1246746

Prashant32194 subscribed.Sun, Apr 12, 3:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits