Page MenuHomePhabricator
Create Task
Maniphest T389515

PHP Deprecated: Return type of Flow\Search\Iterators\AbstractIterator::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Return type of Flow\Search\Iterators\AbstractIterator::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.21/extensions/Flow/includes/Search/Iterators/AbstractIterator.php(117)
#0/srv/mediawiki/php-1.44.0-wmf.21/extensions/Flow/includes/Search/Iterators/AbstractIterator.php(16)MWExceptionHandler::handleError(int, string, string, int)
#1/srv/mediawiki/php-1.44.0-wmf.21/includes/AutoLoader.php(226)require_once(string)
#2/srv/mediawiki/php-1.44.0-wmf.21/extensions/Flow/includes/Search/Iterators/HeaderIterator.php(5)AutoLoader::autoload(string)
#3/srv/mediawiki/php-1.44.0-wmf.21/includes/AutoLoader.php(226)require_once(string)
#4/srv/mediawiki/php-1.44.0-wmf.21/extensions/Flow/container.php(732)AutoLoader::autoload(string)
#5/srv/mediawiki/php-1.44.0-wmf.21/vendor/pimple/pimple/src/Pimple/Container.php(122)Flow\Container::{closure}(Flow\Container)
#6/srv/mediawiki/php-1.44.0-wmf.21/extensions/Flow/includes/Container.php(46)Pimple\Container->offsetGet(string)
#7/srv/mediawiki/php-1.44.0-wmf.21/extensions/Flow/includes/Dump/Exporter.php(217)Flow\Container::get(string)
#8/srv/mediawiki/php-1.44.0-wmf.21/extensions/Flow/maintenance/dumpBackup.php(104)Flow\Dump\Exporter->dump(BatchRowIterator)
#9/srv/mediawiki/php-1.44.0-wmf.21/extensions/Flow/maintenance/dumpBackup.php(66)Flow\Maintenance\FlowDumpBackup->dump(int)
#10/srv/mediawiki/php-1.44.0-wmf.21/maintenance/includes/MaintenanceRunner.php(695)Flow\Maintenance\FlowDumpBackup->execute()
#11/srv/mediawiki/php-1.44.0-wmf.21/maintenance/run.php(51)MediaWiki\Maintenance\MaintenanceRunner->run()
#12/srv/mediawiki/multiversion/MWScript.php(219)require_once(string)
#13{main}
Impact
Notes

Especially noisy since T382484: WE 5.4 KR - Hypothesis 5.4.6 - Q3 FY24/25 - Validate Dumps 1.0 compatibility with PHP 8.1

Applies to all the iterator functions

[{reqId}] {exception_url} PHP Deprecated: Return type of Flow\Search\Iterators\AbstractIterator::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the

Row: 1, Column: 1:
533

Row: 1, Column: 2:
[{reqId}] {exception_url} PHP Deprecated: Return type of Flow\Search\Iterators\AbstractIterator::key() should either be compatible with Iterator::key(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

Row: 2, Column: 1:
533

Row: 2, Column: 2:
[{reqId}] {exception_url} PHP Deprecated: Return type of Flow\Search\Iterators\AbstractIterator::next() should either be compatible with Iterator::next(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

Row: 3, Column: 1:
533

Row: 3, Column: 2:
[{reqId}] {exception_url} PHP Deprecated: Return type of Flow\Search\Iterators\AbstractIterator::rewind() should either be compatible with Iterator::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the not

Row: 4, Column: 1:
533

Row: 4, Column: 2:
[{reqId}] {exception_url} PHP Deprecated: Return type of Flow\Search\Iterators\AbstractIterator::valid() should either be compatible with Iterator::valid(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notic

Row: 5, Column: 1:
533

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
AbstractIterator: Make PHP 8.1 compatibleReedymediawiki/extensions/Flowmaster+8 -4
AbstractIterator: Make PHP 8.1 compatibleReedymediawiki/extensions/FlowREL1_43+8 -4
AbstractIterator: Make PHP 8.1 compatibleReedymediawiki/extensions/FlowREL1_39+8 -4
AbstractIterator: Make PHP 8.1 compatibleReedymediawiki/extensions/FlowREL1_42+8 -4
AbstractIterator: Make PHP 8.1 compatibleJforrestermediawiki/extensions/Flowwmf/1.44.0-wmf.21+8 -4
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedNoneT379874 ☂ PHP 8.1 issues found during WMF rollout/ramp up
ResolvedPRODUCTION ERRORReedyT389515 PHP Deprecated: Return type of Flow\Search\Iterators\AbstractIterator::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used
· · ·

Event Timeline

Reedy created this task.Mar 20 2025, 5:23 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 20 2025, 5:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy added a parent task: T379874: ☂ PHP 8.1 issues found during WMF rollout/ramp up.Mar 20 2025, 5:23 PM
gerritbot added a comment.Mar 20 2025, 5:28 PM

Change #1129897 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Flow@master] AbstractIterator: Make PHP 8.1 compatible

https://gerrit.wikimedia.org/r/1129897

gerritbot added a project: Patch-For-Review.Mar 20 2025, 5:28 PM
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.Mar 20 2025, 5:28 PM
Reedy updated the task description. (Show Details)
Reedy triaged this task as High priority.Mar 20 2025, 5:31 PM
Reedy updated the task description. (Show Details)
Reedy added a project: Dumps-Generation.Mar 20 2025, 5:33 PM
Reedy moved this task from Untriaged to Mar 2025 on the Wikimedia-production-error board.Mar 20 2025, 5:37 PM
Reedy merged a task: T389489: PHP Deprecated: Return type of Flow\Search\Iterators\AbstractIterator::next() should either be compatible with Iterator::next(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice.
Reedy added subscribers: • jnuche, alaa, hubaishan.
gerritbot added a comment.Mar 20 2025, 7:01 PM

Change #1129914 had a related patch set uploaded (by Jforrester; author: Reedy):

[mediawiki/extensions/Flow@wmf/1.44.0-wmf.21] AbstractIterator: Make PHP 8.1 compatible

https://gerrit.wikimedia.org/r/1129914

gerritbot added a comment.Mar 20 2025, 7:55 PM

Change #1129897 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] AbstractIterator: Make PHP 8.1 compatible

https://gerrit.wikimedia.org/r/1129897

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.22; 2025-03-25).Mar 20 2025, 8:00 PM
gerritbot added a comment.Mar 20 2025, 8:38 PM

Change #1129929 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Flow@REL1_43] AbstractIterator: Make PHP 8.1 compatible

https://gerrit.wikimedia.org/r/1129929

gerritbot added a comment.Mar 20 2025, 8:38 PM

Change #1129930 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Flow@REL1_42] AbstractIterator: Make PHP 8.1 compatible

https://gerrit.wikimedia.org/r/1129930

gerritbot added a comment.Mar 20 2025, 8:39 PM

Change #1129931 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Flow@REL1_39] AbstractIterator: Make PHP 8.1 compatible

https://gerrit.wikimedia.org/r/1129931

gerritbot added a comment.Mar 20 2025, 8:51 PM

Change #1129914 merged by jenkins-bot:

[mediawiki/extensions/Flow@wmf/1.44.0-wmf.21] AbstractIterator: Make PHP 8.1 compatible

https://gerrit.wikimedia.org/r/1129914

gerritbot added a comment.Mar 20 2025, 8:55 PM

Change #1129930 merged by jenkins-bot:

[mediawiki/extensions/Flow@REL1_42] AbstractIterator: Make PHP 8.1 compatible

https://gerrit.wikimedia.org/r/1129930

Reedy renamed this task from PHP Deprecated: Return type of Flow\Search\Iterators\AbstractIterator::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the to PHP Deprecated: Return type of Flow\Search\Iterators\AbstractIterator::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used.Mar 20 2025, 8:56 PM
gerritbot added a comment.Mar 20 2025, 8:57 PM

Change #1129931 merged by jenkins-bot:

[mediawiki/extensions/Flow@REL1_39] AbstractIterator: Make PHP 8.1 compatible

https://gerrit.wikimedia.org/r/1129931

gerritbot added a comment.Mar 20 2025, 8:57 PM

Change #1129929 merged by jenkins-bot:

[mediawiki/extensions/Flow@REL1_43] AbstractIterator: Make PHP 8.1 compatible

https://gerrit.wikimedia.org/r/1129929

Stashbot mentioned this in T384153: SUL3 Phase 3: All existing user login on group 0 and group 1 wikis.Mar 20 2025, 8:59 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-20T20:59:44Z] <tgr@deploy2002> Started scap sync-world: Backport for [[gerrit:1129435|Throttle exemption for Editathon in Ciudad de Buenos Aires - 29 March 2025 (T389400)]], [[gerrit:1129905|Enable SUL3 logins for 50% of group 1 users (T384153)]], [[gerrit:1129914|AbstractIterator: Make PHP 8.1 compatible (T389515)]]

Stashbot mentioned this in T389400: Lift IP for a edit-a-thon in Ciudad de Buenos Aires, Argentina 2025-03-29 .Mar 20 2025, 8:59 PM
ReleaseTaggerBot edited projects, added: MW-1.44-notes (1.44.0-wmf.21; 2025-03-18); removed: MW-1.44-notes (1.44.0-wmf.22; 2025-03-25).Mar 20 2025, 9:00 PM
Stashbot added a comment.Mar 20 2025, 9:04 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-20T21:04:35Z] <tgr@deploy2002> tgr, jforrester, superpes: Backport for [[gerrit:1129435|Throttle exemption for Editathon in Ciudad de Buenos Aires - 29 March 2025 (T389400)]], [[gerrit:1129905|Enable SUL3 logins for 50% of group 1 users (T384153)]], [[gerrit:1129914|AbstractIterator: Make PHP 8.1 compatible (T389515)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Mar 20 2025, 9:14 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-20T21:14:11Z] <tgr@deploy2002> Finished scap sync-world: Backport for [[gerrit:1129435|Throttle exemption for Editathon in Ciudad de Buenos Aires - 29 March 2025 (T389400)]], [[gerrit:1129905|Enable SUL3 logins for 50% of group 1 users (T384153)]], [[gerrit:1129914|AbstractIterator: Make PHP 8.1 compatible (T389515)]] (duration: 14m 26s)

Reedy closed this task as Resolved.Mar 20 2025, 9:31 PM
Reedy claimed this task.
Maintenance_bot removed a project: Patch-For-Review.Mar 20 2025, 9:31 PM
Krinkle moved this task from Mar 2025 to Jan-Mar 2025 on the Wikimedia-production-error board.Apr 1 2025, 2:12 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits