Page MenuHomePhabricator
Create Task
Maniphest T389608

ENotif should verify isEmailConfirmed when sending notifications to UsersNotifiedOnAllChanges
Closed, ResolvedPublic
Actions

Description

The ENotif has a logic that it verified if the email is confirmed:

However when refactoring the UsersNotifiedOnAllChanges part we found out that this code doesn't check verify isEmailConfirmed() when sending emails to people listed in UsersNotifiedOnAllChanges.

To be consistent with other two notifications, and as a good practice - RecentChangeNotificationsHandler should send notifications only to users who have confirmed emails.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make $wgUsersNotifiedOnAllChanges require confirmed emailsmediawiki/coremaster+5 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

pmiazga created this task.Mar 21 2025, 11:05 AM
pmiazga added projects: Mail, MediaWiki-Watchlist.Mar 21 2025, 11:13 AM
Restricted Application added projects: Infrastructure-Foundations, Moderator-Tools-Team. · View Herald TranscriptMar 21 2025, 11:13 AM
pmiazga removed projects: Infrastructure-Foundations, Mail.Mar 21 2025, 11:14 AM
Samwalton9-WMF moved this task from Inbox to Triaged on the Moderator-Tools-Team board.Mar 21 2025, 3:36 PM
pmiazga moved this task from Inbox, needs triage to In progress (DO NOT USE) on the MediaWiki-Platform-Team board.Mar 24 2025, 3:45 PM
matmarex claimed this task.Mar 24 2025, 6:40 PM
gerritbot added a comment.Mar 26 2025, 6:38 PM

Change #1131408 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Make $wgUsersNotifiedOnAllChanges require confirmed emails

https://gerrit.wikimedia.org/r/1131408

gerritbot added a project: Patch-For-Review.Mar 26 2025, 6:38 PM
matmarex added a comment.Mar 26 2025, 6:47 PM

Test plan:

  1. Add user A to $wgUsersNotifiedOnAllChanges
  2. As user A, set an email address without confirming it
  3. As user B, edit a page that user A is not watching (and not their user talk page)
  4. As user A, verify that you did not receive the email (Extension:Inbox is convenient for local testing without really sending emails)
  5. As user A, confirm your email address (or use resetUserEmail.php --no-reset-password to do it without really sending confirmation emails)
  6. As user B, edit a page that user A is not watching again
  7. As user A, verify that you received the email this time
gerritbot added a comment.Mar 27 2025, 1:48 PM

Change #1131408 merged by jenkins-bot:

[mediawiki/core@master] Make $wgUsersNotifiedOnAllChanges require confirmed emails

https://gerrit.wikimedia.org/r/1131408

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Mar 27 2025, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 27 2025, 2:30 PM
pmiazga closed this task as Resolved.Mar 27 2025, 2:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits