Page MenuHomePhabricator

Update protected variable view log copy to reflect what protected variable(s) are being viewed
Closed, ResolvedPublic

Description

From T387329: Investigate: Confirm our logging expectations for AbuseFilter/CheckUser Temporary Accounts logs when using protected variables:

If not too difficult, we should update the log to mention what protected variable is being viewed so that it's explicit that the logs being routed to the temp account logs are due to the user_unnamed_ip variable

As there is currently only one protected variable (user_unnamed_ip), the two are analogous but when more protected variables have been added, it should be clear which one was viewed so that it's explicit that the CU logs only cover user_unnamed_ip views and the rest remain in AF.

Acceptance Critertia:

  • logentry-abusefilter-protected-vars-view-protected-var-value (or an alternative if necessary) shows the protected variable being viewed

Event Timeline

mszwarc changed the task status from Open to In Progress.Jul 16 2025, 4:31 PM
mszwarc claimed this task.

Change #1170273 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/AbuseFilter@master] Display names of protected variables accessed

https://gerrit.wikimedia.org/r/1170273

Change #1170579 had a related patch set uploaded (by Msz2001; author: Msz2001):

[mediawiki/extensions/CheckUser@master] Display names of protected variables accessed

https://gerrit.wikimedia.org/r/1170579

Change #1170579 abandoned by Mszwarc:

[mediawiki/extensions/CheckUser@master] Display names of protected variables accessed

Reason:

Wrong account, will resubmit

https://gerrit.wikimedia.org/r/1170579

Change #1170580 had a related patch set uploaded (by Mszwarc; author: Msz2001):

[mediawiki/extensions/CheckUser@master] Display names of protected variables accessed

https://gerrit.wikimedia.org/r/1170580

Change #1172256 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CheckUser@master] Temporarily comment-out interface implementation

https://gerrit.wikimedia.org/r/1172256

Change #1172256 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Temporarily comment-out interface implementation

https://gerrit.wikimedia.org/r/1172256

Change #1170273 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Display names of protected variables accessed

https://gerrit.wikimedia.org/r/1170273

Change #1170580 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Display names of protected variables accessed

https://gerrit.wikimedia.org/r/1170580

Tchanders subscribed.

I think this is a good candidate for QA, since it has a few moving parts, but it's also outside of our QA focus area for the upcoming weeks. I'll move it into QA for now, and when we have a way to mark it as not the main focus, let's do that.

OKryva-WMF triaged this task as Medium priority.Aug 1 2025, 1:47 PM
Dreamy_Jazz subscribed.

I think this has sat in QA for too long, so moving to done