Deprecate `AbortEmailNotification` hook
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	pmiazga
	Mar 21 2025, 12:35 PM

Description

As ENotif uses the MediaWiki Notification system, we should deprecate AbortEmailNotification hook and let extensions dismiss the watchlist notification via Middleware system we introduced in https://phabricator.wikimedia.org/T387996

Notes:
Multiple extensions use this hook: https://codesearch.wmcloud.org/search/?q=(\b|on)AbortEmailNotification
The use cases are:

Flow - to stop notifications from flow board.
SubpageWatchlist - looks like it's overriding ENotif and sends custom email
Translate blocks sending notifications for RecentChanges with rc_log_type set to translationreview
WikiBase - blocks sending notifications for RecentChanges with rc_source set to Wikibase

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Deprecate the AbortEmailNotification Hook	mediawiki/core	master	+4 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	matmarex	T389624 Post "enotif" migration followup: Notifications hook deprecations and migration Path
Resolved	matmarex	T389618 Deprecate `AbortEmailNotification` hook
Resolved	pmiazga	T392592 Translate should use NotificationMiddleware instead of AbortEmailNotification hook
Resolved	pmiazga	T395352 Wikibase should use NotificationMiddleware instead of AbortEmailNotification hook
Resolved	pmiazga	T396119 Flow should use NotificationMiddleware instead of AbortEmailNotification hook

Event Timeline

pmiazga created this task.Mar 21 2025, 12:35 PM

Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptMar 21 2025, 12:35 PM

Blocked on T387996 - In order to deprecate hook we need to provide a replacement.

Samwalton9-WMF moved this task from Inbox to Triaged on the Moderator-Tools-Team board.Mar 21 2025, 3:35 PM

pmiazga moved this task from Inbox, needs triage to Needs refinement on the MediaWiki-Platform-Team board.Mar 24 2025, 3:43 PM

pmiazga edited parent tasks, added: T389624: Post "enotif" migration followup: Notifications hook deprecations and migration Path; removed: T383996: Migrate Enotif to the new notifications interface.Mar 27 2025, 2:43 PM

pmiazga mentioned this in T392597: Decision Required: Handling Admin Watchlist notifications.Apr 24 2025, 2:37 PM

pmiazga added a subtask: T392592: Translate should use NotificationMiddleware instead of AbortEmailNotification hook.May 27 2025, 4:44 PM

matmarex subscribed.May 28 2025, 3:34 PM

• JoelyRooke-WMDE added a project: Wikidata Integration in Wikimedia projects (Kanban Board).Jun 3 2025, 9:40 AM

• JoelyRooke-WMDE moved this task from In Progress to Reviewed (ext.tickets) on the Wikidata Integration in Wikimedia projects (Kanban Board) board.

Maintenance_bot added a project: Wikidata.Jun 3 2025, 10:30 AM

Change #1138814 had a related patch set uploaded (by Pmiazga; author: Pmiazga):

[mediawiki/extensions/Translate@master] Use middleware instead of AbortEmailNotification hook

https://gerrit.wikimedia.org/r/1138814

gerritbot added a project: Patch-For-Review.Jun 5 2025, 11:37 AM

Change #1151272 had a related patch set uploaded (by Pmiazga; author: Pmiazga):

[mediawiki/extensions/Wikibase@master] The AbortEmailNotificationHook gets deprecated, use Middleware instead

https://gerrit.wikimedia.org/r/1151272

Change #1154016 had a related patch set uploaded (by Pmiazga; author: Pmiazga):

[mediawiki/extensions/Flow@master] Use middleware instead of AbortEmailNotification hook

https://gerrit.wikimedia.org/r/1154016

(I'm untagging some projects since there are now subtasks for every team, so this task doesn't have to clutter everyone's workboard, and the subtasks can be removed from Platform team's workboard as well.)

(There's no subtask for SubpageWatchlist, because it doesn't seem to have a Phab project, and may be abandoned. I complained at https://www.mediawiki.org/wiki/Extension_talk:SubpageWatchlist.)

matmarex assigned this task to pmiazga.Jun 7 2025, 12:38 AM

matmarex moved this task from Needs refinement to In progress (DO NOT USE) on the MediaWiki-Platform-Team board.

matmarex closed subtask T396119: Flow should use NotificationMiddleware instead of AbortEmailNotification hook as Resolved.Jun 7 2025, 2:11 AM

abi_ closed subtask T392592: Translate should use NotificationMiddleware instead of AbortEmailNotification hook as Resolved.Jun 16 2025, 3:45 AM

Mooeypoo mentioned this in T389624: Post "enotif" migration followup: Notifications hook deprecations and migration Path.Jun 26 2025, 2:37 PM

pmiazga closed subtask T395352: Wikibase should use NotificationMiddleware instead of AbortEmailNotification hook as Resolved.Jun 26 2025, 4:15 PM

The only remaining extension is Extension:SubpageWatchlist, everything else is migrated. Bawolff is not actively maintaining that (per @matmarex thread - https://www.mediawiki.org/wiki/Extension_talk:SubpageWatchlist ).

I think we can hard-deprecate this hook now.

Change #1170625 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Deprecate the AbortEmailNotification Hook

https://gerrit.wikimedia.org/r/1170625

gerritbot added a project: Patch-For-Review.Jul 19 2025, 1:56 AM

matmarex claimed this task.Jul 19 2025, 2:01 AM

matmarex moved this task from Backlog to In progress on the MediaWiki-Core-Notifications board.

This work is blocked on the release cycle in Translate extension. We have to wait for MLEB release (should happen within a couple of months: source https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/1169240/comments/9056019d_985d3b67?tab=comments), and only after that we can merge the remaining changes.

matmarex reopened subtask T392592: Translate should use NotificationMiddleware instead of AbortEmailNotification hook as Open.Jul 21 2025, 7:39 PM

matmarex moved this task from In progress (DO NOT USE) to Waiting on the MediaWiki-Platform-Team board.Jul 21 2025, 9:00 PM

matmarex closed subtask T392592: Translate should use NotificationMiddleware instead of AbortEmailNotification hook as Resolved.Aug 13 2025, 2:03 PM

matmarex moved this task from Blocked / External to In progress on the MediaWiki-Core-Notifications board.

Change #1170625 merged by jenkins-bot:

[mediawiki/core@master] Deprecate the AbortEmailNotification Hook

https://gerrit.wikimedia.org/r/1170625

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.16; 2025-08-26).Aug 21 2025, 11:00 AM

matmarex closed this task as Resolved.Aug 21 2025, 1:14 PM

matmarex removed a project: Patch-For-Review.