Page MenuHomePhabricator

Parsoid fails to parse [[{}]] single curly brackets inside double rectangular brackets
Open, LowPublicBUG REPORT

Description

Steps to replicate the issue:

  • visit https://eo.wiktionary.org/wiki/%C5%9Cablono:BUG-T389623?useparsoid=1
  • expected outcome: two thick horizontal lines generated by the template {{hr3}}
  • observed outcome: template NOT called at all, instead raw wikitext is visible
  • click "Redakti" to edit the page, do NOT change anything
  • click "Antaŭrigardo" to preview
  • observed outcome: two thick horizontal lines generated by the template {{hr3}} as expected, but still surprizing in the context

Other information:
The problem vanishes if one switches to the "legacy parser". https://eo.wiktionary.org/wiki/%C5%9Cablono:BUG-T389623?useparsoid=0

Conclusion:
This is a new bug of parsoid.

Event Timeline

Change #1130780 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] Fix incorrect broken-wikilink handling

https://gerrit.wikimedia.org/r/1130780

Change #1134104 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Fix incorrect broken-wikilink handling (alternative)

https://gerrit.wikimedia.org/r/1134104

Change #1134104 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Fix incorrect broken-wikilink handling (alternative)

https://gerrit.wikimedia.org/r/1134104

Change #1134766 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.21.0-a25

https://gerrit.wikimedia.org/r/1134766

Change #1130780 abandoned by Arlolra:

[mediawiki/services/parsoid@master] Fix incorrect broken-wikilink handling

Reason:

In favour of I511a3aa946d1ddca3f38701e8fd32353e8622bb7

https://gerrit.wikimedia.org/r/1130780

Change #1134766 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.21.0-a25

https://gerrit.wikimedia.org/r/1134766

Sorry but I have to reopen this one. The fix is partial only. It indeed fixes the original problem

[[{}]]

but after adding a LF

[[{}
]]

it behaves exactly the same way as it did 3 weeks ago. I updated the testpage. Currently it's broken again.

ssastry triaged this task as Medium priority.
ssastry subscribed.
MSantos lowered the priority of this task from Medium to Low.
MSantos moved this task from Wiktionary to Non-blockers (any wiki) on the Parsoid-Read-Views board.
MSantos added a subscriber: cscott.

I disagree with lowering the priority, and I disagree with move to "non-blockers" given that this is a blocker. Please move into Blockers (any wiki) given that this bug indeed does break a useful module https://www.wikidata.org/wiki/Q120442526.

@Taylor I apologise for the late response.

This triage action came during one of our team meetings with a framework we have been using to deal with the many bugs/issues related to Parsoid.

This doesn't mean we won't work on this bug, but we are not prioritising it at the current quarter while we are focusing on more pressing issues.

I agree with you that "Non-blocker (any wiki)" might be confusing for this bug since it's clearly a bug in wiktionary. I'll get this back to triage to discuss with the team and let you know.

Thanks for raising your concerns, I really appreciate it.