Page MenuHomePhabricator
Create Task
Maniphest T389633

[Darkmode] Update colours on statement editing state on Items
Closed, ResolvedPublic
Actions

Assigned To
ArthurTaylor
Authored By
Arian_Bozorg
Mar 21 2025, 3:41 PM
Tags
Referenced Files
F59815867: Bildschirmfoto 2025-05-09 um 13.39.48.png
May 9 2025, 11:40 AM
F59769561: image.png
May 8 2025, 9:02 AM
F59769449: image.png
May 8 2025, 9:00 AM
F59585508: Screenshot From 2025-04-30 15-21-47.png
Apr 30 2025, 1:23 PM
F59585507: Screenshot From 2025-04-30 15-21-44.png
Apr 30 2025, 1:23 PM
F59585492: Screenshot From 2025-04-30 15-21-39.png
Apr 30 2025, 1:23 PM
F59585493: Screenshot From 2025-04-30 15-21-34.png
Apr 30 2025, 1:23 PM
F59584300: image.png
Apr 30 2025, 12:20 PM
View All 32 Files
Subscribers
Aklapper
Arian_Bozorg
ArthurTaylor
karapayneWMDE
Kuldeepburjbhalaike
LarissaHonsek
Lucas_Werkmeister_WMDE

Description

When editing statements on Items in Darkmode the colours are appearing incorrectly:

  • Visit Item
  • Add a reference to one of the Statements
  • Add a new value to one of the Statements

Screenshot

image.png (493×1 px, 33 KB)

Figma file and where the corresponding codex tokens can be found.
To find the correct token, find the hex color in the figma file on light mode version. Then search for it in codex document

Acceptance Criteria

  • The colours for the elements in the statement editing state on Items have been converted to their equivalent Codex colour tokens in light-mode

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Bump wikibase-data-values-value-view to HEADmediawiki/extensions/WikibaseREL1_44+1 -1
Bump wikibase-data-values-value-view to HEADmediawiki/extensions/WikibaseREL1_44+1 -1
Update entity selector error colors for dark modemediawiki/extensions/Wikibasemaster+3 -3
Convert value-view CSS files with tokens to LESS filesmediawiki/extensions/Wikibasemaster+4 -4
Convert CSS files with tokens to LESS filesdata-values/value-viewmaster+16 -10
Add support for list-wide CSS classes to our CustomItem forkdata-values/value-viewmaster+34 -3
Add entity selector error border colormediawiki/extensions/Wikibasemaster+12 -3
Add entity selector error border using :has()mediawiki/extensions/Wikibasemaster+4 -0
Bump wikibase-data-values-value-view to HEADmediawiki/extensions/Wikibasemaster+1 -1
Bump wikibase-data-values-value-view to HEADmediawiki/extensions/Wikibasewmf/1.44.0-wmf.28+1 -1
Change UI suggester hover foreground to color-basedata-values/value-viewmaster+1 -2
Bump wikibase-data-values-value-view to HEADmediawiki/extensions/Wikibasewmf/1.44.0-wmf.28+1 -1
Bump wikibase-data-values-value-view to HEADmediawiki/extensions/Wikibasemaster+1 -1
Fix hard-coded --background-color-base fallback valuedata-values/value-viewmaster+1 -1
Update entity selector colors for dark modemediawiki/extensions/Wikibasemaster+3 -3
Use Codex tokens for UI suggester colorsdata-values/value-viewmaster+7 -7
WIP: Reorganize reference background colorsmediawiki/extensions/Wikibasemaster+8 -5
Update reference tab bar header for dark modemediawiki/extensions/Wikibasemaster+4 -1
Override some jQuery UI colors for dark modemediawiki/extensions/Wikibasemaster+15 -0
Bump wikibase-data-values-value-view to HEADmediawiki/extensions/Wikibasemaster+1 -1
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Apr 10 2025, 7:13 AM

Change #1135447 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update reference tab bar header for dark mode

https://gerrit.wikimedia.org/r/1135447

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.25; 2025-04-15); removed MW-1.44-notes (1.44.0-wmf.24; 2025-04-08).Apr 10 2025, 8:00 AM
karapayneWMDE removed a project: [Archived]Wikidata Dev Team.Apr 10 2025, 3:10 PM
LarissaHonsek added a comment.Apr 17 2025, 10:19 AM
In T389633#10726297, @Lucas_Werkmeister_WMDE wrote:

There are a couple more colors that I think are in scope for this task, and that I can’t find in Figma at the moment:

The suggester list:

image.png (146×579 px, 17 KB)

Current state (jquery.ui.suggester.css): background white, border #C9C9C9, color black; on hover, background #4C59A6, color white; the “more” link (when there are enough results), background #f8f9fa.

And the error colors (e.g. after typing something without selecting a suggestion):

image.png (67×563 px, 6 KB)

Current state (jquery.wikibase.entityselector.less): background #fee7e6, border #b32424.

There are other minor parts with hard-coded colors (like the popups for selecting the unit of a quantity or the language of a monolingual text), but IMHO they’re not as important (all the ones I found were still usable, and as they’re a small part of the screen, they don’t burn your eyes out with their brightness either), so I think it would be better to leave them out of this task, and clean them up later after we’ve enabled dark mode on Wikidata.

Pulldown Solution:
Find it on this board:
https://www.figma.com/design/JU89C2lnmWLoadkYwJroNT/Wikidata-Ongoing-Tickets?node-id=474-15676&t=VGFG9Udgv8c0B21h-1

we go here for state: "active" - just one status (like before)

Error:
Find it on this board:
https://www.figma.com/design/JU89C2lnmWLoadkYwJroNT/Wikidata-Ongoing-Tickets?node-id=511-11106&t=VGFG9Udgv8c0B21h-1

gerritbot added a comment.Apr 17 2025, 2:23 PM

Change #1137307 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[data-values/value-view@master] Use Codex tokens for UI suggester colors

https://gerrit.wikimedia.org/r/1137307

gerritbot added a comment.Apr 17 2025, 2:23 PM

Change #1137308 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] WIP: Update entity selector error color for dark mode

https://gerrit.wikimedia.org/r/1137308

Lucas_Werkmeister_WMDE added a comment.Apr 17 2025, 2:42 PM
In T389633#10751387, @LarissaHonsek wrote:

Pulldown Solution:
Find it on this board:
https://www.figma.com/design/JU89C2lnmWLoadkYwJroNT/Wikidata-Ongoing-Tickets?node-id=474-15676&t=VGFG9Udgv8c0B21h-1

we go here for state: "active" - just one status (like before)

Mostly done with the above change – looks like this:
Screenshot From 2025-04-17 16-24-47.png (144×372 px, 12 KB) Screenshot From 2025-04-17 16-24-54.png (144×372 px, 12 KB)

But I still need the background color for the “more” link. Originally it looks like this:
Screenshot From 2025-04-17 16-26-50.png (95×711 px, 9 KB) Screenshot From 2025-04-17 16-26-53.png (95×711 px, 9 KB)

However, with the above changes, it looks like this, which is horrible (if you can read the text in hover state, congratulations on your excellent eyesight and well-calibrated monitor):
Screenshot From 2025-04-17 16-28-41.png (95×711 px, 9 KB) Screenshot From 2025-04-17 16-28-44.png (95×711 px, 9 KB)

What should its background color (normally and perhaps on hover) be? (On hover the old version just has the same background as other list items, so we don’t necessarily need a special token there, but on non-hover it has a different color to set it apart from the “regular” search results.)

In T389633#10751387, @LarissaHonsek wrote:

Error:
Find it on this board:
https://www.figma.com/design/JU89C2lnmWLoadkYwJroNT/Wikidata-Ongoing-Tickets?node-id=511-11106&t=VGFG9Udgv8c0B21h-1

Partly done, looks like this:
Screenshot From 2025-04-17 16-39-37.png (51×374 px, 2 KB) Screenshot From 2025-04-17 16-39-39.png (51×374 px, 2 KB)

But I noticed there’s another item I didn’t mention before (sorry) – the “no match” list item after you do a search with no results:

Screenshot From 2025-04-17 16-40-39.png (83×374 px, 4 KB)

What color(s) should this have? (It currently doesn’t have any special hover styles, though we could change that if we want to.)

Kuldeepburjbhalaike subscribed.Apr 18 2025, 5:26 AM
karapayneWMDE changed the task status from Open to Stalled.Apr 25 2025, 8:25 AM
LarissaHonsek added a subscriber: LucasWerkmeister.Apr 30 2025, 12:20 PM

Dear @LucasWerkmeister & @Arian_Bozorg:

Everything looks good to me! Nice.

Lets use for the "more" link the same active state then for the others:
https://www.figma.com/design/JU89C2lnmWLoadkYwJroNT/Wikidata-Ongoing-Tickets?node-id=474-6954&t=SyiNlUlqXGduXzPi-1

image.png (474×1 px, 65 KB)

And for "no match found" I could not really find a component in codex except of this (can we do this or do you have any concerns?):
https://www.figma.com/design/JU89C2lnmWLoadkYwJroNT/Wikidata-Ongoing-Tickets?node-id=474-6954&t=SyiNlUlqXGduXzPi-1

image.png (470×906 px, 27 KB)

Lucas_Werkmeister_WMDE removed a subscriber: LucasWerkmeister.Apr 30 2025, 12:49 PM
Lucas_Werkmeister_WMDE added a comment.Apr 30 2025, 12:54 PM
In T389633#10780026, @LarissaHonsek wrote:

And for "no match found" I could not really find a component in codex except of this (can we do this or do you have any concerns?):
https://www.figma.com/design/JU89C2lnmWLoadkYwJroNT/Wikidata-Ongoing-Tickets?node-id=474-6954&t=SyiNlUlqXGduXzPi-1

image.png (470×906 px, 27 KB)

Definitely not, that’s way beyond what we can do in the scope of this task IMHO. It’s currently implemented as a special dropdown entry, all we can do is change its colors.

gerritbot added a comment.Apr 30 2025, 1:19 PM

Change #1140179 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Update entity selector colors for dark mode

https://gerrit.wikimedia.org/r/1140179

Lucas_Werkmeister_WMDE added a comment.Apr 30 2025, 1:23 PM
In T389633#10780026, @LarissaHonsek wrote:

Lets use for the "more" link the same active state then for the others:
https://www.figma.com/design/JU89C2lnmWLoadkYwJroNT/Wikidata-Ongoing-Tickets?node-id=474-6954&t=SyiNlUlqXGduXzPi-1

image.png (474×1 px, 65 KB)

Alright, done in the above change. Looks like this normally:
Screenshot From 2025-04-30 15-21-34.png (138×717 px, 20 KB) Screenshot From 2025-04-30 15-21-39.png (138×717 px, 21 KB)
And on hover:
Screenshot From 2025-04-30 15-21-44.png (138×717 px, 21 KB) Screenshot From 2025-04-30 15-21-47.png (138×717 px, 21 KB)
(These screenshots just made me notice that the “normal” list entry color on hover is apparently the same as the “more” color when not hovered… but that’s probably not a problem in practice.)

gerritbot added a comment.Apr 30 2025, 1:24 PM

Change #1135059 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@master] WIP: Reorganize reference background colors

Reason:

gonna abandon this now after all, seems less confusing this way

https://gerrit.wikimedia.org/r/1135059

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Apr 30 2025, 1:25 PM
Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.

I’ll move this task into peer review – the error color change isn’t ready yet, but the entity selector changes in value-view and Wikibase should be ready for review.

karapayneWMDE changed the task status from Stalled to In Progress.May 5 2025, 8:24 AM
ArthurTaylor claimed this task.May 5 2025, 11:10 AM
ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
gerritbot added a comment.May 5 2025, 11:19 AM

Change #1137307 merged by jenkins-bot:

[data-values/value-view@master] Use Codex tokens for UI suggester colors

https://gerrit.wikimedia.org/r/1137307

ArthurTaylor removed ArthurTaylor as the assignee of this task.May 5 2025, 11:36 AM
ArthurTaylor moved this task from In Peer Review to Ready for Development on the Wikidata-Omega (The Board) board.
gerritbot added a comment.May 5 2025, 12:47 PM

Change #1140179 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update entity selector colors for dark mode

https://gerrit.wikimedia.org/r/1140179

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.28; 2025-05-06); removed MW-1.44-notes (1.44.0-wmf.25; 2025-04-15).May 5 2025, 1:00 PM
karapayneWMDE assigned this task to LarissaHonsek.May 7 2025, 8:44 AM
karapayneWMDE subscribed.

All changes are completed. waiting for feedback on a specific color

Lucas_Werkmeister_WMDE added a subtask: T393641: [Bug] color changes in statement UI for old Vector skin (and potentially others?).May 7 2025, 8:59 PM
LarissaHonsek added a subscriber: LucasWerkmeister.EditedMay 8 2025, 9:00 AM
In T389633#10780281, @Lucas_Werkmeister_WMDE wrote:
In T389633#10780026, @LarissaHonsek wrote:

Lets use for the "more" link the same active state then for the others:
https://www.figma.com/design/JU89C2lnmWLoadkYwJroNT/Wikidata-Ongoing-Tickets?node-id=474-6954&t=SyiNlUlqXGduXzPi-1

image.png (474×1 px, 65 KB)

Alright, done in the above change. Looks like this normally:
Screenshot From 2025-04-30 15-21-34.png (138×717 px, 20 KB) Screenshot From 2025-04-30 15-21-39.png (138×717 px, 21 KB)
And on hover:
Screenshot From 2025-04-30 15-21-44.png (138×717 px, 21 KB) Screenshot From 2025-04-30 15-21-47.png (138×717 px, 21 KB)
(These screenshots just made me notice that the “normal” list entry color on hover is apparently the same as the “more” color when not hovered… but that’s probably not a problem in practice.)

Hey @LucasWerkmeister

I documented the default state and active state in Figma, this is what codex defined.
But I would keep the thin line as it is.
What do you think?

Bildschirmfoto 2025-05-09 um 13.39.48.png (1×2 px, 164 KB)

LucasWerkmeister unsubscribed.May 8 2025, 9:34 AM
gerritbot added a comment.May 9 2025, 10:48 AM

Change #1143792 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[data-values/value-view@master] Fix hard-coded --background-color-base fallback value

https://gerrit.wikimedia.org/r/1143792

gerritbot added a comment.May 9 2025, 10:51 AM

Change #1143793 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Bump wikibase-data-values-value-view to HEAD

https://gerrit.wikimedia.org/r/1143793

gerritbot added a comment.May 9 2025, 11:17 AM

Change #1143795 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Convert value-view CSS files with tokens to LESS files

https://gerrit.wikimedia.org/r/1143795

gerritbot added a comment.May 9 2025, 11:17 AM

Change #1143796 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[data-values/value-view@master] Convert CSS files with tokens to LESS files

https://gerrit.wikimedia.org/r/1143796

LarissaHonsek attached a referenced file: F59815867: Bildschirmfoto 2025-05-09 um 13.39.48.png. (Show Details)May 9 2025, 11:44 AM
LarissaHonsek attached a referenced file: F59769561: image.png. (Show Details)
gerritbot added a comment.May 9 2025, 12:02 PM

Change #1143792 merged by jenkins-bot:

[data-values/value-view@master] Fix hard-coded --background-color-base fallback value

https://gerrit.wikimedia.org/r/1143792

gerritbot added a comment.May 9 2025, 1:00 PM

Change #1143793 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Bump wikibase-data-values-value-view to HEAD

https://gerrit.wikimedia.org/r/1143793

gerritbot added a comment.May 9 2025, 1:46 PM

Change #1143832 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[data-values/value-view@master] Change UI suggester hover foreground to color-base

https://gerrit.wikimedia.org/r/1143832

gerritbot added a comment.May 9 2025, 1:47 PM

Change #1143834 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Bump wikibase-data-values-value-view to HEAD

https://gerrit.wikimedia.org/r/1143834

gerritbot added a comment.May 9 2025, 1:48 PM

Change #1143835 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@wmf/1.44.0-wmf.28] Bump wikibase-data-values-value-view to HEAD

https://gerrit.wikimedia.org/r/1143835

gerritbot added a comment.May 9 2025, 2:07 PM

Change #1143835 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.44.0-wmf.28] Bump wikibase-data-values-value-view to HEAD

https://gerrit.wikimedia.org/r/1143835

Stashbot added a comment.May 9 2025, 2:07 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-09T14:07:29Z] <lucaswerkmeister-wmde@deploy1003> Started scap sync-world: Backport for [[gerrit:1143835|Bump wikibase-data-values-value-view to HEAD (T389633 T393641)]]

Stashbot mentioned this in T393641: [Bug] color changes in statement UI for old Vector skin (and potentially others?).May 9 2025, 2:07 PM
Stashbot added a comment.May 9 2025, 2:14 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-09T14:14:10Z] <lucaswerkmeister-wmde@deploy1003> lucaswerkmeister-wmde: Backport for [[gerrit:1143835|Bump wikibase-data-values-value-view to HEAD (T389633 T393641)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.May 9 2025, 2:21 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-09T14:21:41Z] <lucaswerkmeister-wmde@deploy1003> Finished scap sync-world: Backport for [[gerrit:1143835|Bump wikibase-data-values-value-view to HEAD (T389633 T393641)]] (duration: 14m 12s)

gerritbot added a comment.May 9 2025, 2:33 PM

Change #1143841 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_44] Bump wikibase-data-values-value-view to HEAD

https://gerrit.wikimedia.org/r/1143841

gerritbot added a comment.May 9 2025, 3:01 PM

Change #1143832 merged by jenkins-bot:

[data-values/value-view@master] Change UI suggester hover foreground to color-base

https://gerrit.wikimedia.org/r/1143832

gerritbot added a comment.May 9 2025, 3:03 PM

Change #1143851 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@wmf/1.44.0-wmf.28] Bump wikibase-data-values-value-view to HEAD

https://gerrit.wikimedia.org/r/1143851

gerritbot added a comment.May 9 2025, 3:20 PM

Change #1143834 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Bump wikibase-data-values-value-view to HEAD

https://gerrit.wikimedia.org/r/1143834

gerritbot added a comment.May 9 2025, 3:21 PM

Change #1143859 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@REL1_44] Bump wikibase-data-values-value-view to HEAD

https://gerrit.wikimedia.org/r/1143859

gerritbot added a comment.May 9 2025, 3:25 PM

Change #1143851 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.44.0-wmf.28] Bump wikibase-data-values-value-view to HEAD

https://gerrit.wikimedia.org/r/1143851

Stashbot added a comment.May 9 2025, 3:25 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-09T15:25:42Z] <lucaswerkmeister-wmde@deploy1003> Started scap sync-world: Backport for [[gerrit:1143851|Bump wikibase-data-values-value-view to HEAD (T389633 T393641)]]

Stashbot added a comment.May 9 2025, 3:32 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-09T15:32:20Z] <lucaswerkmeister-wmde@deploy1003> lucaswerkmeister-wmde: Backport for [[gerrit:1143851|Bump wikibase-data-values-value-view to HEAD (T389633 T393641)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.May 9 2025, 3:41 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-09T15:41:04Z] <lucaswerkmeister-wmde@deploy1003> Finished scap sync-world: Backport for [[gerrit:1143851|Bump wikibase-data-values-value-view to HEAD (T389633 T393641)]] (duration: 15m 22s)

LarissaHonsek added a subscriber: LucasWerkmeister.May 12 2025, 8:07 AM

Dear @LucasWerkmeister,
please find here informations for the error dropdown fix:
https://www.figma.com/design/JU89C2lnmWLoadkYwJroNT/Wikidata-Ongoing-Tickets?node-id=474-6954&t=D78883dxdG26v6RV-1

Lucas_Werkmeister_WMDE removed LarissaHonsek as the assignee of this task.May 12 2025, 8:17 AM
Lucas_Werkmeister_WMDE removed a subscriber: LucasWerkmeister.
Lucas_Werkmeister_WMDE claimed this task.May 12 2025, 9:26 AM
Lucas_Werkmeister_WMDE moved this task from Ready for Development to In Development on the Wikidata-Omega (The Board) board.
gerritbot added a comment.May 12 2025, 11:12 AM

Change #1144504 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Add entity selector error border using :has()

https://gerrit.wikimedia.org/r/1144504

gerritbot added a comment.May 12 2025, 11:12 AM

Change #1144505 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[data-values/value-view@master] Add support for list-wide CSS classes to our CustomItem fork

https://gerrit.wikimedia.org/r/1144505

gerritbot added a comment.May 12 2025, 11:13 AM

Change #1144506 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Add entity selector error border color

https://gerrit.wikimedia.org/r/1144506

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.May 12 2025, 11:16 AM
Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.

The error change is now ready for review, in two parts:

Arian_Bozorg closed subtask T393641: [Bug] color changes in statement UI for old Vector skin (and potentially others?) as Resolved.May 12 2025, 12:54 PM
ArthurTaylor claimed this task.May 12 2025, 12:59 PM
ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
ArthurTaylor moved this task from In Peer Review to Product Verification on the Wikidata-Omega (The Board) board.May 12 2025, 1:30 PM
Lucas_Werkmeister_WMDE added a comment.May 12 2025, 1:30 PM
In T389633#10810956, @Lucas_Werkmeister_WMDE wrote:

Secret third option: UX says we can skip this, it’s not worth the added complexity. (The current UI doesn’t have a red border in this case either.)

gerritbot added a comment.May 12 2025, 1:30 PM

Change #1144504 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@master] Add entity selector error border using :has()

Reason:

not needed per T389633#10811616

https://gerrit.wikimedia.org/r/1144504

gerritbot added a comment.May 12 2025, 1:30 PM

Change #1144506 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@master] Add entity selector error border color

Reason:

not needed per T389633#10811616

https://gerrit.wikimedia.org/r/1144506

gerritbot added a comment.May 12 2025, 1:30 PM

Change #1144505 abandoned by Lucas Werkmeister (WMDE):

[data-values/value-view@master] Add support for list-wide CSS classes to our CustomItem fork

Reason:

not needed per T389633#10811616

https://gerrit.wikimedia.org/r/1144505

gerritbot added a comment.May 12 2025, 1:53 PM

Change #1137308 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update entity selector error colors for dark mode

https://gerrit.wikimedia.org/r/1137308

gerritbot added a comment.May 12 2025, 1:53 PM

Change #1143796 abandoned by Lucas Werkmeister (WMDE):

[data-values/value-view@master] Convert CSS files with tokens to LESS files

Reason:

doesn’t seem worth the extra effort at the moment

https://gerrit.wikimedia.org/r/1143796

gerritbot added a comment.May 12 2025, 1:53 PM

Change #1143795 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@master] Convert value-view CSS files with tokens to LESS files

Reason:

doesn’t seem worth the extra effort at the moment

https://gerrit.wikimedia.org/r/1143795

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.1; 2025-05-13).May 12 2025, 2:00 PM
Mormegil reopened subtask T393641: [Bug] color changes in statement UI for old Vector skin (and potentially others?) as Open.May 13 2025, 3:18 PM
Mormegil closed subtask T393641: [Bug] color changes in statement UI for old Vector skin (and potentially others?) as Resolved.May 13 2025, 4:11 PM
gerritbot added a comment.May 14 2025, 6:15 PM

Change #1143841 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@REL1_44] Bump wikibase-data-values-value-view to HEAD

https://gerrit.wikimedia.org/r/1143841

gerritbot added a comment.May 14 2025, 6:16 PM

Change #1143859 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@REL1_44] Bump wikibase-data-values-value-view to HEAD

https://gerrit.wikimedia.org/r/1143859

Arian_Bozorg closed this task as Resolved.May 15 2025, 10:38 AM
Arian_Bozorg moved this task from Product Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.

Looks good \o/
Thank you!

Lucas_Werkmeister_WMDE edited projects, added Wikidata-Omega (Completed Tasks); removed Wikidata-Omega (The Board).Jun 2 2025, 10:51 AM
karapayneWMDE moved this task from Newly completed tasks to 2025 Q2 on the Wikidata-Omega (Completed Tasks) board.Jun 18 2025, 6:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits