Allow to change subtype of Security subtype tasks (via mutations config setting)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	sbassett
	Mar 23 2025, 3:25 PM

Description

Per discussions arising from T310023#10657948, there currently does not seem to be an intuitive way via Phabricator's UI to change a task subtype once it has been set as a Security subtype. We should investigate why this is and see if we can alter the form for Security subtypes to support this operation.

Related Objects

Mentioned In: T310023: Usage of ipinfo does not cause an event in CheckUser result tables
Mentioned Here: T310023: Usage of ipinfo does not cause an event in CheckUser result tables

Event Timeline

sbassett created this task.Mar 23 2025, 3:25 PM

sbassett mentioned this in T310023: Usage of ipinfo does not cause an event in CheckUser result tables.

In T310023#10664153, @Aklapper wrote:

@sbassett: Pretty often there is "Change Subtype..." in the "Add Action..." dropdown but no clue why not for Security subtype. I can imagine more ~~questionabl~~awesome custom WMF downstream changes I'm not aware of. Could you file a separate ticket please?

This is because https://phabricator.wikimedia.org/config/edit/maniphest.subtypes/ has "mutations": [] explicitely set for the Security subtype.

In T389738#10665939, @taavi wrote:

This is because https://phabricator.wikimedia.org/config/edit/maniphest.subtypes/ has "mutations": [] explicitely set for the Security subtype.

Indeed that is exactly right, it's a simple config change.

Aklapper renamed this task from Add UI to change form subtypes for Security subtype tasks to Allow to change subtype of Security subtype tasks (via mutations config setting).Mar 23 2025, 6:43 PM

Aklapper added a project: Release-Engineering-Team (Priority Backlog 📥).Mar 23 2025, 6:57 PM

So if we change the mutations to ["bug", "issue", "defect"], per the phabricator documentation, that should fix this issue.

sbassett changed the task status from Open to In Progress.Apr 2 2025, 4:55 PM

sbassett claimed this task.

sbassett triaged this task as Low priority.

sbassett moved this task from Incoming to In Progress on the Security-Team board.

Ok, I've updated the Phabricator core config for the security subtype to:

"mutations": [
    "default",
    "error",
    "feature",
    "bug",
    "security"
],

Seems to work for the security task type now (tested on the original task).

sbassett moved this task from To Triage to Misc on the Phabricator board.Apr 8 2025, 7:24 PM

sbassett moved this task from In Progress to Our Part Is Done on the Security-Team board.

sbassett added a project: SecTeam-Processed.

Allow to change subtype of Security subtype tasks (via mutations config setting)Closed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Allow to change subtype of Security subtype tasks (via mutations config setting)
Closed, ResolvedPublic
Actions