GoToComment does not work for certain characters in comment IDs
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Pppery
	Mar 23 2025, 8:21 PM

Description

Steps to replicate the issue (include links if applicable):

Go to https://www.mediawiki.org/wiki/Special:FindComment
Enter the comment ID c-ThatRobloxianuser2K6-20250128053500-Broken_file_uploads_on_Miraheze????_help_me_pls!_>;(. This is a valid comment ID, and refers to the opening comment of the second section at https://www.mediawiki.org/wiki/Project:Support_desk/Flow/2025/01

What happens?:

The page (correctly) finds the comment, but then displays that fact with malformed markup:

If it only appears in the current revision of one page, you can [[Special:GoToComment/c-ThatRobloxianuser2K6-20250128053500-Broken_file_uploads_on_Miraheze????_help_me_pls!_>;(|go directly to the comment using this link]]. Otherwise it will redirect to these search results.

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	SpecialFindComment: Hide link to GoToComment if it would be invalid	mediawiki/extensions/DiscussionTools	master	+11 -2

Customize query in gerrit

Event Timeline

Pppery created this task.Mar 23 2025, 8:21 PM

Restricted Application added a project: affects-Miraheze. · View Herald TranscriptMar 23 2025, 8:21 PM

Restricted Application added subscribers: Reception123, Aklapper. · View Herald Transcript

(Sorry Miraheze for using a comment about you as a testbed for my Flow export script ...)

Pppery updated the task description. (Show Details)Mar 23 2025, 8:23 PM

It doesn't work because > is not a valid character in page titles (it's only valid in IDs / fragments), so we can't link to this comment using the wikitext permalink syntax.

The Special:GoToComment page could alternatively take the ID as a query parameter (like https://www.mediawiki.org/wiki/Special:FindComment?idorname=c-ThatRobloxianuser2K6-20250128053500-Broken_file_uploads_on_Miraheze%3F%3F%3F%3F_help_me_pls!_>%3B(), but that kind of link also couldn't be used in a wikitext link.

We could just hide that message when the page title would be invalid (since you in fact can not go directly to the comment using that link), and give up on solving the underlying problem. It is hopefully rare.

Works for me.

Change #1130709 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] SpecialFindComment: Hide link to GoToComment if it would be invalid

https://gerrit.wikimedia.org/r/1130709

gerritbot added a project: Patch-For-Review.Mar 24 2025, 8:03 PM

matmarex claimed this task.Mar 24 2025, 8:03 PM

Change #1130709 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] SpecialFindComment: Hide link to GoToComment if it would be invalid

https://gerrit.wikimedia.org/r/1130709

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Mar 28 2025, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 28 2025, 1:30 PM

matmarex closed this task as Resolved.Mar 28 2025, 9:03 PM

GoToComment does not work for certain characters in comment IDsClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

GoToComment does not work for certain characters in comment IDs
Closed, ResolvedPublicBUG REPORT
Actions