Page MenuHomePhabricator
Create Task
Maniphest T389889

Minerva test builds are failing after recent Selenium upgrades
Open, Needs TriagePublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Latest build has failed

Error: Cannot submit login form
    at async LoginPage.login (/src/node_modules/wdio-mediawiki/LoginPage.js:38:3)
    at async LoginPage.loginAdmin (/src/node_modules/wdio-mediawiki/LoginPage.js:52:3)
    at async iAmLoggedIn (/src/tests/selenium/features/step_definitions/common_steps.js:51:2)
    at async iAmLoggedIntoTheMobileWebsite (/src/tests/selenium/features/step_definitions/common_steps.js:57:2)
    at async Context.<anonymous> (/src/tests/selenium/specs/watchstar.js:16:3)

This suggests an issue with logging in to the beta cluster.

What should have happened instead?:
Test should be green

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Likely relates to T293084 T389536 as these changed around same time.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Login via desktop sitemediawiki/skins/MinervaNeuemaster+7 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson-WMF created this task.Mar 24 2025, 10:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2025, 10:23 PM
Jdlrobson-WMF mentioned this in T293084: Refactor MinervaNeue WebdriverIO tests from sync to async mode.Mar 24 2025, 10:25 PM
Jdlrobson-WMF mentioned this in T389536: Selenium timeouts can cause the job to remain stuck until the build times out.
Jdlrobson-WMF added projects: Continuous-Integration-Infrastructure, Test-Platform.
Novem_Linguae subscribed.Mar 24 2025, 10:33 PM
Daimona mentioned this in T389901: wdio-mediawiki should record video of before hooks.Mar 25 2025, 12:34 AM
Daimona added a comment.Mar 25 2025, 12:40 AM

I'm not sure at first glance what might be wrong, but one thing worth emphasizing: before last week's changes, tests were not waiting for async assertions. So, failing assertions did not cause test failures, which in turn means the test might have been broken before our changes for all we know.

Anyway. wdio-mediawiki does not give us a video recording of the before(Each) hooks (T389901). And there are no interesting logs. So, I followed https://www.mediawiki.org/wiki/Selenium/Getting_Started/Run_tests_targeting_Beta_cluster to run the test locally. Sure enough, it cannot login: the page shows a captcha and selenium doesn't know about it.

Daimona added a comment.Mar 25 2025, 12:54 AM
In T389889#10672103, @Daimona wrote:

Sure enough, it cannot login: the page shows a captcha and selenium doesn't know about it.

Actually, that might have been because I made too many attempts too quickly. But well, selenium tests are parallelized and have retries, so... And it was failing because the on-wiki docs have just an example username and password, of course. So I created https://meta.wikimedia.beta.wmflabs.org/wiki/Special:Contributions/T389889 and tried again. Here's what I got:

image.png (372×2 px, 36 KB)

(for searching: "No active login attempt is in progress for your session."). I tried logging in from the browser and it worked. Then again via selenium and again it failed.

zeljkofilipin edited projects, added Testing Support; removed Test-Platform.Mar 25 2025, 10:08 AM
hashar removed a project: Continuous-Integration-Infrastructure.Mar 25 2025, 1:31 PM
Jdlrobson added projects: Beta-Cluster-reproducible, MediaWiki-extensions-CentralAuth.Mar 28 2025, 5:28 PM
Jdlrobson subscribed.

Seems like an issue with beta cluster and CentralAuth? I had a similar issue logging in on mobile today.

Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptMar 28 2025, 5:28 PM
• larissagaulia moved this task from Inbox, needs triage to Not planned (Patches welcome!) on the MediaWiki-Platform-Team board.Mar 31 2025, 1:54 PM
gerritbot added a comment.Mar 31 2025, 8:05 PM

Change #1132750 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Login via desktop site

https://gerrit.wikimedia.org/r/1132750

gerritbot added a project: Patch-For-Review.Mar 31 2025, 8:05 PM
gerritbot added a comment.Apr 9 2025, 6:11 PM

Change #1132750 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Login via desktop site

https://gerrit.wikimedia.org/r/1132750

Maintenance_bot removed a project: Patch-For-Review.Apr 9 2025, 6:30 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.25; 2025-04-15).Apr 9 2025, 7:00 PM
DAlangi_WMF moved this task from Not planned (Patches welcome!) to Radar on the MediaWiki-Platform-Team board.May 27 2025, 2:09 PM
DAlangi_WMF edited projects, added MediaWiki-Platform-Team (Radar); removed MediaWiki-Platform-Team.
SDunlap added a project: Browser Test Platform.Nov 17 2025, 9:37 PM
zeljkofilipin removed a project: Testing Support.Nov 20 2025, 4:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits