Page MenuHomePhabricator
Create Task
Maniphest T389893

Remove modtoken and multiPrimaryMode from SqlBagOStuff and mainstash
Closed, ResolvedPublic
Actions

Description

My dumpster diving of binlogs showed that cases modtoken or multiPrimaryMode would be useful are so extremely rare that they can safely ignored (I didn't find one in half an hour of binlog). Hereby, I propose to simplify the code and our lives. First, let's set multiPrimaryMode to false in mainstash. Make sure everything is fine, then start cleaning up things.

Follow up to T383327: Re-architecture mainstash (x2) to allow easier maintenance

Effectively reverting https://gerrit.wikimedia.org/r/c/mediawiki/core/+/713925

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
schema: Drop modtoken from objectcachemediawiki/coremaster+155 -24
tests: Remove SqlBagOStuffMultiPrimaryIntegrationTestmediawiki/coremaster+0 -17
SqlBagOStuff: First pass at removing modtoken and multiPrimaryModemediawiki/coremaster+42 -248
mainstash: Disable multiPrimaryModeoperations/mediawiki-configmaster+0 -1
Customize query in gerrit

Related Objects

Event Timeline

Ladsgroup created this task.Mar 24 2025, 11:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2025, 11:26 PM
Ladsgroup triaged this task as Medium priority.Mar 24 2025, 11:27 PM
Ladsgroup moved this task from Triage to Ready on the DBA board.
Ladsgroup added a project: MediaWiki-libs-BagOStuff.
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptMar 24 2025, 11:27 PM
Ladsgroup updated the task description. (Show Details)Mar 25 2025, 2:14 PM
• larissagaulia moved this task from Inbox, needs triage to Radar on the MediaWiki-Platform-Team board.Mar 31 2025, 2:35 PM
• larissagaulia edited projects, added MediaWiki-Platform-Team (Radar); removed MediaWiki-Platform-Team.
gerritbot added a comment.Apr 7 2025, 11:38 AM

Change #1134663 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[operations/mediawiki-config@master] mainstash: Disable multiPrimaryMode

https://gerrit.wikimedia.org/r/1134663

gerritbot added a project: Patch-For-Review.Apr 7 2025, 11:38 AM
gerritbot added a comment.Oct 7 2025, 10:09 AM

Change #1134663 merged by jenkins-bot:

[operations/mediawiki-config@master] mainstash: Disable multiPrimaryMode

https://gerrit.wikimedia.org/r/1134663

Stashbot added a comment.Oct 7 2025, 10:09 AM

Mentioned in SAL (#wikimedia-operations) [2025-10-07T10:09:45Z] <ladsgroup@deploy2002> Started scap sync-world: Backport for [[gerrit:1134663|mainstash: Disable multiPrimaryMode (T389893)]]

Stashbot added a comment.Oct 7 2025, 10:14 AM

Mentioned in SAL (#wikimedia-operations) [2025-10-07T10:14:17Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:1134663|mainstash: Disable multiPrimaryMode (T389893)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Oct 7 2025, 10:24 AM

Mentioned in SAL (#wikimedia-operations) [2025-10-07T10:24:36Z] <ladsgroup@deploy2002> Finished scap sync-world: Backport for [[gerrit:1134663|mainstash: Disable multiPrimaryMode (T389893)]] (duration: 14m 51s)

Ladsgroup added a comment.Oct 7 2025, 10:26 AM

Deployed. I wait for a week to see if it causes any user-facing issues. If not, then I start dismantling the code in mediawiki core.

Ladsgroup moved this task from Ready to In progress on the DBA board.Oct 7 2025, 10:26 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 7 2025, 10:32 AM
gerritbot added a comment.Oct 14 2025, 12:41 PM

Change #1196055 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] SqlBagOStuff: First pass at removing modtoken and multiPrimaryMode

https://gerrit.wikimedia.org/r/1196055

gerritbot added a project: Patch-For-Review.Oct 14 2025, 12:41 PM
gerritbot added a comment.Oct 23 2025, 5:14 AM

Change #1196055 merged by jenkins-bot:

[mediawiki/core@master] SqlBagOStuff: First pass at removing modtoken and multiPrimaryMode

https://gerrit.wikimedia.org/r/1196055

Maintenance_bot removed a project: Patch-For-Review.Oct 23 2025, 5:30 AM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.25; 2025-10-28).Oct 23 2025, 6:00 AM
gerritbot added a comment.Oct 23 2025, 3:57 PM

Change #1198361 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] tests: Remove SqlBagOStuffMultiPrimaryIntegrationTest

https://gerrit.wikimedia.org/r/1198361

gerritbot added a project: Patch-For-Review.Oct 23 2025, 3:57 PM
gerritbot added a comment.Oct 23 2025, 8:18 PM

Change #1198361 merged by jenkins-bot:

[mediawiki/core@master] tests: Remove SqlBagOStuffMultiPrimaryIntegrationTest

https://gerrit.wikimedia.org/r/1198361

Maintenance_bot removed a project: Patch-For-Review.Oct 23 2025, 8:30 PM
gerritbot added a comment.Dec 1 2025, 9:53 AM

Change #1213424 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] schema: Drop modtoken from objectcache

https://gerrit.wikimedia.org/r/1213424

gerritbot added a project: Patch-For-Review.Dec 1 2025, 9:53 AM
gerritbot added a comment.Dec 1 2025, 6:48 PM

Change #1213424 merged by jenkins-bot:

[mediawiki/core@master] schema: Drop modtoken from objectcache

https://gerrit.wikimedia.org/r/1213424

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.5; 2025-12-02).Dec 1 2025, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 1 2025, 7:31 PM
Ladsgroup mentioned this in T411497: Drop modtoken and flags columns from cache tables.Dec 2 2025, 1:39 PM
Ladsgroup closed this task as Resolved.Dec 3 2025, 3:15 PM
Ladsgroup moved this task from In progress to Done on the DBA board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits