Per what @DLynch shared offline, before moving forward with introducing a new Edit Tag for Peacock Check (as this task asks for), we'll need to consider how/if this one-tag/Check approach will scale to a future where ≥10 Check types could be activated within a single edit session.

In line with the above, I've added T342460 as a sub-task of this one.

Look for mw.editcheck.refCheckShown in init.js and controller.js to see what we're currently doing for the tag tracking the reference check. Note that Hooks.php contains a whitelist of tags that're allowed to be added this way.

Update

Barring any blocking issues with renaming Peacock Check to Tone Check, I propose we name the tag that gets appended when ≥1 Peacock Check is activated within an edit editcheck-tone-shown.

The above follows the conventions we redefined in T373949.

Next step(s)

• @ppelberg: ensure no blocking concerns with renaming Peacock Check to Tone Check

Change #1152382 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: create editcheck-tone-shown tag

https://gerrit.wikimedia.org/r/1152382

The tag is implemented as editcheck-tone-shown to mirror the reference check tag, and I made roughly-equivalent descriptions for translation purposes.

Change #1152382 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: create editcheck-tone-shown tag

https://gerrit.wikimedia.org/r/1152382

In T389897#10872913, @DLynch wrote:

The tag is implemented as editcheck-tone-shown to mirror the reference check tag, and I made roughly-equivalent descriptions for translation purposes.

Wonderful – this aligns with what I'd been thinking (T389897#10836525).

Assumptions made while testing:

1. TBD in No. 1 requirement is editcheck-tone-shown

✅ Tag is rightly attached

⚠️ I don't see editcheck-tone-shown or Edit Check (tone) shown in the Tag Filter dropdown

Filter rightly displayed

I think this was the known issue with the tag only being applied when you saw the check pre-save. That was fixed yesterday, though semi-amusingly it looks like the patch merged about 10 minutes after you tested it @Ryasmeen. Could you check again and make sure the tag is getting applied both mid-edit and pre-save?

My own tag from mid-edit:

(You can also check this in the console to see what checks are remembered as having been shown in the current session: mw.editcheck.checksShown.)

I checked the fix for some scenarios that involves both mid-edit and pre-save trigger of tone check and verified that the tag editcheck-tone-shown is getting applied for both mid-edit and pre-save.