Page MenuHomePhabricator
Create Task
Maniphest T389904

[Regression] Page is editable in the pre-publish mode of edit check on Beta cluster
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Go to any page on Beta cluster.
  2. Add enough content to activate edit check
  3. When a check is activated and you are in pre save mode. try typing into the article.

Observed Result:
Page is editable in the pre-publish mode of edit check on Beta cluster

Browser: Chrome

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (28c6033b0)mediawiki/extensions/VisualEditormaster+1 -1
Edit check: don't react to selection changes in review modemediawiki/extensions/VisualEditormaster+4 -0
Deactivate/reactivate the surface when entering/leaving review modeVisualEditor/VisualEditormaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Mar 25 2025, 1:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2025, 1:43 AM
DLynch added a comment.Mar 25 2025, 3:46 AM

Focus isn't being stolen from the surface when pre-save mode activates -- note that if you click the surface, it will properly get removed and typing will no longer work.

DLynch added a comment.Mar 25 2025, 4:01 AM

Been broken since early December, ever since we landed https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1102899

ppelberg added a project: Editing-team (Kanban Board).Mar 25 2025, 4:12 AM
ppelberg moved this task from Inbox to Ready to Be Worked On on the Editing-team (Kanban Board) board.
gerritbot added a comment.Mar 25 2025, 10:00 PM

Change #1131047 had a related patch set uploaded (by DLynch; author: DLynch):

[VisualEditor/VisualEditor@master] Deactivate/reactivate the surface when entering/leaving review mode

https://gerrit.wikimedia.org/r/1131047

gerritbot added a project: Patch-For-Review.Mar 25 2025, 10:00 PM
DLynch claimed this task.Mar 25 2025, 10:01 PM
DLynch moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Mar 25 2025, 10:01 PM

Change #1131048 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: don't react to selection changes in review mode

https://gerrit.wikimedia.org/r/1131048

DLynch mentioned this in T389906: [Regression] Broken workflow after closing the "Add a citation" dialog prompted from a check and then trying to save the edit.Mar 26 2025, 3:15 AM
gerritbot added a comment.Mar 26 2025, 1:02 PM

Change #1131047 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Deactivate/reactivate the surface when entering/leaving review mode

https://gerrit.wikimedia.org/r/1131047

gerritbot added a comment.Mar 26 2025, 2:37 PM

Change #1131048 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: don't react to selection changes in review mode

https://gerrit.wikimedia.org/r/1131048

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Mar 26 2025, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 26 2025, 3:30 PM
gerritbot added a comment.Mar 27 2025, 12:53 PM

Change #1131312 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (28c6033b0)

https://gerrit.wikimedia.org/r/1131312

gerritbot added a project: Patch-For-Review.Mar 27 2025, 12:53 PM
DLynch added a project: Editing QA.Mar 27 2025, 3:08 PM
DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.
gerritbot added a comment.Mar 27 2025, 3:23 PM

Change #1131312 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (28c6033b0)

https://gerrit.wikimedia.org/r/1131312

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Mar 28 2025, 12:46 AM
Ryasmeen edited projects, added Verified; removed Editing QA, Patch-For-Review.Mar 28 2025, 12:51 AM
DLynch mentioned this in T344382: [Edit Check] Publish changes button in VE does not react anymore after abandoning Edit Check by switching to read mode .Mar 29 2025, 1:43 AM
VPuffetMichel closed this task as Resolved.Apr 26 2025, 3:33 PM
VPuffetMichel added a project: OKR-Work.
VPuffetMichel moved this task from To Triage to Triaged on the VisualEditor board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits