Page MenuHomePhabricator

[Regression] Page is editable in the pre-publish mode of edit check on Beta cluster
Closed, ResolvedPublic

Description

Steps to reproduce:

  1. Go to any page on Beta cluster.
  2. Add enough content to activate edit check
  3. When a check is activated and you are in pre save mode. try typing into the article.

Observed Result:
Page is editable in the pre-publish mode of edit check on Beta cluster

Browser: Chrome

Event Timeline

Focus isn't being stolen from the surface when pre-save mode activates -- note that if you click the surface, it will properly get removed and typing will no longer work.

Change #1131047 had a related patch set uploaded (by DLynch; author: DLynch):

[VisualEditor/VisualEditor@master] Deactivate/reactivate the surface when entering/leaving review mode

https://gerrit.wikimedia.org/r/1131047

Change #1131048 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: don't react to selection changes in review mode

https://gerrit.wikimedia.org/r/1131048

Change #1131047 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Deactivate/reactivate the surface when entering/leaving review mode

https://gerrit.wikimedia.org/r/1131047

Change #1131048 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: don't react to selection changes in review mode

https://gerrit.wikimedia.org/r/1131048

Change #1131312 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (28c6033b0)

https://gerrit.wikimedia.org/r/1131312

Change #1131312 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (28c6033b0)

https://gerrit.wikimedia.org/r/1131312

VPuffetMichel added a project: OKR-Work.
VPuffetMichel moved this task from To Triage to Triaged on the VisualEditor board.