[Regression] Broken workflow after closing the "Add a citation" dialog prompted from a check and then trying to save the edit
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ryasmeen
	Mar 25 2025, 2:05 AM

Description

Steps to reproduce:

Open any page on Beta cluster to edit using VE.
Add a paragraph that would activate the Reference Check.
Once the check is presented click on "Yes"
After that step, when the add a citation context menu appears close it out
Click on "Publish Changes" button again.

Observed Result:
The editing state transitions to the pre-save mode without any check. (The check actually appears very briefly for a second but then it disappears leaving the editor in this empty state).

Expected Result:
The check should be presented just like the first time upon clicking on "Publish Changes" button.

Screenshot/Screen capture:

Screenshot 2025-03-24 at 6.16.46 PM.png (1×2 px, 335 KB)

Browser: Chrome

Wiki: en

Environment: beta cluster.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Edit check: in single action mode the fixed sidebar isn't allowed null offset	mediawiki/extensions/VisualEditor	wmf/1.44.0-wmf.22	+12 -2
Edit check: in single action mode the fixed sidebar isn't allowed null offset	mediawiki/extensions/VisualEditor	master	+12 -2
Edit check: don't close the sidebar on context change on desktop	mediawiki/extensions/VisualEditor	wmf/1.44.0-wmf.22	+2 -1
Edit check: don't close the sidebar on context change on desktop	mediawiki/extensions/VisualEditor	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned In: T373949: Clarify the meaning of the editcheck-references-activated tag
Mentioned Here: T389904: [Regression] Page is editable in the pre-publish mode of edit check on Beta cluster
T373949: Clarify the meaning of the editcheck-references-activated tag

Event Timeline

Ryasmeen created this task.Mar 25 2025, 2:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2025, 2:05 AM

I can't actually persuade it not-reopening to happen for me, so there might be something fiddly about that. I do see issues with the sidebar disappearing when it shouldn't, though -- spillover from the mid-edit mobile stuff.

DLynch claimed this task.Mar 25 2025, 4:13 AM

DLynch added a project: Editing-team (Kanban Board).

DLynch moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.

Change #1130778 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: don't close the sidebar on context change on desktop

https://gerrit.wikimedia.org/r/1130778

gerritbot added a project: Patch-For-Review.Mar 25 2025, 4:16 AM

Change #1130778 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: don't close the sidebar on context change on desktop

https://gerrit.wikimedia.org/r/1130778

Maintenance_bot removed a project: Patch-For-Review.Mar 25 2025, 8:30 AM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Mar 25 2025, 9:00 AM

Change #1131004 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@wmf/1.44.0-wmf.22] Edit check: don't close the sidebar on context change on desktop

https://gerrit.wikimedia.org/r/1131004

gerritbot added a project: Patch-For-Review.Mar 25 2025, 12:56 PM

Change #1131004 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.44.0-wmf.22] Edit check: don't close the sidebar on context change on desktop

https://gerrit.wikimedia.org/r/1131004

Mentioned in SAL (#wikimedia-operations) [2025-03-25T14:43:46Z] <kemayo@deploy1003> Started scap sync-world: Backport for [[gerrit:1131003|Edit check: add editcheck-references-shown to the allowed tags list (T373949)]], [[gerrit:1131004|Edit check: don't close the sidebar on context change on desktop (T389906)]]

Mentioned in SAL (#wikimedia-operations) [2025-03-25T14:50:18Z] <kemayo@deploy1003> kemayo: Backport for [[gerrit:1131003|Edit check: add editcheck-references-shown to the allowed tags list (T373949)]], [[gerrit:1131004|Edit check: don't close the sidebar on context change on desktop (T389906)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.22; 2025-03-25); removed MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Mar 25 2025, 3:00 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-25T15:01:16Z] <kemayo@deploy1003> Finished scap sync-world: Backport for [[gerrit:1131003|Edit check: add editcheck-references-shown to the allowed tags list (T373949)]], [[gerrit:1131004|Edit check: don't close the sidebar on context change on desktop (T389906)]] (duration: 17m 30s)

Looks good to me on beta (and group0), if you can confirm.

Maintenance_bot removed a project: Patch-For-Review.Mar 25 2025, 3:31 PM

In T389906#10674519, @DLynch wrote:

Looks good to me on beta (and group0), if you can confirm.

It is fixed for the scenario mentioned in the task yes. But, it still happens when you click on the "Back" button while the "Add a citation" dialog is open in the pre-save mode and then again click on "Publish Changes" button.

Ryasmeen removed a project: Editing QA.Mar 26 2025, 2:16 AM

Ryasmeen moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.

Ah, weirdly enough, that one is actually a variant of T389904. The patches for that one will fix it.

Change #1131126 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: in single action mode the fixed sidebar isn't allowed null offset

https://gerrit.wikimedia.org/r/1131126

gerritbot added a project: Patch-For-Review.Mar 26 2025, 3:34 AM

^ That will fix it more-specifically, though.

Change #1131126 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: in single action mode the fixed sidebar isn't allowed null offset

https://gerrit.wikimedia.org/r/1131126

Maintenance_bot removed a project: Patch-For-Review.Mar 26 2025, 10:30 AM

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.23; 2025-04-01); removed MW-1.44-notes (1.44.0-wmf.22; 2025-03-25).Mar 26 2025, 11:00 AM

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Mar 26 2025, 3:32 PM

DLynch added a project: Editing QA.

Change #1131361 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@wmf/1.44.0-wmf.22] Edit check: in single action mode the fixed sidebar isn't allowed null offset

https://gerrit.wikimedia.org/r/1131361

gerritbot added a project: Patch-For-Review.Mar 26 2025, 4:05 PM

Change #1131361 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.44.0-wmf.22] Edit check: in single action mode the fixed sidebar isn't allowed null offset

https://gerrit.wikimedia.org/r/1131361

Mentioned in SAL (#wikimedia-operations) [2025-03-26T20:11:22Z] <spiderpig@deploy1003> Started scap sync-world: Backport for [[gerrit:1131361|Edit check: in single action mode the fixed sidebar isn't allowed null offset (T389906)]]

Mentioned in SAL (#wikimedia-operations) [2025-03-26T20:16:05Z] <spiderpig@deploy1003> spiderpig, kemayo: Backport for [[gerrit:1131361|Edit check: in single action mode the fixed sidebar isn't allowed null offset (T389906)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-03-26T20:26:25Z] <spiderpig@deploy1003> Finished scap sync-world: Backport for [[gerrit:1131361|Edit check: in single action mode the fixed sidebar isn't allowed null offset (T389906)]] (duration: 15m 03s)

Maintenance_bot removed a project: Patch-For-Review.Mar 26 2025, 8:30 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-26T20:33:37Z] <spiderpig@deploy1003> Started scap sync-world: Backport for [[gerrit:1131361|Edit check: in single action mode the fixed sidebar isn't allowed null offset (T389906)]]

Mentioned in SAL (#wikimedia-operations) [2025-03-26T20:38:20Z] <spiderpig@deploy1003> kemayo, spiderpig: Backport for [[gerrit:1131361|Edit check: in single action mode the fixed sidebar isn't allowed null offset (T389906)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-03-26T20:45:33Z] <spiderpig@deploy1003> Finished scap sync-world: Backport for [[gerrit:1131361|Edit check: in single action mode the fixed sidebar isn't allowed null offset (T389906)]] (duration: 11m 55s)