Page MenuHomePhabricator

Have LibUp upgrade selenium dependencies
Closed, ResolvedPublic

Description

The various @wdio/... dependencies are not upgraded by LibUp, and (unlike say PHPUnit), each repo defines its own. For example, we have 10 different versions of @wdio/local-runner. Maybe there aren't many differences between these, but since we're in selenium territory, I'd rather avoid any potential of bugs if we can help it.

Event Timeline

Minor and patch version updates should be fine to do automatically, but they rarely matter. Major version updates will very likely break the tests (tracked in T324685 and T363704).

Minor and patch version updates should be fine to do automatically, but they rarely matter. Major version updates will very likely break the tests (tracked in T324685 and T363704).

Yup, we won't try to have LibUp auto-upgrade to 8.x versions. LibUp also won't downgrade repos that have newer versions than it has on its approved list, so this should Just Work™.

Minor and patch version updates should be fine to do automatically, but they rarely matter.

I pondered this a lot before creating this task: whether we should just use ^ as some repos are already doing. Eventually I decided not to: first, because part of the motivation here is consistency between repo, and not using fixed version doesn't help with that; second, if LibUp handles these, we shouldn't lag too far behind; and third because for test frameworks, we seem to generally prefer fixed versions to avoid CI breakage.

For the "rarely matter" part, that's kind of what I'm not willing to assume at this point. Some of the failures we're seeing (like hanging jobs in T389536) seem pretty serious, and I imagine upstream would be backporting fixes to older releases, assuming these are upstream issues. So, I'm effectively trying to take the "minor/patch version differences" out of the equation.

Major version updates will very likely break the tests (tracked in T324685 and T363704).

Yeah, we're not going to have LibUp auto-update those. All we need to do is update the LibUp config to the latest version of the new major branch once the time comes (hopefully soon).