Page MenuHomePhabricator
Create Task
Maniphest T389959

Unfavouriting a template from the template list should remove the favourite, and not navigate to the template
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
You are taken to the template page

What should have happened instead?:
The template is removed from your favourites

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Ignore FavoriteButton clicks in TemplateMenuItem click handlermediawiki/extensions/TemplateDatamaster+8 -5
Customize query in gerrit

Related Objects

Event Timeline

TheresNoTime created this task.Mar 25 2025, 3:21 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptMar 25 2025, 3:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
TheresNoTime edited projects, added Community-Tech (Fox Squad); removed Community-Tech.Mar 25 2025, 3:21 PM
Samwilson claimed this task.Mar 26 2025, 1:31 AM
Samwilson moved this task from Ready for Dev to In Development on the Community-Tech (Fox Squad) board.
gerritbot added a comment.Mar 26 2025, 3:18 AM

Change #1131124 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/TemplateData@master] Ignore FavoriteButton clicks in TemplateMenuItem click handler

https://gerrit.wikimedia.org/r/1131124

gerritbot added a project: Patch-For-Review.Mar 26 2025, 3:18 AM
Samwilson moved this task from In Development to Feedback and Review on the Community-Tech (Fox Squad) board.Mar 26 2025, 3:32 AM
gerritbot added a comment.Mar 26 2025, 9:05 AM

Change #1131124 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Ignore FavoriteButton clicks in TemplateMenuItem click handler

https://gerrit.wikimedia.org/r/1131124

Maintenance_bot removed a project: Patch-For-Review.Mar 26 2025, 9:30 AM
TheresNoTime moved this task from Feedback and Review to QA on the Community-Tech (Fox Squad) board.Mar 26 2025, 9:54 AM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Mar 26 2025, 10:00 AM
Samwilson closed this task as Resolved.Mar 26 2025, 10:23 AM

As the task that resulted in this bug (T377970) is still in QA, I think this one can just be resolved and that one can handle this one's fix confirmation.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits