Page MenuHomePhabricator

Special:Block [Codex]: Surface any range blocks that effect the target
Open, Needs TriagePublic5 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  1. Navigate to Special:Block.
  2. Block the IP range 1.2.3.20/30.
  3. Block the IP range 1.2.3.21/30.
  4. Once blocked, search for 1.2.3.20 or 1.2.3.21.

What happens?:
The search does not return any results for 1.2.3.20 or 1.2.3.21, even though those IPs were blocked within the specified ranges.

What should have happened instead?:

Special:Block should display the blocks associated with 1.2.3.20 and 1.2.3.21.

OS: macOS Sequoia 15.4
Browser: Chrome 134
Device: MBA
Site: https://test.wikipedia.beta.wmflabs.org/wiki/Special:Block/1.2.3.20/30

2025-03-25_11-11-29.mp4.gif (1×1 px, 2 MB)

Acceptance criteria

  • When searching for an IP or range, show an "Active range blocks" accordion and table, listing each range block that effects the target
  • If the target is itself a range which is blocked, the block is instead shown in "Active blocks"
  • The "Active range blocks" table should have only a "View" link in each row, which when clicked will change the target to that range.
  • Doing the same for the "Block log" is out of scope and not part of this task.
  • "Active range blocks" is always shown when looking up an IP or IP range, but has an empty state if there are no entries in the table

Event Timeline

GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF updated the task description. (Show Details)
JWheeler-WMF updated the task description. (Show Details)
JWheeler-WMF set the point value for this task to 5.
MusikAnimal updated Other Assignee, removed: MusikAnimal.

Change #1133233 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/core@master] SpecialBlock [Codex]: Include an 'Active range blocks' table for IPs

https://gerrit.wikimedia.org/r/1133233

MusikAnimal renamed this task from Blocks for Overlapping IP Ranges Not Displayed in Special:Block Search to Special:Block [Codex]: Surface any range blocks that effect the target.Tue, Apr 1, 8:13 PM
MusikAnimal updated the task description. (Show Details)

I changed one thing from what we discussed:

The Active range blocks table should ONLY appear if the target has an active range block against it.

This can be done but it was an easier implementation to just give the table an empty state, just like we do for "Active blocks". In my opinion having the empty state is actually good; It very clearly shows the target has no range blocks effecting it. Remember that before, this was something admins had to look up manually, so even just saying there are "no active range blocks" is useful. I assume this is OK, cc @JWheeler-WMF

Change #1133233 merged by jenkins-bot:

[mediawiki/core@master] SpecialBlock [Codex]: Include an 'Active range blocks' table for IPs

https://gerrit.wikimedia.org/r/1133233

@MusikAnimal I am not sure about the logic of when a range block is included in the Active blocks table vs the Active range blocks table.

Going to https://test.wikipedia.beta.wmflabs.org/wiki/Special:Block and entering 23EC:288F:C700::/40, 23ec:288f:c762:b770:f357:bbc0:ede5:138b/40 or 23ec:288f:c700:0:0:0:0:0/40, they are included in the Active range blocks:

active_range_blocks.png (657×1 px, 68 KB)

If instead I enter 23EC:288F:C700:0:0:0:0:0/40 they are included in the Active blocks table:

active_blocks.png (720×1 px, 66 KB)

@MusikAnimal I am not sure about the logic of when a range block is included in the Active blocks table vs the Active range blocks table.

Good catch! This should be fixed now following T391144.