When hovering anywhere in the search results list, all favorite buttons get a border:
 |  |
The border should only appear when hovering on a favourite button, and then it should only be on the button that's being hovered on.
Description
Description
Details
Details
Related Changes in Gerrit:
Event Timeline
Comment Actions
Hi @Samwilson , I am very excited to be a part of the community and looking forward to contribute to the best of my abilities. I would like to begin by going ahead with this task. Can you please assign it to
me?
Comment Actions
@Nidhicodes Welcome! Sure, very happy for you to take this on. You've already assigned it to yourself. :-)
Have you worked on MediaWiki before? This is a good starting point: https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker
Comment Actions
@Nidhicodes I'm going to assume you're busy with other things, and claim this task. The borders have been annoying me and I want to fix them! :-) Hope that's okay.
Comment Actions
Change #1134395 had a related patch set uploaded (by Samwilson; author: Samwilson):
[mediawiki/extensions/TemplateData@master] Remove background and border from FavoriteButtons in search results
Comment Actions
Change #1134395 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Remove background and border from FavoriteButtons in search results
Comment Actions
@Samwilson I notice when the search menu first displays (or if you navigate away from the tab and then back) there is something like a border around the first favourite button. It goes away when you hover over the search menu. I don't know how much this matters.
EDIT: The border also appears when you navigate through the search menus with the keyboard, if you the cursor is not hovering over the menu.
Comment Actions
There are some circumstances where you see a light border, but perhaps it does not matter. Resolving.