Page MenuHomePhabricator

PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Called from MediaWiki\Extension\FundraiserLandingPage\Specials\FundraiserLandingPage::execute]
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Called from MediaWiki\Extension\FundraiserLandingPage\Specials\FundraiserLandingPage::execute]
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.22/extensions/FundraiserLandingPage/includes/Specials/FundraiserLandingPage.php(114)
#0[internal function]MWExceptionHandler::handleError(int, string, string, string)
#1/srv/mediawiki/php-1.44.0-wmf.22/includes/debug/MWDebug.php(386)trigger_error(string, int)
#2/srv/mediawiki/php-1.44.0-wmf.22/includes/debug/MWDebug.php(357)MediaWiki\Debug\MWDebug::sendRawDeprecated(string, bool, string)
#3/srv/mediawiki/php-1.44.0-wmf.22/includes/debug/MWDebug.php(238)MediaWiki\Debug\MWDebug::deprecatedMsg(string, string, string, int)
#4/srv/mediawiki/php-1.44.0-wmf.22/includes/GlobalFunctions.php(781)MediaWiki\Debug\MWDebug::deprecated(string, string, string, int)
#5/srv/mediawiki/php-1.44.0-wmf.22/includes/Output/OutputPage.php(2017)wfDeprecated(string, string)
#6/srv/mediawiki/php-1.44.0-wmf.22/extensions/FundraiserLandingPage/includes/Specials/FundraiserLandingPage.php(114)MediaWiki\Output\OutputPage->parserOptions()
#7/srv/mediawiki/php-1.44.0-wmf.22/includes/specialpage/SpecialPage.php(729)MediaWiki\Extension\FundraiserLandingPage\Specials\FundraiserLandingPage->execute(null)
#8/srv/mediawiki/php-1.44.0-wmf.22/includes/specialpage/SpecialPageFactory.php(1737)MediaWiki\SpecialPage\SpecialPage->run(null)
#9/srv/mediawiki/php-1.44.0-wmf.22/includes/actions/ActionEntryPoint.php(499)MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#10/srv/mediawiki/php-1.44.0-wmf.22/includes/actions/ActionEntryPoint.php(143)MediaWiki\Actions\ActionEntryPoint->performRequest()
#11/srv/mediawiki/php-1.44.0-wmf.22/includes/MediaWikiEntryPoint.php(202)MediaWiki\Actions\ActionEntryPoint->execute()
#12/srv/mediawiki/php-1.44.0-wmf.22/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#13/srv/mediawiki/w/index.php(3)require(string)
#14{main}
Impact
  • High, 345 hits in last 10 minutes
  • Only affects donate.wikimedia.org
Notes

Event Timeline

Aklapper triaged this task as Unbreak Now! priority.
hashar added subscribers: cscott, hashar.

OutputPage::parserOptions() has been marked deprecated by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1056213 . I guess @cscott missed that one:

includes/Specials/FundraiserLandingPage.php
112         // Hijack parser internals to workaround T156184.  This should be safe
113         // since we've sanitized all params.
114         $parserOptions = $out->parserOptions();
115         $parserOptions->setAllowUnsafeRawHtml( true );
116 
117         // print the output to the page
118         $out->addWikiTextAsInterface( $output );

https://donate.wikimedia.org/ is broken, which is used for all our non-banner fundraising. Can we get a rollback for this please?

https://donate.wikimedia.org/w/index.php?title=Special:LandingPage looks readable again; no <html> tags cannot be used outside of normal pages errors exposed

Thanks, looks good to me as well now and I was able to make a donation.

It seems the problem was only when loading Special:LandingPage, other pages on the wiki were fine

See also similar T390040 and T390041 in CentralNotice.

Change #1131324 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[mediawiki/extensions/FundraiserLandingPage@master] Remove use of deprecated OutputPage::parserOptions()

https://gerrit.wikimedia.org/r/1131324

Change #1131329 had a related patch set uploaded (by Aklapper; author: Jforrester):

[mediawiki/extensions/FundraiserLandingPage@master] [WIP] Instead of calling deprecated parserOptions(), parse content ourselves

https://gerrit.wikimedia.org/r/1131329

Change #1131324 abandoned by Jgleeson:

[mediawiki/extensions/FundraiserLandingPage@master] Remove use of deprecated OutputPage::parserOptions()

Reason:

Alternative solution here d6c4ab9d963cf8e7551af3ba1cd60422ff983fb4

https://gerrit.wikimedia.org/r/1131324

Change #1131329 merged by jenkins-bot:

[mediawiki/extensions/FundraiserLandingPage@master] Instead of calling deprecated parserOptions(), parse content ourselves

https://gerrit.wikimedia.org/r/1131329

Change #1131348 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/FundraiserLandingPage@wmf/1.44.0-wmf.22] Instead of calling deprecated parserOptions(), parse content ourselves

https://gerrit.wikimedia.org/r/1131348

Change #1131348 merged by jenkins-bot:

[mediawiki/extensions/FundraiserLandingPage@wmf/1.44.0-wmf.22] Instead of calling deprecated parserOptions(), parse content ourselves

https://gerrit.wikimedia.org/r/1131348

Mentioned in SAL (#wikimedia-operations) [2025-03-27T08:48:56Z] <aklapper@deploy1003> Started scap sync-world: Backport for [[gerrit:1131348|Instead of calling deprecated parserOptions(), parse content ourselves (T390032)]]

Mentioned in SAL (#wikimedia-operations) [2025-03-27T08:53:45Z] <aklapper@deploy1003> aklapper, jforrester: Backport for [[gerrit:1131348|Instead of calling deprecated parserOptions(), parse content ourselves (T390032)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-03-27T09:01:20Z] <aklapper@deploy1003> Finished scap sync-world: Backport for [[gerrit:1131348|Instead of calling deprecated parserOptions(), parse content ourselves (T390032)]] (duration: 12m 24s)

Backport of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FundraiserLandingPage/+/1131329 in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FundraiserLandingPage/+/1131348 merged and deployed in 1.44.0-wmf.22, now to proceed with the train.
Optimistically resolving this task. (Thanks to everyone for the patches and looking into this!)