Page MenuHomePhabricator
Create Task
Maniphest T390054

Remove Use of OutputPage::parserOptions in Extension\FundraiserLandingPage
Closed, DuplicatePublic
Actions

Description

Old code in the extensions caused a UBN that required a rollback on donate-wiki. Ticket for that is T390032: PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Called from MediaWiki\Extension\FundraiserLandingPage\Specials\FundraiserLandingPage::execute]

Let's remove this code and replace it with a suitable alternative.

The offending code is here https://github.com/wikimedia/mediawiki-extensions-FundraiserLandingPage/blob/86b7ea7d3a7b0eb2dc8b751a1cbc1463e471fcb6/includes/Specials/FundraiserLandingPage.php#L114

Related Objects

Event Timeline

jgleeson created this task.Mar 26 2025, 1:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2025, 1:13 PM
Aklapper updated the task description. (Show Details)Mar 26 2025, 1:25 PM
Aklapper added a project: MediaWiki-extensions-FundraiserLandingPage.
jgleeson claimed this task.Mar 26 2025, 1:35 PM
jgleeson triaged this task as Unbreak Now! priority.
jgleeson moved this task from Backlog to In Progress on the Fundraising Tech - Chaos Crew board.
Restricted Application added a subscriber: Pcoombe. · View Herald TranscriptMar 26 2025, 1:36 PM
Jdforrester-WMF subscribed.Mar 26 2025, 1:48 PM

I was looking at this now, but it's hard to see how to do this properly. There's no replacement for addWikiTextAsInterface that also lets you set the page content to raw HTML.

gerritbot added a comment.Mar 26 2025, 1:49 PM

Change #1131324 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[mediawiki/extensions/FundraiserLandingPage@master] Remove use of deprecated OutputPage::parserOptions()

https://gerrit.wikimedia.org/r/1131324

gerritbot added a project: Patch-For-Review.Mar 26 2025, 1:49 PM
jgleeson closed this task as Invalid.Mar 26 2025, 1:51 PM
gerritbot added a comment.Mar 26 2025, 2:00 PM

Change #1131329 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/FundraiserLandingPage@master] [WIP] Instead of calling deprecated parserOptions(), parse content ourselves

https://gerrit.wikimedia.org/r/1131329

Jdforrester-WMF closed this task as a duplicate of T390032: PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Called from MediaWiki\Extension\FundraiserLandingPage\Specials\FundraiserLandingPage::execute].Mar 26 2025, 2:32 PM
cscott subscribed.Mar 26 2025, 2:35 PM

Another option is to use a strip marker for the "raw html", which is the usual way to smuggle "known safe" HTML into the output.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits