Page MenuHomePhabricator
Create Task
Maniphest T390141

Login from new device: Ensure login-fail-new has IP and user agent data
Closed, ResolvedPublic
Actions

Description

Summary

The logging code in LoginNotify does not record IP and user agent for login-fail-new events.

Technical notes

  • We need to modify LoginNotify.php#sendNotice to include the IP and user agent.

Acceptance criteria

  • login-fail-new messages in Logstash have IP and user agent.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
LoginNotify#sendNotice: Add IP and UA to log messagemediawiki/extensions/LoginNotifyREL1_43+12 -9
LoginNotify#sendNotice: Add IP and UA to log messagemediawiki/extensions/LoginNotifywmf/1.44.0-wmf.22+12 -9
LoginNotify#sendNotice: Add IP and UA to log messagemediawiki/extensions/LoginNotifymaster+12 -9
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.Mar 27 2025, 9:31 AM
Restricted Application added a project: Community-Tech. · View Herald TranscriptMar 27 2025, 9:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh claimed this task.Mar 27 2025, 10:19 AM
kostajh renamed this task from Login from new device: Ensure log message is generated regardless of confirmed email status to Login from new device: Ensure login-fail-new has IP and user agent data.Mar 27 2025, 10:44 AM
kostajh updated the task description. (Show Details)
gerritbot added a comment.Mar 27 2025, 10:49 AM

Change #1131667 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/LoginNotify@master] LoginNotify#sendNotice: Add IP and UA to log message

https://gerrit.wikimedia.org/r/1131667

gerritbot added a project: Patch-For-Review.Mar 27 2025, 10:49 AM
gerritbot added a comment.Mar 27 2025, 6:54 PM

Change #1131667 merged by jenkins-bot:

[mediawiki/extensions/LoginNotify@master] LoginNotify#sendNotice: Add IP and UA to log message

https://gerrit.wikimedia.org/r/1131667

kostajh mentioned this in rELGN0a22ef37fd69: LoginNotify#sendNotice: Add IP and UA to log message.Mar 27 2025, 6:55 PM
gerritbot added a comment.Mar 27 2025, 7:00 PM

Change #1131803 had a related patch set uploaded (by SBassett; author: Kosta Harlan):

[mediawiki/extensions/LoginNotify@wmf/1.44.0-wmf.22] LoginNotify#sendNotice: Add IP and UA to log message

https://gerrit.wikimedia.org/r/1131803

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Mar 27 2025, 7:00 PM
gerritbot added a comment.Mar 27 2025, 8:07 PM

Change #1131803 merged by jenkins-bot:

[mediawiki/extensions/LoginNotify@wmf/1.44.0-wmf.22] LoginNotify#sendNotice: Add IP and UA to log message

https://gerrit.wikimedia.org/r/1131803

Stashbot mentioned this in T390156: GlobalContributions: Expose data via the API.Mar 27 2025, 8:07 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-27T20:07:18Z] <sbassett@deploy1003> Started scap sync-world: Backport for [[gerrit:1131782|GlobalContributions: Add API query module (T390156)]], [[gerrit:1131803|LoginNotify#sendNotice: Add IP and UA to log message (T390141)]]

sbassett mentioned this in rELGN1248edec16a5: LoginNotify#sendNotice: Add IP and UA to log message.Mar 27 2025, 8:07 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 27 2025, 8:31 PM
Stashbot added a comment.Mar 27 2025, 8:39 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-27T20:39:53Z] <sbassett@deploy1003> Started scap sync-world: Backport for [[gerrit:1131803|LoginNotify#sendNotice: Add IP and UA to log message (T390141)]], [[gerrit:1131782|GlobalContributions: Add API query module (T390156)]]

gerritbot added a comment.Mar 27 2025, 8:40 PM

Change #1131813 had a related patch set uploaded (by Reedy; author: Kosta Harlan):

[mediawiki/extensions/LoginNotify@REL1_43] LoginNotify#sendNotice: Add IP and UA to log message

https://gerrit.wikimedia.org/r/1131813

gerritbot added a project: Patch-For-Review.Mar 27 2025, 8:40 PM
gerritbot added a comment.Mar 27 2025, 8:56 PM

Change #1131813 merged by jenkins-bot:

[mediawiki/extensions/LoginNotify@REL1_43] LoginNotify#sendNotice: Add IP and UA to log message

https://gerrit.wikimedia.org/r/1131813

Reedy mentioned this in rELGNb3c78b992ea0: LoginNotify#sendNotice: Add IP and UA to log message.Mar 27 2025, 8:57 PM
ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.22; 2025-03-25); removed MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Mar 27 2025, 9:01 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 27 2025, 9:30 PM
Reedy subscribed.Mar 30 2025, 11:22 AM

Related: T249408: Show useragent data and username on new device login emails

Reedy moved this task from Backlog to Features on the MediaWiki-extensions-LoginNotify board.Mar 30 2025, 11:22 AM
kostajh closed this task as Resolved.Nov 18 2025, 12:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits