Page MenuHomePhabricator
Create Task
Maniphest T390167

Avoid per-wiki topic configuration GENewcomerTasksOresTopicConfig
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

After tackling T386018 Growth engineers have considered that it does not make much sense to allow to configure topics per-wiki with GENewcomerTasksOresTopicConfig. Because there aren't real use-cases and because in T386018 a validation of topic ids/names against a different topic source in WikimediaMessages is applied. The decision to introduce GENewcomerTasksOresTopicConfig was made in T367576 to facilitate the adoption of CommunityConfiguration in GrowthExperiments. Now that T388227 is merged that's no longer a need.

Acceptance criteria (DRAFT: pending questions)

  • Remove GENewcomerTasksOresTopicConfig or refactor into something static, eg a constant and update consumers
  • DRAFT: Use the static topics as a fallback when WikimediaMessages is not available

Questions

  • Is the fallback even necessary?
    • How to deal with i18n if WM is not present, display the id?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ITopicRegistry: better method namingmediawiki/extensions/GrowthExperimentsmaster+36 -29
cleanup(GENewcomerTasksTopicType): sunset topic typesmediawiki/extensions/GrowthExperimentsmaster+8 -60
refactor: remove GENewcomerTasksOresTopicConfig in favor of a static collectionmediawiki/extensions/GrowthExperimentsmaster+655 -803
Customize query in gerrit

Related Objects
Search...

Event Timeline

Sgs created this task.Mar 27 2025, 12:19 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 27 2025, 12:19 PM
Sgs moved this task from Inbox to Maintenance on the Growth-Team board.Mar 27 2025, 12:46 PM
Sgs edited projects, added Growth-Team (Maintenance); removed Growth-Team.
Sgs added a subscriber: Michael.Mar 31 2025, 12:17 PM

After looking a bit into the required changes to keep a Growth internal collection of topics it seems a bit overdue. Historically GE has had validation for the GENewcomerTasksOresTopicConfig config data structure because it was editable by users, but that's no longer the case, so all data shape validation could/should be drop. The only valuable validation that's currently happening is checking the GE configured topic ids have an existing message associated so they can be displayed. This problem is introduced by having two sources of truth, however it is unlikely that Growth supports an extra ORES topic that wouldn't make sense to add to the ArticleTopicRegistry in WikimediaMessages. For that reason, I'm leaning towards the removal of GENewcomerTasksOresTopicConfig instead of keeping a fallback which would be unable to display the topic translations (because those depend on WM). What do you think @Michael?

Michael added a comment.Mar 31 2025, 1:22 PM

For me, using a static list of topics in GrowthExperiments as the primary source of truth makes sense in the opposite direction: Someone might add topics, or even entire topic groups, to WikimediaMessages that we do not want in Special:Homepage.

Sgs added a comment.Mar 31 2025, 3:27 PM

Per 1:1 discussion, we'd keep a Growth internal collection to act as an allow list over WM topic list to keep control over the topics displayed in the homepage.

Sgs moved this task from Maintenance to Estimated tasks backlog on the Growth-Team board.Mar 31 2025, 3:27 PM
Sgs edited projects, added Growth-Team; removed Growth-Team (Maintenance).
KStoller-WMF triaged this task as Medium priority.Mar 31 2025, 3:37 PM
KStoller-WMF set the point value for this task to 3.
Sgs claimed this task.Mar 31 2025, 4:31 PM
Sgs moved this task from Estimated tasks backlog to Current Sprint on the Growth-Team board.Apr 1 2025, 10:32 AM
Sgs edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
Sgs moved this task from Incoming to Doing on the Growth-Team (Current Sprint) board.
gerritbot added a comment.Apr 2 2025, 3:18 PM

Change #1132646 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] refactor: remove GENewcomerTasksOresTopicConfig in favor of a static collection

https://gerrit.wikimedia.org/r/1132646

gerritbot added a project: Patch-For-Review.Apr 2 2025, 3:18 PM
Sgs moved this task from Doing to Code Review on the Growth-Team (Current Sprint) board.Apr 3 2025, 11:12 AM
gerritbot added a comment.Apr 7 2025, 12:57 PM

Change #1134685 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] ITopicRegistry: better method naming

https://gerrit.wikimedia.org/r/1134685

gerritbot added a comment.Apr 23 2025, 11:22 AM

Change #1138315 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] [WIP] cleanup(GENewcomerTasksTopicType): sunset topic types

https://gerrit.wikimedia.org/r/1138315

gerritbot added a comment.Apr 23 2025, 12:38 PM

Change #1132646 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] refactor: remove GENewcomerTasksOresTopicConfig in favor of a static collection

https://gerrit.wikimedia.org/r/1132646

gerritbot added a comment.Apr 30 2025, 9:40 AM

Change #1138315 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] cleanup(GENewcomerTasksTopicType): sunset topic types

https://gerrit.wikimedia.org/r/1138315

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.28; 2025-05-06).Apr 30 2025, 10:00 AM
gerritbot added a comment.Jun 6 2025, 2:12 PM

Change #1134685 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ITopicRegistry: better method naming

https://gerrit.wikimedia.org/r/1134685

Sgs moved this task from Code Review to Test in Production on the Growth-Team (Current Sprint) board.Jun 6 2025, 2:14 PM

Moving to test in production since the main change is already there for weeks and the renaming change shouldn't be problematic.

Maintenance_bot removed a project: Patch-For-Review.Jun 6 2025, 2:31 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.5; 2025-06-10).Jun 6 2025, 3:00 PM
Etonkovidova closed this task as Resolved.Jul 1 2025, 9:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits