Turn off GeoCrumbsUseParserOutputFallback in production
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ABreault-WMF
	Mar 27 2025, 9:11 PM

Description

The GeoCrumbsUseParserOutputFallback config was added in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GeoCrumbs/+/1131465 when switching to use a page property.

@cscott had suggested,

https://global-search.toolforge.org/?q=%22%7B%7B%23isin%22&namespaces=&title= shows only 162 pages, it should be possible to make a null edit to those 162 pages (some of them are templates, this will also invalidate all the pages which include those templates) and then turn off the 'getExtensionData' mechanism.

Maybe you want to add a config variable for this fallback? Seems like you'd want to leave the fallback in for at least one MW release, but for WMF production we'd probably try to turn it off as quickly as possible.

in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GeoCrumbs/+/1131106/comment/109adf3b_58bdf33c/

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Change default value of GeoCrumbsUseParserOutputFallback	mediawiki/extensions/GeoCrumbs	master	+1 -1
	Turn off GeoCrumbsUseParserOutputFallback	operations/mediawiki-config	master	+5 -0

Customize query in gerrit

Related Objects

Mentioned In: T390985: #isin parser function (Geocrumbs) broken
Mentioned Here: T391128: Missing GeoCrumbs bread crumbs on wikivoyage

Event Timeline

ABreault-WMF created this task.Mar 27 2025, 9:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2025, 9:11 PM

ABreault-WMF moved this task from Backlog to In Progress on the Content-Transform-Team (Work In Progress) board.Mar 27 2025, 9:21 PM

RolandUnger mentioned this in T390985: #isin parser function (Geocrumbs) broken.Apr 3 2025, 3:29 PM

In T391128, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GeoCrumbs/+/1134260 was added to the fallback since a cache miss would mean we don't have old extension data and a reparse wouldn't refreshlinks.

Doing a null-edit to [[Template:IsIn]] didn't update the page properties on pages including it, as I would have expected.

MSantos added a project: Essential-Work.Apr 14 2025, 12:23 PM

MSantos moved this task from In Progress to Blocked on the Content-Transform-Team (Work In Progress) board.Apr 14 2025, 3:18 PM

cscott moved this task from Blocked to In Progress on the Content-Transform-Team (Work In Progress) board.Apr 14 2025, 3:18 PM

cscott moved this task from In Progress to Blocked on the Content-Transform-Team (Work In Progress) board.

ABreault-WMF triaged this task as Low priority.Jun 3 2025, 6:55 PM

cscott merged a task: T390985: #isin parser function (Geocrumbs) broken.Oct 30 2025, 5:04 AM

cscott added a subscriber: RolandUnger.

It seems like the page property is present / has been updated on all pages now, at least the ones I checked from https://global-search.toolforge.org/?q=%22%7B%7B%23isin%22&namespaces=&title=

Change #1200085 had a related patch set uploaded (by Arlolra; author: Arlolra):

[operations/mediawiki-config@master] Turn off GeoCrumbsUseParserOutputFallback

https://gerrit.wikimedia.org/r/1200085

gerritbot added a project: Patch-For-Review.Oct 30 2025, 2:55 PM

ABreault-WMF moved this task from Blocked to Code Review on the Content-Transform-Team (Work In Progress) board.Oct 30 2025, 2:55 PM

Change #1200085 merged by jenkins-bot:

[operations/mediawiki-config@master] Turn off GeoCrumbsUseParserOutputFallback

https://gerrit.wikimedia.org/r/1200085

Mentioned in SAL (#wikimedia-operations) [2025-10-30T20:04:54Z] <arlolra@deploy2002> Started scap sync-world: Backport for [[gerrit:1200085|Turn off GeoCrumbsUseParserOutputFallback (T390236)]]

Mentioned in SAL (#wikimedia-operations) [2025-10-30T20:07:08Z] <arlolra@deploy2002> arlolra: Backport for [[gerrit:1200085|Turn off GeoCrumbsUseParserOutputFallback (T390236)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-10-30T20:18:20Z] <arlolra@deploy2002> Finished scap sync-world: Backport for [[gerrit:1200085|Turn off GeoCrumbsUseParserOutputFallback (T390236)]] (duration: 13m 26s)

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2025, 8:31 PM

ABreault-WMF moved this task from Code Review to To Verify on the Content-Transform-Team (Work In Progress) board.Oct 30 2025, 8:32 PM

Change #1200166 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/GeoCrumbs@master] Change default value of GeoCrumbsUseParserOutputFallback

https://gerrit.wikimedia.org/r/1200166

gerritbot added a project: Patch-For-Review.Oct 30 2025, 8:36 PM

I purged a few of the pages from T391128 and the crumbs seemed fine

Change #1200166 merged by jenkins-bot: