Page MenuHomePhabricator

Simplify MobileFrontend's PageHTMLParser to support less content modes
Closed, ResolvedPublic3 Estimated Story Points

Description

Background

As we've moved towards Parsoid the PageHTMLParser has become more complex. In current form it caters for:

  1. $wgParserEnableLegacyHeadingDOM = true (WMF production with legacy parser)
  2. $wgParserEnableLegacyHeadingDOM = true; (third party support)
  3. $wgParserEnableLegacyHeadingDOM = false and Parsoid (WMF production with Parsoid enabled)
  4. Desktop HTML (used by <1% of logged in users who have switched to Minerva desktop as their preferred skin)

it's proposed to simplify this code so it only caters for 1 and 3.

This should also address the issues in page issues described in T388696.

User story

As a developer I want easier to maintain code

Requirements

  • PageHTMLParser code has been updated to reflect modern HTML (it is currently written for $wgParserEnableLegacyHeadingDOM = false)

BDD

  • For QA engineer to fill out

Test Steps

  • For QA engineer to fill out

Design

  • Add mockups and design requirements

Acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.2.0 of the Web team task template using phabulous

Event Timeline

Change #1131846 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] PageHTMLParser: Drop support for desktop HTML and legacy heading HTML

https://gerrit.wikimedia.org/r/1131846

Jdlrobson-WMF updated the task description. (Show Details)
Jdlrobson-WMF moved this task from Incoming to Q4 on the Web-Team board.
Jdlrobson-WMF changed the task status from Open to In Progress.Apr 3 2025, 6:42 PM
Jdlrobson-WMF set the point value for this task to 3.
Jdlrobson-WMF changed the task status from In Progress to Open.May 12 2025, 5:12 PM

Change #1131846 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] PageHTMLParser: Drop support for desktop HTML and legacy heading HTML

https://gerrit.wikimedia.org/r/1131846

Jdlrobson-WMF claimed this task.