The markup got out of sync over the many months since the appearance menu got started. With the upcoming changes for font modes this lead to line-height discrepancies relying on just a sub-par of classes for CdxRadio styling.
Make appearance radio buttons follow CdxRadio markup
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| clientPreferences: Make appearance buttons follow current Codex markup | mediawiki/skins/Vector | master | +10 -4 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Sarai-WMDE | T322383 TypeaheadSearch line-height, thumbnail size don't match Figma spec or each other | |||
| Open | None | T322384 Increase MenuItem / TypeaheadSearch line-height | |||
| Stalled | None | T372653 Font size setting should apply consistently across mobile and desktop | |||
| Open | BUG REPORT | None | T387983 Select dropdown for the "Reason" field in Codex Special:Block has text not in the center of the element | ||
| Resolved | DTorsani-WMF | T363845 [EPIC] Typography scale and font sizing | |||
| Resolved | AnneT | T386298 Font modes: Test revised Codex type scale and font modes | |||
| Resolved | Volker_E | T390246 Bring Vector's appearance menu radio markup in sync with latest CdxRadio |
Change #1131848 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/skins/Vector@master] clientPreferences: Make appearance radio buttons follow CdxRadio markup
Change #1131848 merged by jenkins-bot:
[mediawiki/skins/Vector@master] clientPreferences: Make appearance buttons follow current Codex markup