Page MenuHomePhabricator

'Done' Button improperly remains visible when no topic is selected
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

  • Navigate to the topic/collection selection screen
  • Select a topic/collection and notice the 'Done' button appears (correct behavior)
  • Complete the action by clicking the 'Done' button
  • Return to the topic/collection selection screen again
  • Observe that the 'Done' button is visible even though no topic is selected (incorrect behavior)

What happens?:
The 'Done' button remains visible on the topic/collection selection screen even when no topic is selected, but only after having previously selected a topic.

What should have happened instead?:
The 'Done' button should only be visible when a topic/collection is actively selected. After returning to the selection screen with no topic selected, the button should be hidden.

Screen Recording 2025-03-27 at 5.51.32 PM.gif (540×957 px, 3 MB)


Derived Requirement

Ensure that the #Done button is only visible on the topic/collection selection screen when a topic or collection is actively selected, and remains hidden when no selection is made, including after returning to the screen from a completed action.

Test Case 1: Ensure #Done button only appears when a topic/collection is selected

  1. Navigate to the topic/collection selection screen.
  2. Observe the state of the 'Done' button before making any selection.
  3. ✅❓❌⬜ AC1: Confirm that the 'Done' button is hidden when no topic or collection is selected.

Test Case 2: Ensure #Done button appears after selecting a topic/collection

  1. On the selection screen, select any topic or collection.
  2. ✅❓❌⬜ AC2: Confirm that the 'Done' button becomes visible after a selection is made.

Test Case 3: Ensure #Done button is hidden when returning with no active selection

  1. Select a topic/collection and click the 'Done' button to complete the action.
  2. Return to the topic/collection selection screen.
  3. Do not make any selection.
  4. ✅❓❌⬜ AC3: Confirm that the 'Done' button is hidden when the screen loads with no topic or collection selected.

QA Results - Test Wiki

ACStatusDetails
1T390261#10800863
2T390261#10800863
3T390261#10800863

Event Timeline

PWaigi-WMF moved this task from Needs Triage to Bugs on the ContentTranslation board.

Change #1138476 had a related patch set uploaded (by ToluAyo; author: ToluAyo):

[mediawiki/extensions/ContentTranslation@master] SXSuggestionsFiltersDialog: Fix Done button when no topic selected

https://gerrit.wikimedia.org/r/1138476

Change #1138476 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXSuggestionsFiltersDialog: Fix Done button when no topic selected

https://gerrit.wikimedia.org/r/1138476

Change #1139523 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 1.0.0+20250428

https://gerrit.wikimedia.org/r/1139523

Change #1139523 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 1.0.0+20250428

https://gerrit.wikimedia.org/r/1139523

@ToluAyo Confirmed that the 'Done' button is hidden when no topic or collection is selected and when returning with no active selection, but visible after a selection is made. I will move this to Sign-Off. Thanks for all your work!

Test Result - Test Wiki

Status: ✅ PASS
Environment: Test Wiki
OS: macOS Sequoia 15.4.1
Browser: Chrome 135
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure #Done button only appears when a topic/collection is selected

  1. Navigate to the topic/collection selection screen.
  2. Observe the state of the 'Done' button before making any selection.
  3. AC1: Confirm that the 'Done' button is hidden when no topic or collection is selected.
DesktopMobile
2025-05-06_12-04-12.mp4.gif (896×1 px, 2 MB)
2025-05-06_12-10-09.mp4.gif (658×986 px, 1 MB)

Test Case 2: Ensure #Done button appears after selecting a topic/collection

  1. On the selection screen, select any topic or collection.
  2. AC2: Confirm that the 'Done' button becomes visible after a selection is made.

See AC1

Test Case 3: Ensure #Done button is hidden when returning with no active selection

  1. Select a topic/collection and click the 'Done' button to complete the action.
  2. Return to the topic/collection selection screen.
  3. Do not make any selection.
  4. AC3: Confirm that the 'Done' button is hidden when the screen loads with no topic or collection selected.

See AC1

GMikesell-WMF updated Other Assignee, removed: GMikesell-WMF.
GMikesell-WMF moved this task from Needs QA to Design Signoff on the LPL Hypothesis board.