Page MenuHomePhabricator
Create Task
Maniphest T390344

v3 parserfunction serialization doesn't properly support named arguments
Closed, ResolvedPublic
Actions

Description

The hacky mechanism we use to renumber arguments for v3 serialization breaks if you use named arguments. I probably have to refactor the PEG grammar a bit to make this work properly: the argument after the colon should be passed as a separate token.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.23.0-a13mediawiki/vendormaster+23 K -24 K
Use new 'template3' token for `{{#...}}` constructsmediawiki/services/parsoidmaster+23 K -24 K
Bump wikimedia/parsoid to 0.23.0-a2mediawiki/vendormaster+2 K -1 K
Split first argument from target in parser function ParamInfomediawiki/services/parsoidmaster+261 -98
Customize query in gerrit

Related Objects
Search...

Event Timeline

cscott created this task.Mar 28 2025, 11:42 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMar 28 2025, 11:42 PM
SLopes-WMF moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Apr 3 2025, 2:24 PM
SLopes-WMF moved this task from Bugs & Crashers to Testing on the Parsoid board.
SLopes-WMF moved this task from Testing to Performance on the Parsoid board.
cscott added a parent task: T204307: Parser Functions should support named parameters.Apr 4 2025, 3:30 PM

T204307: Parser Functions should support named parameters is related.

Jdforrester-WMF subscribed.Apr 4 2025, 7:54 PM
gengh mentioned this in T391439: WikifunctionsPFragmentHandler: Make extractWikifunctionCallArguments ignore named arguments.Apr 9 2025, 9:30 AM
cscott removed a parent task: T268144: Add setFunctionHook equivalent support to Parsoid Extension API.Apr 11 2025, 5:10 PM
cscott added a parent task: T388786: Follow up from Parsoid Fragment support.
cscott mentioned this in T393306: Chart output makes VE support difficult.May 5 2025, 3:08 PM
gerritbot added a comment.May 9 2025, 11:24 PM

Change #1140966 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] WIP: new curly-brace tokenizer based on the preprocessor

https://gerrit.wikimedia.org/r/1140966

gerritbot added a project: Patch-For-Review.May 9 2025, 11:24 PM
gengh subscribed.May 16 2025, 1:35 PM
ssastry moved this task from Performance to Feature requests on the Parsoid board.May 22 2025, 6:00 PM
cscott mentioned this in T398488: PHP Warning: Undefined array key 4.Jul 2 2025, 7:42 PM
cscott merged a task: T398488: PHP Warning: Undefined array key 4.
cscott added a subscriber: ihurbain.
ABreault-WMF merged a task: T401407: PHP Warning: Undefined array key 4.Aug 7 2025, 3:11 PM
gerritbot added a comment.Sep 14 2025, 3:26 AM

Change #1187950 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] WIP: hook up new curly-brace tokenizer

https://gerrit.wikimedia.org/r/1187950

gerritbot added a comment.Sep 18 2025, 8:41 PM

Change #1187921 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Split first argument from target in parser function ParamInfo

https://gerrit.wikimedia.org/r/1187921

gerritbot added a comment.Oct 31 2025, 1:47 AM

Change #1187921 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Split first argument from target in parser function ParamInfo

https://gerrit.wikimedia.org/r/1187921

cscott closed subtask T393391: Refactor PEG grammar for transclusions as Resolved.Nov 3 2025, 4:14 PM
gerritbot added a comment.Nov 3 2025, 5:52 PM

Change #1201164 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a2

https://gerrit.wikimedia.org/r/1201164

gerritbot added a comment.Nov 3 2025, 6:30 PM

Change #1201164 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a2

https://gerrit.wikimedia.org/r/1201164

gerritbot added a comment.Jan 23 2026, 5:15 PM

Change #1187950 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Use new 'template3' token for `{{#...}}` constructs

https://gerrit.wikimedia.org/r/1187950

gerritbot added a comment.Jan 26 2026, 4:57 PM

Change #1233217 had a related patch set uploaded (by OSleger; author: OSleger):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a13

https://gerrit.wikimedia.org/r/1233217

gerritbot added a comment.Jan 26 2026, 6:33 PM

Change #1233217 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a13

https://gerrit.wikimedia.org/r/1233217

cscott closed this task as Resolved.Feb 9 2026, 6:43 PM
cscott claimed this task.

This is done, at least for parser function which use the {{#....}} form and are implemented as PFragmentHandlers.

Mr._Starfleet_Command subscribed.Feb 9 2026, 10:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits