Page MenuHomePhabricator

TypeaheadSearch: Thumbnail images not updating in some cases
Closed, ResolvedPublicBUG REPORT

Description

From @Michael:

There is a bug in Lookup/Typeahead search, that the thumbnails of results are not updating when typing more characters and thus loading new results. Is that known?
It can be reproduced on the Codex documentation with the "Search Wikipedia articles" example: https://doc.wikimedia.org/codex/latest/components/demos/typeahead-search.html#search-wikipedia-articles
And I can partially reproduce it on production enwiki: The actual search-box seems to be fine, but where we use that for CommunityConfiguration, for selecting an image from commons, there it is broken too: https://en.wikipedia.org/wiki/Special:CommunityConfiguration/CommunityUpdates (edited)

Event Timeline

Change #1132749 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[design/codex@main] Thumbnail: Ensure that prop updates trigger image change when necessary

https://gerrit.wikimedia.org/r/1132749

This is a pretty nasty bug that drastically reduces the effectiveness CommunityConfiguration image selector. Given that, and the fact that the solution is limited to the Thumbnail component's behavior when the thumbnail prop changes, I think we should get this bug fix in before tomorrow's release.

Change #1132749 merged by jenkins-bot:

[design/codex@main] Thumbnail: Ensure that prop updates trigger image change when necessary

https://gerrit.wikimedia.org/r/1132749

Change #1133258 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Update Codex from v1.21.1 to v1.22.0

https://gerrit.wikimedia.org/r/1133258

Test wiki created on Patch demo by Eric C Gardner using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/59d55f2723/w/

Change #1133258 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.21.1 to v1.22.0

https://gerrit.wikimedia.org/r/1133258

Test wiki on Patch demo by Eric C Gardner using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/59d55f2723/w/