Page MenuHomePhabricator
Create Task
Maniphest T390629

Wikimedia\Assert\UnreachableException: Trying to fetch node data without loading!
Open, Needs TriagePublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   Wikimedia\Assert\UnreachableException: Trying to fetch node data without loading!Node id: 63 Stored data: {"parsoid":{"stx":"simple","a":{"href":"./semaine"},"sa":{"href":"semaine"},"dsr":{"start":822,"end":833,"openWidth":2,"c
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.22/vendor/wikimedia/parsoid/src/Utils/DOMDataUtils.php(194)
#0/srv/mediawiki/php-1.44.0-wmf.22/vendor/wikimedia/parsoid/src/Utils/DOMDataUtils.php(1330)Wikimedia\Parsoid\Utils\DOMDataUtils::getNodeData(Wikimedia\Parsoid\DOM\Element)
#1/srv/mediawiki/php-1.44.0-wmf.22/vendor/wikimedia/parsoid/src/Utils/DOMDataUtils.php(713)Wikimedia\Parsoid\Utils\DOMDataUtils::storeRichAttributes(Wikimedia\Parsoid\DOM\Element, array)
#2/srv/mediawiki/php-1.44.0-wmf.22/vendor/wikimedia/parsoid/src/Utils/DOMUtils.php(84)Wikimedia\Parsoid\Utils\DOMDataUtils::storeDataAttribs(Wikimedia\Parsoid\DOM\Element, array)
#3/srv/mediawiki/php-1.44.0-wmf.22/vendor/wikimedia/parsoid/src/Utils/DOMUtils.php(88)Wikimedia\Parsoid\Utils\DOMUtils::visitDOM(Wikimedia\Parsoid\DOM\Element, array, array)
#4/srv/mediawiki/php-1.44.0-wmf.22/vendor/wikimedia/parsoid/src/Utils/DOMDataUtils.php(681)Wikimedia\Parsoid\Utils\DOMUtils::visitDOM(Wikimedia\Parsoid\DOM\Element, array, array)
#5/srv/mediawiki/php-1.44.0-wmf.22/vendor/wikimedia/parsoid/src/Core/DomPageBundle.php(263)Wikimedia\Parsoid\Utils\DOMDataUtils::visitAndStoreDataAttribs(Wikimedia\Parsoid\DOM\Element, array)
#6/srv/mediawiki/php-1.44.0-wmf.22/includes/OutputTransform/ContentDOMTransformStage.php(78)Wikimedia\Parsoid\Core\DomPageBundle::fromLoadedDocument(Wikimedia\Parsoid\DOM\Document, array)
#7/srv/mediawiki/php-1.44.0-wmf.22/includes/OutputTransform/ContentDOMTransformStage.php(33)MediaWiki\OutputTransform\ContentDOMTransformStage->parsoidTransform(MediaWiki\Parser\ParserOutput, MediaWiki\Parser\ParserOptions, array)
#8/srv/mediawiki/php-1.44.0-wmf.22/includes/OutputTransform/OutputTransformPipeline.php(80)MediaWiki\OutputTransform\ContentDOMTransformStage->transform(MediaWiki\Parser\ParserOutput, MediaWiki\Parser\ParserOptions, array)
#9/srv/mediawiki/php-1.44.0-wmf.22/includes/Output/OutputPage.php(2563)MediaWiki\OutputTransform\OutputTransformPipeline->run(MediaWiki\Parser\ParserOutput, MediaWiki\Parser\ParserOptions, array)
#10/srv/mediawiki/php-1.44.0-wmf.22/includes/Output/OutputPage.php(2645)MediaWiki\Output\OutputPage->getParserOutputText(MediaWiki\Parser\ParserOutput, MediaWiki\Parser\ParserOptions, array)
#11/srv/mediawiki/php-1.44.0-wmf.22/includes/page/Article.php(928)MediaWiki\Output\OutputPage->addParserOutput(MediaWiki\Parser\ParserOutput, MediaWiki\Parser\ParserOptions, array)
#12/srv/mediawiki/php-1.44.0-wmf.22/includes/page/Article.php(740)MediaWiki\Page\Article->doOutputFromParserCache(MediaWiki\Parser\ParserOutput, MediaWiki\Parser\ParserOptions, MediaWiki\Output\OutputPage, array)
#13/srv/mediawiki/php-1.44.0-wmf.22/includes/page/Article.php(552)MediaWiki\Page\Article->generateContentOutput(MediaWiki\User\User, MediaWiki\Parser\ParserOptions, int, MediaWiki\Output\OutputPage, array)
#14/srv/mediawiki/php-1.44.0-wmf.22/includes/actions/ViewAction.php(80)MediaWiki\Page\Article->view()
#15/srv/mediawiki/php-1.44.0-wmf.22/includes/actions/ActionEntryPoint.php(728)MediaWiki\Actions\ViewAction->show()
#16/srv/mediawiki/php-1.44.0-wmf.22/includes/actions/ActionEntryPoint.php(505)MediaWiki\Actions\ActionEntryPoint->performAction(MediaWiki\Page\Article, MediaWiki\Title\Title)
#17/srv/mediawiki/php-1.44.0-wmf.22/includes/actions/ActionEntryPoint.php(143)MediaWiki\Actions\ActionEntryPoint->performRequest()
#18/srv/mediawiki/php-1.44.0-wmf.22/includes/MediaWikiEntryPoint.php(202)MediaWiki\Actions\ActionEntryPoint->execute()
#19/srv/mediawiki/php-1.44.0-wmf.22/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#20/srv/mediawiki/w/index.php(3)require(string)
#21{main}
Impact
Notes

Probably related to T390628: Wikimedia\Assert\InvariantException: Invariant failed: Bogus nodeId given!

Details

Request URL
https://da.wiktionary.org/wiki/mercredi
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.22.0-a7mediawiki/vendormaster+975 -735
Don't hoist categories outside the <body> in the presence of bare <li>mediawiki/services/parsoidmaster+33 -0
Bump wikimedia/parsoid to 0.21.0-a24mediawiki/vendormaster+2 K -339
DOMDataUtils: Add a space to error messagemediawiki/services/parsoidREL1_43+1 -1
DOMDataUtils: Add a space to error messagemediawiki/services/parsoidREL1_42+1 -1
DOMDataUtils: Add a space to error messagemediawiki/services/parsoidREL1_39+1 -1
DOMDataUtils: Add a space to error messagemediawiki/services/parsoidmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Mar 31 2025, 9:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2025, 9:49 PM
gerritbot added a comment.Mar 31 2025, 9:49 PM

Change #1132770 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/services/parsoid@master] DOMDataUtils: Add a space to error message

https://gerrit.wikimedia.org/r/1132770

gerritbot added a project: Patch-For-Review.Mar 31 2025, 9:49 PM
Reedy moved this task from Untriaged to Mar 2025 on the Wikimedia-production-error board.Mar 31 2025, 10:47 PM
Krinkle moved this task from Mar 2025 to Jan-Mar 2025 on the Wikimedia-production-error board.Apr 1 2025, 2:05 AM
gerritbot added a comment.Apr 1 2025, 6:17 PM

Change #1132770 merged by jenkins-bot:

[mediawiki/services/parsoid@master] DOMDataUtils: Add a space to error message

https://gerrit.wikimedia.org/r/1132770

gerritbot added a comment.Apr 1 2025, 6:20 PM

Change #1133204 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/services/parsoid@REL1_43] DOMDataUtils: Add a space to error message

https://gerrit.wikimedia.org/r/1133204

gerritbot added a comment.Apr 1 2025, 6:20 PM

Change #1133205 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/services/parsoid@REL1_42] DOMDataUtils: Add a space to error message

https://gerrit.wikimedia.org/r/1133205

gerritbot added a comment.Apr 1 2025, 6:20 PM

Change #1133207 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/services/parsoid@REL1_39] DOMDataUtils: Add a space to error message

https://gerrit.wikimedia.org/r/1133207

gerritbot added a comment.Apr 1 2025, 6:54 PM

Change #1133207 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_39] DOMDataUtils: Add a space to error message

https://gerrit.wikimedia.org/r/1133207

gerritbot added a comment.Apr 1 2025, 7:56 PM

Change #1133205 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_42] DOMDataUtils: Add a space to error message

https://gerrit.wikimedia.org/r/1133205

gerritbot added a comment.Apr 1 2025, 8:03 PM

Change #1133204 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_43] DOMDataUtils: Add a space to error message

https://gerrit.wikimedia.org/r/1133204

Maintenance_bot removed a project: Patch-For-Review.Apr 1 2025, 8:30 PM
SLopes-WMF added a project: Content-Transform-Team (Work In Progress).Apr 3 2025, 2:19 PM
SLopes-WMF moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.
Reedy mentioned this in T391031: UnreachableException should be Normalized.Apr 3 2025, 6:53 PM
gerritbot added a comment.Apr 4 2025, 1:04 PM

Change #1134218 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.21.0-a24

https://gerrit.wikimedia.org/r/1134218

gerritbot added a project: Patch-For-Review.Apr 4 2025, 1:04 PM
gerritbot added a comment.Apr 4 2025, 1:26 PM

Change #1134218 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.21.0-a24

https://gerrit.wikimedia.org/r/1134218

Maintenance_bot removed a project: Patch-For-Review.Apr 4 2025, 1:30 PM
brennen subscribed.Apr 9 2025, 6:27 PM

Seeing this again in 1.44.0-wmf.24 (T386219).

labels.normalized_message
[{reqId}] {exception_url}   Wikimedia\Assert\UnreachableException: Trying to fetch node data without loading! Node id: 48 Stored data: {"parsoid":{"dsr":{"start":684,"end":701,"openWidth":1,"closeWidth":0,"leadingWS":1,"trailingWS":0}},"mw":{},"storedId":
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.24/vendor/wikimedia/parsoid/src/Utils/DOMDataUtils.php(198)
#0/srv/mediawiki/php-1.44.0-wmf.24/vendor/wikimedia/parsoid/src/Utils/DOMDataUtils.php(1342)Wikimedia\Parsoid\Utils\DOMDataUtils::getNodeData(Wikimedia\Parsoid\DOM\Element)
#1/srv/mediawiki/php-1.44.0-wmf.24/vendor/wikimedia/parsoid/src/Utils/DOMDataUtils.php(725)Wikimedia\Parsoid\Utils\DOMDataUtils::storeRichAttributes(Wikimedia\Parsoid\DOM\Element, array)
#2/srv/mediawiki/php-1.44.0-wmf.24/vendor/wikimedia/parsoid/src/Utils/DOMUtils.php(84)Wikimedia\Parsoid\Utils\DOMDataUtils::storeDataAttribs(Wikimedia\Parsoid\DOM\Element, array)
#3/srv/mediawiki/php-1.44.0-wmf.24/vendor/wikimedia/parsoid/src/Utils/DOMUtils.php(88)Wikimedia\Parsoid\Utils\DOMUtils::visitDOM(Wikimedia\Parsoid\DOM\Element, array, array)
#4/srv/mediawiki/php-1.44.0-wmf.24/vendor/wikimedia/parsoid/src/Utils/DOMDataUtils.php(693)Wikimedia\Parsoid\Utils\DOMUtils::visitDOM(Wikimedia\Parsoid\DOM\Element, array, array)
#5/srv/mediawiki/php-1.44.0-wmf.24/vendor/wikimedia/parsoid/src/Core/DomPageBundle.php(269)Wikimedia\Parsoid\Utils\DOMDataUtils::visitAndStoreDataAttribs(Wikimedia\Parsoid\DOM\Element, array)
#6/srv/mediawiki/php-1.44.0-wmf.24/includes/OutputTransform/ContentDOMTransformStage.php(78)Wikimedia\Parsoid\Core\DomPageBundle::fromLoadedDocument(Wikimedia\Parsoid\DOM\Document, array)
#7/srv/mediawiki/php-1.44.0-wmf.24/includes/OutputTransform/ContentDOMTransformStage.php(33)MediaWiki\OutputTransform\ContentDOMTransformStage->parsoidTransform(MediaWiki\Parser\ParserOutput, MediaWiki\Parser\ParserOptions, array)
#8/srv/mediawiki/php-1.44.0-wmf.24/includes/OutputTransform/OutputTransformPipeline.php(80)MediaWiki\OutputTransform\ContentDOMTransformStage->transform(MediaWiki\Parser\ParserOutput, MediaWiki\Parser\ParserOptions, array)
#9/srv/mediawiki/php-1.44.0-wmf.24/includes/Output/OutputPage.php(2564)MediaWiki\OutputTransform\OutputTransformPipeline->run(MediaWiki\Parser\ParserOutput, MediaWiki\Parser\ParserOptions, array)
#10/srv/mediawiki/php-1.44.0-wmf.24/includes/Output/OutputPage.php(2646)MediaWiki\Output\OutputPage->getParserOutputText(MediaWiki\Parser\ParserOutput, MediaWiki\Parser\ParserOptions, array)
#11/srv/mediawiki/php-1.44.0-wmf.24/includes/page/Article.php(928)MediaWiki\Output\OutputPage->addParserOutput(MediaWiki\Parser\ParserOutput, MediaWiki\Parser\ParserOptions, array)
#12/srv/mediawiki/php-1.44.0-wmf.24/includes/page/Article.php(740)MediaWiki\Page\Article->doOutputFromParserCache(MediaWiki\Parser\ParserOutput, MediaWiki\Parser\ParserOptions, MediaWiki\Output\OutputPage, array)
#13/srv/mediawiki/php-1.44.0-wmf.24/includes/page/Article.php(552)MediaWiki\Page\Article->generateContentOutput(MediaWiki\User\User, MediaWiki\Parser\ParserOptions, int, MediaWiki\Output\OutputPage, array)
#14/srv/mediawiki/php-1.44.0-wmf.24/includes/actions/ViewAction.php(80)MediaWiki\Page\Article->view()
#15/srv/mediawiki/php-1.44.0-wmf.24/includes/actions/ActionEntryPoint.php(728)MediaWiki\Actions\ViewAction->show()
#16/srv/mediawiki/php-1.44.0-wmf.24/includes/actions/ActionEntryPoint.php(505)MediaWiki\Actions\ActionEntryPoint->performAction(MediaWiki\Page\Article, MediaWiki\Title\Title)
#17/srv/mediawiki/php-1.44.0-wmf.24/includes/actions/ActionEntryPoint.php(143)MediaWiki\Actions\ActionEntryPoint->performRequest()
#18/srv/mediawiki/php-1.44.0-wmf.24/includes/MediaWikiEntryPoint.php(202)MediaWiki\Actions\ActionEntryPoint->execute()
#19/srv/mediawiki/php-1.44.0-wmf.24/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#20/srv/mediawiki/w/index.php(3)require(string)
#21{main}
Reedy added a comment.Apr 9 2025, 7:37 PM

Yeah, it’s not going to be fixed by my patch as I just fixed a spacing error in the error message as it annoyed me :)

thcipriani renamed this task from Wikimedia\Assert\UnreachableException: Trying to fetch node data without loading!Node id: 63 Stored data: {"parsoid":{"stx":"simple","a":{"href":"./semaine"},"sa":{"href":"semaine"},"dsr":{"start":822,"end":833,"openWidth":2,"c to Wikimedia\Assert\UnreachableException: Trying to fetch node data without loading!.Apr 10 2025, 4:01 PM
thcipriani subscribed.Apr 10 2025, 4:04 PM

Updated task title since this error is not very normalized.

Started with wmf/1.44.0-wmf.22 on 2025-03-26 when it rolled to group1 seems like it may be exclusive to dawiktionary

MSantos added a project: Essential-Work.Apr 14 2025, 12:19 PM
A_smart_kitten mentioned this in T392798: action=parse API is failing on `Robin_of_Sherwood` page of fi.wikipedia.org.May 21 2025, 5:59 PM
cscott subscribed.Jun 12 2025, 2:48 PM

Reproducible: https://da.wiktionary.org/wiki/mercredi?useparsoid=1 ; note that https://da.wiktionary.org/wiki/mercredi?useparsoid=0 is fine. Also running via the API of integrated modes on parsoidtest1001 is fine; this is a bug in the OutputTransform pipeline after Parsoid is done parsing.

cscott added a comment.Jun 12 2025, 2:56 PM

I can reproduce on parsoidtest1001:

$ sudo -u www-data php /srv/mediawiki/multiversion/MWScript.php view.php --wiki=dawiktionary mercredi > mercredi.wt
$ sudo -u www-data php /srv/mediawiki/multiversion/MWScript.php parse.php --wiki=dawiktionary -p < mercredi.wt

seems like I should add a --page option to core's parse.php to save a step here. regardless, now I have something to look at...

cscott added a comment.Jun 12 2025, 3:51 PM

Something is adding bogus HTML to the bottom of the document before the OutputTransform stages get started:

<!DOCTYPE html>
<html prefix="dc: http://purl.org/dc/terms/ mw: http://mediawiki.org/rdf/"><head prefix="mwr: https://da.wiktionary.org/wiki/Special:Redirect/"><meta charset="utf-8"/><meta property="mw:pageId" content="0"/><meta property="mw:pageNamespace" content="0"/>
...
</section></li></section></section></body>

<link rel="mw:PageProp/Category" href="./Kategori:Ugedage_på_fransk" data-object-id="63"/></html>

That post-body content is getting merged into the body by ExtractBody, and because it has a data-object-id attribute on it, it eventually "steals" the NodeData of a different legit node (which just happens to have ID 63) eventually causing the crash.

But where is that category tag coming from? I'm pretty sure the category name translates as "days of the week".

cscott added a comment.Jun 12 2025, 3:55 PM

This orphan tag shows up locally using the API as well, but you have to use body_only=false:

$ php bin/parse.php --domain da.wiktionary.org --page mercredi --wrapSections --body_only=false
...
</section></section></body>

<link rel="mw:PageProp/Category" href="./Kategori:Ugedage_på_fransk" data-object-id="63"/></html>

Curiouser and curiouser, but at least now I can reproduce locally.

gerritbot added a comment.Jun 12 2025, 8:52 PM

Change #1156448 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Don't hoist categories outside the <body> in the presence of bare <li>

https://gerrit.wikimedia.org/r/1156448

gerritbot added a project: Patch-For-Review.Jun 12 2025, 8:52 PM
gerritbot added a comment.Jun 13 2025, 2:31 AM

Change #1156448 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Don't hoist categories outside the <body> in the presence of bare <li>

https://gerrit.wikimedia.org/r/1156448

Maintenance_bot removed a project: Patch-For-Review.Jun 13 2025, 3:30 AM
gerritbot added a comment.Jun 16 2025, 4:38 PM

Change #1159531 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a7

https://gerrit.wikimedia.org/r/1159531

gerritbot added a project: Patch-For-Review.Jun 16 2025, 4:38 PM
gerritbot added a comment.Jun 16 2025, 6:57 PM

Change #1159531 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a7

https://gerrit.wikimedia.org/r/1159531

Maintenance_bot removed a project: Patch-For-Review.Jun 16 2025, 7:31 PM
cscott mentioned this in T398489: Wikimedia\Assert\UnreachableException: Trying to fetch node data without loading! Node id: 63 Stored data: {"parsoid":{"stx":"piped","a":{"href":"./jour"},"sa":{"href":"jour"},"dsr":{"start":779,"end":793,"openWidth":7,"closeWi.Jul 2 2025, 8:45 PM
cscott mentioned this in T390628: Wikimedia\Assert\InvariantException: Invariant failed: Bogus nodeId given!.
cscott merged a task: T390628: Wikimedia\Assert\InvariantException: Invariant failed: Bogus nodeId given!.Jul 2 2025, 8:54 PM
cscott merged a task: T398489: Wikimedia\Assert\UnreachableException: Trying to fetch node data without loading! Node id: 63 Stored data: {"parsoid":{"stx":"piped","a":{"href":"./jour"},"sa":{"href":"jour"},"dsr":{"start":779,"end":793,"openWidth":7,"closeWi.
cscott added subscribers: ssastry, ihurbain.

This is still causing some production errors due to bad content stuck in the ParserCache, but that should resolve itself with time.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits