Maniphest T39063

SquidPurgeClient hangs on response from Squid Cache 2.7, or multiple entries in $wgSquidServers
Open, LowPublic
Actions

Assigned To

None

Authored By

	• bzimport
	May 23 2012, 10:02 PM

Tags

Referenced Files

None

Subscribers

MarkAHershberger

Description

Author: jayhuggins

Description:
Squid Cache 2.7 returns a "Connection: close" header which SquidPurgeClient doesn't recognize or recover from appropriately, resulting in a semi-infinite loop in the SquidPurgeClientPool.run() function, loading the CPU until the loop breaks for a timeout. Besides the loading and slowing page edits, this bug also prevents some of the purge requests in the pool from being sent at all.

Also, SquirPurgeClientPool doesn't handle multiple squids (multiple entries in $wgSquidServers) because the indexing scheme for $readSockets and $writeSockets in SquidPurgeClientPool.run() is flattened by the socket_select function, and only the first server in the $wgSquidServers array actually receives the purge request. Again, SquidPurgeClientPool.run() enters a semi-infinite loop as a result, loading the CPU and causing page edits to be very slow in their response.

OS: Linux
Platform: Other

Details

Reference: bz37063

Related Objects

Mentioned Here: T264735: MultiHttpClient has hard-coded deprecated cURL option used by CdnCacheUpdate

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 12:29 AM

• bzimport added projects: Future-Release, MediaWiki-Page-editing.

• bzimport set Reference to bz37063.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.May 23 2012, 10:02 PM

jayhuggins wrote:

Note: we discovered this bug in MediaWiki 1.16 and verified it is still in the 1.20 code.

sumanah wrote:

Jay's patch: https://gerrit.wikimedia.org/r/#/c/8783/ . Thanks for the patch, Jay!

Lowering priority on high priority bugs that have a low severity

New change is https://gerrit.wikimedia.org/r/#/c/12243/

needs more work, won't make it into 1.20.0

matej_suchanek updated the task description. (Show Details)Jan 27 2016, 10:16 AM

matej_suchanek removed a project: Patch-For-Review.

matej_suchanek set Security to None.

matej_suchanek removed a subscriber: • wikibugs-l-list.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2016, 10:16 AM

• Phabricator_maintenance removed a project: Future-Release.Aug 12 2016, 4:54 PM

See also T264735: MultiHttpClient has hard-coded deprecated cURL option used by CdnCacheUpdate

hashar unsubscribed.Apr 28 2021, 9:07 AM

Krinkle edited projects, added MediaWiki-Core-HTTP-Cache; removed MediaWiki-libs-BagOStuff.Jan 22 2022, 11:16 PM