Page MenuHomePhabricator
Create Task
Maniphest T390642

Non-functional WikiLove icon showing on user pages on mobile
Closed, ResolvedPublicBUG REPORT
Actions

Description

Background: With T388909 we now show menu items in page actions which have icons. The WikiLove icon is now displaying but doesn't seem to be written in a way that works across all skins.

Steps to replicate the issue (include links if applicable):

What happens?:
Nothing.

What should have happened instead?:
The heart shouldn't be there as it doesn't work on Minerva.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Don't add WikiLove icon to MinervaMichael Großemediawiki/extensions/WikiLovewmf/1.44.0-wmf.23+8 -0
Don't add WikiLove icon to MinervaJdlrobsonmediawiki/extensions/WikiLovemaster+8 -0
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson-WMF created this task.Mar 31 2025, 11:50 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 31 2025, 11:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Mar 31 2025, 11:50 PM

Change #1132779 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikiLove@master] Don't add WikiLove icon to Minerva

https://gerrit.wikimedia.org/r/1132779

gerritbot added a project: Patch-For-Review.Mar 31 2025, 11:50 PM
Michael subscribed.Apr 1 2025, 2:29 PM
Michael edited projects, added: Growth-Team (Current Sprint); removed: Growth-Team.Apr 1 2025, 2:34 PM
Michael moved this task from Incoming to QA on the Growth-Team (Current Sprint) board.
gerritbot added a comment.Apr 1 2025, 6:34 PM

Change #1132779 merged by jenkins-bot:

[mediawiki/extensions/WikiLove@master] Don't add WikiLove icon to Minerva

https://gerrit.wikimedia.org/r/1132779

Jdlrobson-WMF added a comment.Apr 1 2025, 6:40 PM

Do we want to backport this or add a user notice so that people are aware of the bug for the next week?

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.24; 2025-04-08).Apr 1 2025, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 1 2025, 7:31 PM
Michael added a comment.Apr 1 2025, 7:54 PM
In T390642#10700713, @Jdlrobson-WMF wrote:

Do we want to backport this or add a user notice so that people are aware of the bug for the next week?

I'm backporting something else anyway, can also do this. Assuming there is a deployer present

gerritbot added a comment.Apr 1 2025, 7:54 PM

Change #1133232 had a related patch set uploaded (by Michael Große; author: Jdlrobson):

[mediawiki/extensions/WikiLove@wmf/1.44.0-wmf.23] Don't add WikiLove icon to Minerva

https://gerrit.wikimedia.org/r/1133232

gerritbot added a project: Patch-For-Review.Apr 1 2025, 7:54 PM
gerritbot added a comment.Apr 1 2025, 8:29 PM

Change #1133232 merged by jenkins-bot:

[mediawiki/extensions/WikiLove@wmf/1.44.0-wmf.23] Don't add WikiLove icon to Minerva

https://gerrit.wikimedia.org/r/1133232

Stashbot added a comment.Apr 1 2025, 8:29 PM

Mentioned in SAL (#wikimedia-operations) [2025-04-01T20:29:58Z] <taavi@deploy1003> Started scap sync-world: Backport for [[gerrit:1133157|homepage: Add homepage_transfersize_bytes_total metric (T382003)]], [[gerrit:1133158|homepage: Add homepage_transfersize_bytes_total metric (T382003)]], [[gerrit:1133232|Don't add WikiLove icon to Minerva (T390642)]]

Stashbot mentioned this in T382003: (mw.track) Migrate timing.growthExperiments.* to statslib.Apr 1 2025, 8:30 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 1 2025, 8:30 PM
Jdlrobson subscribed.Apr 1 2025, 8:36 PM

Thanks @Michael!

Stashbot added a comment.Apr 1 2025, 8:37 PM

Mentioned in SAL (#wikimedia-operations) [2025-04-01T20:37:19Z] <taavi@deploy1003> migr, taavi: Backport for [[gerrit:1133157|homepage: Add homepage_transfersize_bytes_total metric (T382003)]], [[gerrit:1133158|homepage: Add homepage_transfersize_bytes_total metric (T382003)]], [[gerrit:1133232|Don't add WikiLove icon to Minerva (T390642)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Apr 1 2025, 8:46 PM

Mentioned in SAL (#wikimedia-operations) [2025-04-01T20:46:57Z] <taavi@deploy1003> Finished scap sync-world: Backport for [[gerrit:1133157|homepage: Add homepage_transfersize_bytes_total metric (T382003)]], [[gerrit:1133158|homepage: Add homepage_transfersize_bytes_total metric (T382003)]], [[gerrit:1133232|Don't add WikiLove icon to Minerva (T390642)]] (duration: 16m 59s)

ReleaseTaggerBot edited projects, added: MW-1.44-notes (1.44.0-wmf.23; 2025-04-01); removed: MW-1.44-notes (1.44.0-wmf.24; 2025-04-08).Apr 1 2025, 9:00 PM
Etonkovidova moved this task from QA to Test in Production on the Growth-Team (Current Sprint) board.Apr 1 2025, 11:28 PM
Etonkovidova subscribed.

Checked in beta

  • the heart icon is not present anymore in Minerva
  • the general functionality of Wikilove works as before, i.e
    • a user can see the icon and send Wikilove messages from desktop (and only from desktop)
    • a user on mobile can see received Wikilove messages on their Discussion page and can see Echo notification

Screen Shot 2025-04-01 at 4.28.07 PM.png (774×1,648 px, 199 KB)

  • the preference for enabling/disabling Wikilove in Special:Preferences#mw-prefsection-editing is present on mobile
Etonkovidova closed this task as Resolved.Apr 3 2025, 4:11 PM
Etonkovidova claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits