📄 Validate pagination query params
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jakob_WMDE
	Apr 1 2025, 12:10 PM

Description

validation: limit needs to be a number between 1 and 500; offset needs to be a number >=0
- rely on the REST framework's request parameter validation for type check
- do validation of the parameter's range inside the use case, using the validator
- 400 error response:

{
  "code": "invalid-query-parameter",
  "message": "Invalid query parameter: 'limit'",
  "context": {
    "parameter": "limit"
  }
}

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Search: Validate pagination query params for `SimplePropertySearch`	mediawiki/extensions/Wikibase	master	+103 -8
	Search: Validate pagination query params for `SimpleItemSearch`	mediawiki/extensions/Wikibase	master	+119 -21

Status	Assigned	Task
Resolved	Ifrahkhanyaree_WMDE	T383126 [EPIC] Simple search
Resolved	Ollie.Shotton_WMDE	T389013 📄 Paginate simple search results
Resolved	Dima_Koushha_WMDE	T390694 📄 Validate pagination query params

Change #1135959 had a related patch set uploaded (by Dima koushha; author: Dima koushha):

[mediawiki/extensions/Wikibase@master] Search: Validate pagination query params for `SimpleItemSearc`

Change #1135980 had a related patch set uploaded (by Dima koushha; author: Dima koushha):

[mediawiki/extensions/Wikibase@master] Search: Validate pagination query params for `SimplePropertySearch`

Change #1135959 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Search: Validate pagination query params for `SimpleItemSearch`

Change #1135980 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Search: Validate pagination query params for `SimplePropertySearch`