Page MenuHomePhabricator
Create Task
Maniphest T390696

Branch REL1_44 for MediaWiki and all extensions and skins
Closed, ResolvedPublic
Actions

Description

  1. ./branch.py REL1_44 --bundle base --branchpoint master (branch tarball extensions and skins)
  2. ./branch.py REL1_44 --core --branchpoint a069027d42574d48fc095ea21e74c533c9dc1b8e --core-version 1.44.0-beta --task T390696 (branch MW itself and make a sub-module commit)
  3. ./branch.py REL1_44 --bundle '*' --branchpoint master --core-version 1.44.0 (branch all other extensions and skins)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Restore SecureLinkFixermediawiki/coreREL1_44+5 -0
Drop Wikimedia production-only code from the REL1_44 releasemediawiki/coreREL1_44+4 -824
Prepare active branch following REL1_44 cut, labelling as 1.45-alphamediawiki/coremaster+151 -5
Branch commit for REL1_44mediawiki/coreREL1_44+63 -58
Customize query in gerrit

Related Objects
Search...

Event Timeline

Atieno created this task.Apr 1 2025, 12:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2025, 12:15 PM
Atieno added a parent task: T390686: Release MediaWiki 1.44.0.Apr 1 2025, 12:15 PM
Atieno moved this task from Blocker to Process on the MW-1.44-release board.Apr 1 2025, 12:21 PM
Jdforrester-WMF updated the task description. (Show Details)May 6 2025, 8:57 AM
A_smart_kitten subscribed.May 6 2025, 9:10 AM

Should REL1_43 in the task description be REL1_44?

Jdforrester-WMF updated the task description. (Show Details)May 6 2025, 11:54 AM
Jdforrester-WMF updated the task description. (Show Details)May 6 2025, 3:48 PM
MSantos changed the task status from Open to In Progress.May 6 2025, 3:52 PM
MSantos triaged this task as High priority.
gerritbot added a comment.May 6 2025, 4:00 PM

Change #1142630 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@REL1_44] Branch commit for REL1_44

https://gerrit.wikimedia.org/r/1142630

gerritbot added a project: Patch-For-Review.May 6 2025, 4:01 PM
MSantos subscribed.May 6 2025, 4:17 PM

I wonder if the script could support in the future the following call:

./branch.py REL1_44 --bundle base --branchpoint refs/heads/wmf/1.44.0-wmf.28

or, assuming not all extensions will have the refs/heads/wmf/1.44.0-wmf.28 branch

./branch.py REL1_44 --bundle base --branchpoint refs/heads/wmf/1.44.0-wmf.*
gerritbot added a comment.May 6 2025, 4:34 PM

Change #1142630 merged by jenkins-bot:

[mediawiki/core@REL1_44] Branch commit for REL1_44

https://gerrit.wikimedia.org/r/1142630

ABreault-WMF closed this task as Resolved.May 6 2025, 4:37 PM
ABreault-WMF claimed this task.
A_smart_kitten added a comment.May 6 2025, 4:50 PM

Probably a stupid question, but just to check, is it an issue that the REL1_44 branch has a lot more submodules (including Wikimedia-specific extensions) than the REL1_43 branch? E.g. comparing https://github.com/wikimedia/mediawiki/tree/REL1_44/extensions to https://github.com/wikimedia/mediawiki/tree/REL1_43/extensions

Jdforrester-WMF subscribed.May 6 2025, 4:55 PM
In T390696#10796991, @A_smart_kitten wrote:

Probably a stupid question, but just to check, is it an issue that the REL1_44 branch has a lot more submodules (including Wikimedia-specific extensions) than the REL1_43 branch? E.g. comparing https://github.com/wikimedia/mediawiki/tree/REL1_44/extensions to https://github.com/wikimedia/mediawiki/tree/REL1_43/extensions

Yes, it looks like the branch was from the tip of the 1.44.0-wmf.28 branch rather than master, which is incorrect and has pulled in a bunch of extensions and skins that it shouldn't have?

gerritbot added a comment.May 6 2025, 4:55 PM

Change #1142637 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] Prepare active branch following REL1_44 cut, labelling as 1.45-alpha

https://gerrit.wikimedia.org/r/1142637

PatchDemoBot added a comment.May 6 2025, 4:58 PM

Test wiki created on Patch demo by usuario using patch(es) linked to this task:
https://pd.erebor.com/wikis/bb7c173a07/w/

PatchDemoBot added a comment.May 6 2025, 5:07 PM

Test wiki on Patch demo by usuario using patch(es) linked to this task was deleted:

https://pd.erebor.com/wikis/bb7c173a07/w/

Aklapper mentioned this in T393494: PatchDemoBot linked to non-existing URI pd.erebor.com.May 6 2025, 5:09 PM
gerritbot added a comment.May 6 2025, 5:24 PM

Change #1142645 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@REL1_44] Drop Wikimedia production-only code from the REL1_44 release

https://gerrit.wikimedia.org/r/1142645

ABreault-WMF added a comment.May 6 2025, 5:49 PM
In T390696#10797009, @Jdforrester-WMF wrote:
In T390696#10796991, @A_smart_kitten wrote:

Probably a stupid question, but just to check, is it an issue that the REL1_44 branch has a lot more submodules (including Wikimedia-specific extensions) than the REL1_43 branch? E.g. comparing https://github.com/wikimedia/mediawiki/tree/REL1_44/extensions to https://github.com/wikimedia/mediawiki/tree/REL1_43/extensions

Yes, it looks like the branch was from the tip of the 1.44.0-wmf.28 branch rather than master, which is incorrect and has pulled in a bunch of extensions and skins that it shouldn't have?

Is that a result of --branchpoint a069027d42574d48fc095ea21e74c533c9dc1b8e instead of --branchpoint master?

Jdforrester-WMF added a comment.May 6 2025, 5:54 PM
In T390696#10797297, @ABreault-WMF wrote:
In T390696#10797009, @Jdforrester-WMF wrote:
In T390696#10796991, @A_smart_kitten wrote:

Probably a stupid question, but just to check, is it an issue that the REL1_44 branch has a lot more submodules (including Wikimedia-specific extensions) than the REL1_43 branch? E.g. comparing https://github.com/wikimedia/mediawiki/tree/REL1_44/extensions to https://github.com/wikimedia/mediawiki/tree/REL1_43/extensions

Yes, it looks like the branch was from the tip of the 1.44.0-wmf.28 branch rather than master, which is incorrect and has pulled in a bunch of extensions and skins that it shouldn't have?

Is that a result of --branchpoint a069027d42574d48fc095ea21e74c533c9dc1b8e instead of --branchpoint master?

Yes, this was my fault. I should have specified the parent of a069027d42574d48fc095ea21e74c533c9dc1b8e, which is d4283b99aa40c4726f9ec2dc0a033bf30628eeee. Sorry!

gerritbot added a comment.May 6 2025, 6:04 PM

Change #1142645 merged by jenkins-bot:

[mediawiki/core@REL1_44] Drop Wikimedia production-only code from the REL1_44 release

https://gerrit.wikimedia.org/r/1142645

gerritbot added a comment.May 6 2025, 6:59 PM

Change #1142637 merged by jenkins-bot:

[mediawiki/core@master] Prepare active branch following REL1_44 cut, labelling as 1.45-alpha

https://gerrit.wikimedia.org/r/1142637

Maintenance_bot removed a project: Patch-For-Review.May 6 2025, 7:31 PM
gerritbot added a comment.May 6 2025, 7:50 PM

Change #1142676 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@REL1_44] Restore SecureLinkFixer

https://gerrit.wikimedia.org/r/1142676

gerritbot added a project: Patch-For-Review.May 6 2025, 7:50 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.1; 2025-05-13).May 6 2025, 8:00 PM
gerritbot added a comment.May 6 2025, 9:29 PM

Change #1142676 merged by jenkins-bot:

[mediawiki/core@REL1_44] Restore SecureLinkFixer

https://gerrit.wikimedia.org/r/1142676

Maintenance_bot removed a project: Patch-For-Review.May 6 2025, 9:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits