Page MenuHomePhabricator

Improve the TempUserIPLookup->getMostRecentAddress query
Closed, ResolvedPublic

Description

As part of the work for T380221: Allow authorised users to see IP Info for actors if the IP exists in the CheckUser or AbuseFilter tables, or has contributions, I1a38fb97051febb5c3569b2d3f4af82e5d060c0b introduced a new query, getMostRecentAddress. This query could possibly be optimized but was not a blocker, as the query was optimized enough. These proposed updates are noted in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/1120559. We should evaluate and see if these optimizations should be implemented.

Event Timeline

I forgot to update the commit message with this phab ref. This patch resolves this task.

I see the patch linked in the previous comment was already merged, as well as other patches tagged with add-cf-af-ip-lookup. Shall this be moved for QA?

Tchanders subscribed.

I think we can just move it to Done.