| Samwalton9 | |
| Apr 2 2025, 8:04 AM |
| F58965574: Screenshot 2025-04-02 at 10.16.29.png | |
| Apr 2 2025, 8:18 AM |
| F58965566: image.png | |
| Apr 2 2025, 8:06 AM |
User Svartava used Nuke on an IP address (see example log at https://meta.wikimedia.org/w/index.php?title=Special:Log&logid=59338121) on Meta, where temporary accounts are not currently deployed. This seems to have resulted in an edit summary referencing temporary accounts, which should not be the case.
If a wiki isn't using temporary accounts, the same edit summary used for accounts should be used, as I believe was the case prior to adding temporary accounts support to Nuke.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix edit summary referencing temp accounts | mediawiki/extensions/Nuke | master | +5 -3 |
I went to test this on en.wiki and couldn't reproduce - entering my IPv6 after creating a test page resulted in the standard message.
I can reproduce the error on meta. Perhaps it's because temporary accounts are "known" on meta, even though they are not enabled (T376132), while they are neither enabled nor known on enwiki?
Change #1139579 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):
[mediawiki/extensions/Nuke@master] Fix edit summary referencing temp accounts
Change #1139579 merged by jenkins-bot:
[mediawiki/extensions/Nuke@master] Fix edit summary referencing temp accounts
It's worth pointing out that in the ticket that was merged I also reported the separate bug that you have to accept the temporary account agreement to nuke legacy IP edits. It looks like that patch is at a high enough level of abstraction it should fix that too, though.
@Pppery and @Johannnes89, can you confirm that this no longer happens on Meta when Nuking pages?
for reference, meta is the only wiki with
$wgAutoCreateTempUser['enabled'] = true; $wgAutoCreateTempUser['known'] = false;
which is controlled by $wmgDisableIPMasking
The edit summary is correct now.
I didn't check the related bug about having to accept the temporary account agreement to nuke legacy IP edits, because my account (as a steward) is not required to accept it.