Page MenuHomePhabricator

Allow IP viewer temporary account group to be manually granted on all projects
Closed, ResolvedPublic

Description

Motivation

As discussed in the team meeting, we want to enable the temporary account viewer group on all projects to prepare for upcoming deployments. This will enable projects to prepare ahead for upcoming deployments and proactively grant the group to users who are deemed eligible.

Acceptance criteria
  • Temporary account viewer group can be granted on all projects

Event Timeline

Dreamy_Jazz renamed this task from Enable IP viewer temporary account right on all projects to Enable IP viewer temporary account group on all projects.Apr 23 2025, 3:53 PM
Dreamy_Jazz claimed this task.
Dreamy_Jazz updated the task description. (Show Details)

Change #1138403 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] Enable temporary-account-viewer group on all WMF production wikis

https://gerrit.wikimedia.org/r/1138403

Change #1138403 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable temporary-account-viewer group on all WMF production wikis

https://gerrit.wikimedia.org/r/1138403

Mentioned in SAL (#wikimedia-operations) [2025-04-23T16:06:59Z] <dreamyjazz@deploy1003> Started scap sync-world: Backport for [[gerrit:1138403|Enable temporary-account-viewer group on all WMF production wikis (T390942 T387205)]]

Mentioned in SAL (#wikimedia-operations) [2025-04-23T16:10:41Z] <dreamyjazz@deploy1003> dreamyjazz: Backport for [[gerrit:1138403|Enable temporary-account-viewer group on all WMF production wikis (T390942 T387205)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-04-23T16:16:38Z] <dreamyjazz@deploy1003> Started scap sync-world: Backport for [[gerrit:1138403|Enable temporary-account-viewer group on all WMF production wikis (T390942 T387205)]]

Mentioned in SAL (#wikimedia-operations) [2025-04-23T16:21:07Z] <dreamyjazz@deploy1003> dreamyjazz: Backport for [[gerrit:1138403|Enable temporary-account-viewer group on all WMF production wikis (T390942 T387205)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-04-23T16:27:49Z] <dreamyjazz@deploy1003> Finished scap sync-world: Backport for [[gerrit:1138403|Enable temporary-account-viewer group on all WMF production wikis (T390942 T387205)]] (duration: 11m 11s)

We need to wait for https://foundation.wikimedia.org/wiki/Policy:Wikimedia_Access_to_Temporary_Account_IP_Addresses_Policy#Patrollers_and_other_users to be updated to specify which users can grant the temporary-account-viewer group. I've done the first step which is to enable the group on all wikis, but we still use the automatic promotion mechanism so can't let it be manually granted just yet.

Dreamy_Jazz renamed this task from Enable IP viewer temporary account group on all projects to Allow IP viewer temporary account group to be manually granted on all projects.Apr 23 2025, 5:04 PM

We need to wait for https://foundation.wikimedia.org/wiki/Policy:Wikimedia_Access_to_Temporary_Account_IP_Addresses_Policy#Patrollers_and_other_users to be updated to specify which users can grant the temporary-account-viewer group.

The policy has been updated ("local administrators and Stewards")

Strictly, what is required:

  • Sysops can not assign ineligible user ip viewer right
  • Stewards can assign ineligible user ip viewer right

where eligible means 6 months + 300 edits.

Strictly, what is required:

  • Sysops can not assign ineligible user ip viewer right
  • Stewards can assign ineligible user ip viewer right

where eligible means 6 months + 300 edits.

Also something to be considered is if a user is vanished or blocked as sock, local sysop probably should be able to remove user from ip viewer group, even if such user is otherwise ineligible to get such group by sysops (i.e. does not meet 6 month+300 edits so ip viewer can only be granted by stewards).

Strictly, what is required:

  • Sysops can not assign ineligible user ip viewer right
  • Stewards can assign ineligible user ip viewer right

where eligible means 6 months + 300 edits.

Also something to be considered is if a user is vanished or blocked as sock, local sysop probably should be able to remove user from ip viewer group, even if such user is otherwise ineligible to get such group by sysops (i.e. does not meet 6 month+300 edits so ip viewer can only be granted by stewards).

This should be handled in T393615.

For this task, we can allow sysops and stewards to grant and remove the temporary-account-viewer group - @Niharika Could you confirm this is correct?

T393615 will prevent sysops from adding the group to particular users who don't meet the criteria, but will allow them to remove it.

Change #1149699 had a related patch set uploaded (by Tchanders; author: Tchanders):

[operations/mediawiki-config@master] Temp accounts: Allow sysop/steward to grant and revoke IP reveal

https://gerrit.wikimedia.org/r/1149699

Change #1149699 merged by jenkins-bot:

[operations/mediawiki-config@master] Temp accounts: Allow sysop to grant and revoke IP reveal

https://gerrit.wikimedia.org/r/1149699

Mentioned in SAL (#wikimedia-operations) [2025-05-27T14:05:20Z] <mszabo@deploy1003> Started scap sync-world: Backport for [[gerrit:1149699|Temp accounts: Allow sysop to grant and revoke IP reveal (T390942)]]

Change #1151220 had a related patch set uploaded (by Tchanders; author: Tchanders):

[operations/mediawiki-config@master] Temp accounts: Remove temporary-account-viewer from labs config

https://gerrit.wikimedia.org/r/1151220

Mentioned in SAL (#wikimedia-operations) [2025-05-27T14:07:32Z] <mszabo@deploy1003> mszabo, tchanders: Backport for [[gerrit:1149699|Temp accounts: Allow sysop to grant and revoke IP reveal (T390942)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-05-27T14:17:21Z] <mszabo@deploy1003> Finished scap sync-world: Backport for [[gerrit:1149699|Temp accounts: Allow sysop to grant and revoke IP reveal (T390942)]] (duration: 12m 00s)

Change #1151220 abandoned by Tchanders:

[operations/mediawiki-config@master] Temp accounts: Remove temporary-account-viewer from labs config

Reason:

No needed (see e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Special:ListGroupRights)

https://gerrit.wikimedia.org/r/1151220

I think we can consider this done - the engineers checked that: