Page MenuHomePhabricator
Create Task
Maniphest T390969

Port EventBus PageChangeHooks to Domain Events
Closed, DuplicatePublic20 Estimated Story Points
Actions

Description

Currently EventBus uses the hooks API for sending mediawiki/page/change events
that represent changes to the current state of how a MediaWiki Page
looks to a non-logged-in / anonymous / public user.

We should refactor the use of hooks and adopt the new Domain Events API instead.

This means replacing the PageChangeHooks implementation with their respective event listeners:
PageSaveCompleteHook.

AC:

Not that at the time of writing not all hooks have been implemented (2025-04)

  • PageSaveCompleteHook has been replaced with PageRevisionUpdatedEvent
  • PageMoveCompleteHook has been replaced with PageMovedEvent
  • PageDeleteCompleteHook has been replaced with PageDeletedEvent
  • PageUndeleteCompleteHook has been replaced with ...
  • PageDeleteHook has been replaced with PageDeletedEvent
  • ArticleRevisionVisibilitySetHook has been replaced with {}.

Things to keep in mind (input from @daniel ):

  • We don't need and EventIngress class per listener, but a generic one for all page state changes (PageStateIngress?)
  • we might need to share code between hooks and listeners. This will require some ad hoc service wiring. Growth's implementation has examples we can piggyback on
  • ImportableOldRevisionImporter could give some inspiration on how to implement an integration test strategy

Event Timeline

gmodena created this task.Apr 3 2025, 1:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 3 2025, 1:43 PM
Maintenance_bot added a project: Data-Engineering.Apr 3 2025, 2:30 PM
Ottomata subscribed.Apr 4 2025, 1:57 AM
Ottomata added a comment.Apr 4 2025, 2:01 AM

We don't need and EventIngress class per listener, but a generic one for all page state changes (PageStateIngress?)

We had the same sentiment when we refactored EventBusHooks into the per-purpose/stream hook handlers...for which we got around to making one of: PageChangeHooks. Could this then be called PageChangeEventIngress ? Or something like that? An EventIngress class who's purpose it is is to emit mediawiki.page_change.v1 events?

gmodena updated the task description. (Show Details)Apr 4 2025, 11:35 AM
gmodena added a comment.Apr 4 2025, 11:43 AM
In T390969#10711423, @Ottomata wrote:

We don't need and EventIngress class per listener, but a generic one for all page state changes (PageStateIngress?)

We had the same sentiment when we refactored EventBusHooks into the per-purpose/stream hook handlers...for which we got around to making one of: PageChangeHooks. Could this then be called PageChangeEventIngress ? Or something like that? An EventIngress class who's purpose it is is to emit mediawiki.page_change.v1 events?

Ack. It seems reasonable to have naming that reflects the intention to handle mediawiki.page_change.v1 events.

Ahoelzl edited projects, added Data-Engineering (Q4 2025 April 1st - June 30th); removed Data-Engineering.Apr 4 2025, 8:42 PM
Ahoelzl set the point value for this task to 20.
gmodena removed a subtask: T390970: EventBus: replace PageSaveCompleteHook with PageRevisionUpdateListener.Apr 8 2025, 2:03 PM
gmodena closed this task as a duplicate of T391254: Hypothesis 5.2.13: EventBus Adoption of Domain Events.Apr 8 2025, 2:17 PM
tchin subscribed.Apr 10 2025, 2:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits