Page MenuHomePhabricator
Create Task
Maniphest T390970

EventBus: replace PageSaveCompleteHook with PageRevisionUpdateListener
Closed, ResolvedPublic
Actions

Description

This task introduces basic support for the Domain Events API in EventBus.

AC:

  • PageSaveCompleteHook has been replaced with with PageRevisionUpdateListener

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
page_change: remove PageSaveCompleteHookmediawiki/extensions/EventBusmaster+77 -599
PageChangeEventIngress: handle file uploadmediawiki/extensions/EventBusmaster+2 -1
adopt PageRevisionUpdated domain eventmediawiki/extensions/EventBusmaster+674 -41
add integration tests for mediawiki.page_change.v1mediawiki/extensions/EventBusmaster+155 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

gmodena created this task.Apr 3 2025, 1:51 PM
Maintenance_bot added a project: Data-Engineering.Apr 3 2025, 2:30 PM
gmodena edited parent tasks, added: T391254: Hypothesis 5.2.13: EventBus Adoption of Domain Events; removed: T390969: Port EventBus PageChangeHooks to Domain Events.Apr 8 2025, 2:03 PM
gmodena edited projects, added Data-Engineering (Q4 2025 April 1st - June 30th); removed Data-Engineering.Apr 8 2025, 2:07 PM
gmodena moved this task from Next Up to In progress on the Data-Engineering (Q4 2025 April 1st - June 30th) board.
gmodena added a subscriber: daniel.Apr 8 2025, 2:19 PM

Things to keep in mind (input from @daniel ) re parent task:

  • We don't need and EventIngress class per listener, but a generic one for all page state changes (PageStateIngress?)
  • We might need to share code between hooks and listeners. This will require some ad hoc service wiring. Growth's implementation has examples we can piggyback on
  • ImportableOldRevisionImporter could give some inspiration on how to implement an integration test strategy
gerritbot added a comment.Apr 10 2025, 1:22 PM

Change #1135720 had a related patch set uploaded (by Gmodena; author: Gmodena):

[mediawiki/extensions/EventBus@master] adopt PageRevisionUpdated domain event

https://gerrit.wikimedia.org/r/1135720

gerritbot added a project: Patch-For-Review.Apr 10 2025, 1:22 PM
gmodena moved this task from In progress to In Review on the Data-Engineering (Q4 2025 April 1st - June 30th) board.Apr 17 2025, 10:20 AM
gerritbot added a comment.Apr 30 2025, 8:11 AM

Change #1140123 had a related patch set uploaded (by Gmodena; author: Gmodena):

[mediawiki/extensions/EventBus@master] add integration tests for PageChangeEventIngress

https://gerrit.wikimedia.org/r/1140123

gerritbot added a comment.May 14 2025, 9:59 PM

Change #1140123 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] add integration tests for mediawiki.page_change.v1

https://gerrit.wikimedia.org/r/1140123

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 14 2025, 10:00 PM
gerritbot added a comment.May 21 2025, 10:58 AM

Change #1148829 had a related patch set uploaded (by Gmodena; author: Gmodena):

[mediawiki/extensions/EventBus@master] page_change: remove PageSaveCompleteHook

https://gerrit.wikimedia.org/r/1148829

gerritbot added a comment.May 23 2025, 3:06 PM

Change #1135720 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] adopt PageRevisionUpdated domain event

https://gerrit.wikimedia.org/r/1135720

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.3; 2025-05-27); removed MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 23 2025, 4:00 PM
gerritbot added a comment.Jun 5 2025, 7:16 PM

Change #1154106 had a related patch set uploaded (by Gmodena; author: Gmodena):

[mediawiki/extensions/EventBus@master] PageChangeEventIngress: handle file upload

https://gerrit.wikimedia.org/r/1154106

gmodena moved this task from In Review to Done on the Data-Engineering (Q4 2025 April 1st - June 30th) board.Jun 11 2025, 8:51 AM
gerritbot added a comment.Jun 12 2025, 2:41 PM

Change #1154106 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] PageChangeEventIngress: handle file upload

https://gerrit.wikimedia.org/r/1154106

gerritbot added a comment.Jun 24 2025, 12:00 PM

Change #1148829 abandoned by Gmodena:

[mediawiki/extensions/EventBus@master] page_change: remove PageSaveCompleteHook

Reason:

Superseded by 1163344

https://gerrit.wikimedia.org/r/1148829

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2025, 12:31 PM
Ahoelzl closed this task as Resolved.Jul 25 2025, 11:06 PM
Ottomata mentioned this in T423583: mediawiki.page_change.v1 event - Add revision revert details.Apr 16 2026, 12:50 PM
Maintenance_bot added a project: MW-Interfaces-Team.Apr 16 2026, 1:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits