In T389900, we added hard-coded values for line-height-xx-small and line-height-medium in Vector 2022, Vector, MinervaNeue, and Monobook to avoid breaking layouts with the Codex 2.0 release. To resolve T394305, we also added a hard-coded value for line-height-small in the 3 skins.
After Codex v2.0.0 is released, we need to update certain line height tokens in skin and feature code to use the correct token in the new line height scale:
| Project | Line-height token | Font-size token | Intended line-height token from font modes patch |
|---|---|---|---|
| Skin:Vector | line-height-xx-small | n/a | line-height-xxx-large |
| line-height-xx-small | n/a | line-height-xxx-large | |
| line-height-xx-small | n/a | line-height-xxx-large | |
| line-height-medium | n/a | unknown | |
| Skin:MinervaNeue | line-height-xx-small | n/a | unknown |
| Skin:Mirage | line-height-medium | n/a | unknown |
| line-height-medium | n/a | unknown | |
| line-height-medium | n/a | unknown | |
| New Lexeme form | line-height-medium | n/a | unknown |
| line-height-medium | n/a | unknown | |
| Extension:CampaignEvents | line-height-xxx-small | font-size-medium | line-height-xx-small |
| line-height-x-small | font-size-small | line-height-xx-small | |
| Extension:GrowthExperiments | line-height-xx-small | font-size-x-small | line-height-xxx-small |
| line-height-medium | font-size-base | unknown | |
| Extension:CodeMirror | line-height-xx-small | n/a | unknown |
| Extension:Kartographer | line-height-xx-small | n/a | unknown |
| line-height-medium | n/a | unknown | |
| Extension:MediaSearch | line-height-xx-small | n/a | unknown |
| Extension:WikiLambda | line-height-x-small | font-size-large | line-height-large |
| line-height-medium | n/a | unknown | |
| line-height-medium | n/a | unknown | |
| line-height-medium | n/a | unknown | |
| line-height-medium | n/a | unknown | |
| Extension:CommunityConfiguration | line-height-small | n/a | unknown |
| Extension:ReportIncident | line-height-medium | n/a | unknown |
| line-height-medium | n/a | unknown | |
| Extension:WikibaseLexeme | line-height-medium | n/a | unknown |
It's possible that some or many of these instances where the font-size is not explicitly listed are already an intended combination. We would need to verify what the font-size is in these instances to determine the correct line-height.
Additionally, there are a couple instances in Vector where certain tokens are being overwritten to account for adjustments based on user preferences in the Appearance/Text size settings. These instances (such as this one) do not need to be changed at this time, but are exactly the places where font modes could are intended to be used in place of this.
Potential issues
Note that removing the line-height overrides in the skins will cause a recurrence of T394305 unless we find another workaround.
Acceptance criteria
- Determine how to prevent further issues caused by using rem-based line-height tokens instead of unitless
- Go through each token usage, determine what to do, and open a patch if needed
- Merge all patches, meaning all uses of these line height tokens is now correct and in line with the new scale