Page MenuHomePhabricator

Turn down MediaWiki image builds for PHP 7.4
Closed, ResolvedPublic

Description

There are two remaining uses of the 7.4-based publish flavour of the MediaWiki app image:

  • The mw-debug pinkunicorn release [0] - i.e., "regular" k8s-mwdebug.
  • The mw-script main release [1] - i.e., the image used when the tool is invoked with --php_version=7.4 (see T387917: Migrate mw-script to PHP 8.1).

For #1, there's arguably not much benefit to continuing to operate pinkunicorn on 7.4, since there are no production traffic-serving use cases running those images anymore. Further, the continued use of 7.4 there could potentially be a source of confusion.

For #2, we'll want to wait a little bit before removing the --php_version fallback (the default changed to 8.1 yesterday, 2025-04-02). I need to think a little bit on how long.

It may also be that we want to wait on #1 until we do #2, on the basis that we want to have at least some basic confidence that the 7.4 image still "works" by some definition thereof.

Once we remove both of those use cases, we can then remove the publish flavour from build-image.py [2] to stop building it entirely (edit: after also switching train-dev to use 8.1).

[0] https://gerrit.wikimedia.org/g/operations/puppet/+/ac0a63042f53180e96e51d87e0598e52b4a19687/hieradata/role/common/deployment_server/kubernetes.yaml#262

[1] https://gerrit.wikimedia.org/g/operations/puppet/+/ac0a63042f53180e96e51d87e0598e52b4a19687/hieradata/role/common/deployment_server/kubernetes.yaml#340

[2] https://gitlab.wikimedia.org/repos/releng/release/-/blob/79db12a1f4542c5d19c124721c072e3c2d117bdd/make-container-image/build-images.py#L20

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedReedy
StalledNone
OpenNone
OpenNone
OpenNone
ResolvedReedy
ResolvedKrinkle
ResolvedKrinkle
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
Resolved Lucas_Werkmeister_WMDE
ResolvedNone
ResolvedJdforrester-WMF
ResolvedDaimona
ResolvedJdforrester-WMF
DeclinedNone
ResolvedScott_French
ResolvedScott_French
ResolvedScott_French
Resolvedcscott
ResolvedScott_French
DuplicatePRODUCTION ERRORNone
ResolvedPRODUCTION ERRORMichael
ResolvedPRODUCTION ERRORMichael
ResolvedMichael
DuplicatePRODUCTION ERRORNone
ResolvedTgr
ResolvedNone
Resolved DAlangi_WMF
ResolvedTgr
Resolved DAlangi_WMF
ResolvedTgr
ResolvedTgr
Resolved Atieno
ResolvedNone
Resolvedbrouberol
ResolvedScott_French
ResolvedScott_French
ResolvedScott_French
ResolvedScott_French
ResolvedScott_French
ResolvedScott_French
ResolvedKrinkle
ResolvedKrinkle
ResolvedScott_French
ResolvedKrinkle
ResolvedTgr
ResolvedScott_French
Resolvedjnuche
ResolvedJdforrester-WMF
ResolvedBUG REPORTbd808
ResolvedReedy
ResolvedReedy
Resolvedseanleong-WMDE
StalledNone
OpenNone
Resolved Lucas_Werkmeister_WMDE
ResolvedDaimona
ResolvedDaimona
ResolvedDaimona
OpenNone
ResolvedUmherirrender
ResolvedArendpieter
ResolvedUmherirrender
ResolvedUmherirrender
Resolved mszabo
Resolvedtstarling
ResolvedUmherirrender
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedPhysikerwelt
ResolvedTgr
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedNone
ResolvedUmherirrender
ResolvedNone
ResolvedNone
ResolvedkarapayneWMDE
ResolvedAudreyPenven_WMDE
ResolvedAudreyPenven_WMDE
Resolved Lucas_Werkmeister_WMDE
Resolved Lucas_Werkmeister_WMDE
ResolvedUmherirrender
Resolvedthiemowmde
Resolved Lucas_Werkmeister_WMDE
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedUmherirrender
Resolved mszabo
ResolvedxSavitar
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedDaimona
Resolvedcscott
ResolvedArendpieter
OpenNone
ResolvedUmherirrender
Resolved larissagaulia
ResolvedUmherirrender
ResolvedJdforrester-WMF
OpenNone
OpenNone
ResolvedArendpieter
OpenNone
ResolvedReedy
OpenNone
OpenNone
ResolvedUmherirrender
OpenNone
ResolvedUmherirrender
ResolvedUmherirrender
Resolvedsiebrand
ResolvedUmherirrender
ResolvedDreamy_Jazz
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedUmherirrender
ResolvedUmherirrender
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedKrinkle
ResolvedScott_French

Event Timeline

Change #1137496 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/puppet@production] hieradata: switch mw-script main release to PHP 8.1

https://gerrit.wikimedia.org/r/1137496

Change #1137497 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/puppet@production] deployment_server: drop unsupported fallback to PHP 7.4

https://gerrit.wikimedia.org/r/1137497

Change #1137498 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/puppet@production] hieradata: switch mw-debug pinkunicorn to PHP 8.1 (1 of 2)

https://gerrit.wikimedia.org/r/1137498

Change #1137499 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/deployment-charts@master] mw-debug: switch mw-debug pinkunicorn to PHP 8.1 (2 of 2)

https://gerrit.wikimedia.org/r/1137499

Change #1137500 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/deployment-charts@master] mw-(debug|web): switch train-dev to PHP 8.1 (2 of 2)

https://gerrit.wikimedia.org/r/1137500

Remaining patches to draft:

Change #1137496 merged by Scott French:

[operations/puppet@production] hieradata: switch mw-script main release to PHP 8.1

https://gerrit.wikimedia.org/r/1137496

Mentioned in SAL (#wikimedia-operations) [2025-05-08T20:03:25Z] <swfrench@deploy1003> Started scap sync-world: Non-deploy scap run to switch mw-script/main to PHP 8.1 - T391057

Change #1137497 merged by Scott French:

[operations/puppet@production] deployment_server: drop unsupported fallback to PHP 7.4

https://gerrit.wikimedia.org/r/1137497

swfrench opened https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/172

Draft: make-container-image: stop building the "publish" flavour

Given that we're well on our way to completing the periodic jobs migration and have not run into showstopper 8.1-compatibility issues, and we've removed the 7.4 fallback functionality from mwscript-k8s, I think it make sense to move forward with this.

Change #1137498 merged by Scott French:

[operations/puppet@production] hieradata: switch mw-debug pinkunicorn to PHP 8.1 (1 of 2)

https://gerrit.wikimedia.org/r/1137498

Mentioned in SAL (#wikimedia-operations) [2025-05-20T17:13:16Z] <swfrench@deploy1003> Started scap sync-world: Non-deploy scap run to switch mw-debug/pinkunicorn to PHP 8.1 - T391057

Change #1137499 merged by jenkins-bot:

[operations/deployment-charts@master] mw-debug: switch mw-debug pinkunicorn to PHP 8.1 (2 of 2)

https://gerrit.wikimedia.org/r/1137499

Change #1137500 merged by jenkins-bot:

[operations/deployment-charts@master] mw-(debug|web): switch train-dev to PHP 8.1 (2 of 2)

https://gerrit.wikimedia.org/r/1137500

Last step here is to merge https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/172 and scap sync-world to integrate it. I'll aim to do that either today or (more likely) tomorrow (May 22nd).

Mentioned in SAL (#wikimedia-operations) [2025-05-22T17:26:08Z] <swfrench@deploy1003> Started scap sync-world: Non-deploy scap run to stop building and publishing PHP 7.4 images - T391057

Since a bit before 17:30 UTC today, we are no longer building PHP 7.4 ("publish" flavour) MediaWiki images during scap deployments. No further work is tracked here, so I'm marking this resolved.