Page MenuHomePhabricator

Codex Special:Block: margins between radio buttons and associated controls in the block expiry section are off
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
hgzh
Apr 4 2025, 7:00 AM
Referenced Files
F59066449: 2025-04-14_20-35-19.png
Apr 15 2025, 3:42 AM
F59066447: 2025-04-14_20-35-09.png
Apr 15 2025, 3:42 AM
F59066445: 2025-04-14_20-34-57.png
Apr 15 2025, 3:42 AM
F59066443: 2025-04-14_20-28-57.png
Apr 15 2025, 3:42 AM
F59066440: 2025-04-14_20-28-34.png
Apr 15 2025, 3:42 AM
F59066438: 2025-04-14_20-28-08.png
Apr 15 2025, 3:42 AM
F58978373: temp.png
Apr 4 2025, 7:00 AM

Description

On Codex Special:Block, there are three radio buttons for selecting the 'type' of the block expiry that show associated controls for setting the actual expiry if selected. The margins between the radio button and the associated control are odd: the top margin of the associated controls is higher than the bottom margin. I would expect it to be the other way round to indicate that the controls belong to the selected radio button and not to the next one as currently.

temp.png (215×666 px, 6 KB)

Derived Requirement

Ensure that in Codex Special:Block, the associated controls for each block expiry radio button are visually grouped with their corresponding radio button by applying appropriate top and bottom margins—specifically, the top margin should be smaller than the bottom margin to indicate visual association.

Test Steps

Test Case 1: Ensure Correct Visual Grouping of Block Expiry Controls with Radio Buttons

  1. Navigate to Codex Special:Block on beta.
  2. Scroll to the *Block expiry* section.
  3. Observe the spacing between each radio button and its corresponding control input (e.g., date/time picker or dropdown).
  4. ✅❓❌⬜ AC1: Confirm that the top margin between the radio button and its associated controls is smaller than the bottom margin, clearly indicating that the controls belong to the selected radio button.

QA Results - Test Wiki

ACStatusDetails
1T391070#10742046

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@JSengupta-WMF What do you think about the spacing? I don't see a mockup in the designs for the block expiry field. Should it be even top and bottom?

Change #1135517 had a related patch set uploaded (by HMonroy; author: HMonroy):

[mediawiki/core@master] Special:Block [Codex]: fix margins between radio buttons

https://gerrit.wikimedia.org/r/1135517

Change #1135517 merged by jenkins-bot:

[mediawiki/core@master] Special:Block [Codex]: fix margins between radio buttons

https://gerrit.wikimedia.org/r/1135517

@HMonroy Is this what you are looking for? The distance is 1st radio button and associated control is 10 px, 16 px, and 16 px as seen in the screenshots.

UPDATE: PASS via T391070#10745946

Test Result - TestWiki

Status: ✅ PASS
Environment: TestWiki
OS: macOS Sequoia 15.3.2
Browser: Chrome 134
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Correct Visual Grouping of Block Expiry Controls with Radio Buttons

  1. Navigate to Codex Special:Block on beta.
  2. Scroll to the *Block expiry* section.
  3. Observe the spacing between each radio button and its corresponding control input (e.g., date/time picker or dropdown).
  4. AC1: Confirm that the top margin between the radio button and its associated controls is smaller than the bottom margin, clearly indicating that the controls belong to the selected radio button.

Desktop

Radio Button 1Radio Button 2Radio Button 3
2025-04-14_20-28-08.png (210×806 px, 24 KB)
2025-04-14_20-28-34.png (409×754 px, 51 KB)
2025-04-14_20-28-57.png (450×1 px, 57 KB)

Mobile

Radio Button 1Radio Button 2Radio Button 3
2025-04-14_20-34-57.png (761×796 px, 105 KB)
2025-04-14_20-35-09.png (200×761 px, 26 KB)
2025-04-14_20-35-19.png (224×711 px, 29 KB)

@HMonroy Is this what you are looking for? The distance is 1st radio button and associated control is 10 px, 16 px, and 16 px as seen in the screenshots.

Right, we had added some custom margin, and we have now removed. We don't have the specific margins, we are going off the figma files and the margins are now Codex defaults.

GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF updated Other Assignee, removed: GMikesell-WMF.