Create tests for Add interlanguage links
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	ArthurTaylor
	Fri, Apr 4, 11:06 AM

Description

In T390949 we introduced changes that broke the "Add interlanguage links" functionality for logged-in users for pages that didn't already have links. This was reported as a regression in T390949 and the bug was fixed in production with a backport (https://gerrit.wikimedia.org/r/c/1134190).

To avoid similar such regressions in the future, add a test of the functionality to an existing testsuite / test suites. QUnit tests might be the simplest (and should be able to catch a bug like this), but integration tests would catch a broader range of possible failures.

Acceptance Criteria

Tests of the interlanguage links functionality exist, run and pass in CI (minimumly that the popup loads)
Modifying the code to revert https://gerrit.wikimedia.org/r/c/1134190 causes the tests to fail

Note: There are no integration tests for this as its complicated, this topic will be handled in TBD

Details

	Subject	Repo	Branch	Lines +/-
	Add very basic selenium test for client's linkitem	mediawiki/extensions/Wikibase	master	+89 -0

Customize query in gerrit

Related Objects

Mentioned In: T390949: Dependency jquery.wikibase.linkitem failed to load on unconnected pages ("Add interlanguage links" broken everywhere)
Mentioned Here: rEWBA09281858f21e: Add Item and CustomItem classes as properties to `$.ui.ooMenu`
T390949: Dependency jquery.wikibase.linkitem failed to load on unconnected pages ("Add interlanguage links" broken everywhere)

Event Timeline

ArthurTaylor created this task.Fri, Apr 4, 11:06 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Apr 4, 11:06 AM

ArthurTaylor mentioned this in T390949: Dependency jquery.wikibase.linkitem failed to load on unconnected pages ("Add interlanguage links" broken everywhere).Fri, Apr 4, 11:07 AM

karapayneWMDE updated the task description. (Show Details)Tue, Apr 8, 8:47 AM

karapayneWMDE moved this task from Incoming to The Backlog on the Wikidata-Omega board.

hoo claimed this task.Tue, Apr 8, 10:24 AM

hoo moved this task from The Backlog to The Board on the Wikidata-Omega board.

hoo edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.

hoo moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.

Change #1136784 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] Add very basic selenium test for client's linkitem

https://gerrit.wikimedia.org/r/1136784

gerritbot added a project: Patch-For-Review.Tue, Apr 15, 6:53 PM

Added a browser test setup similar to the repo one for client, and created a very trivial test making sure the linkitem pop up loads. The test fails for me after reverting 09281858f21eb5d8a34666ce599fa130c519b7f4.

Looks like it's failing with some parsing errors:

21:18:51 /src/client/tests/selenium/pageobjects/linkitem.page.js
21:18:51   5:8  error  Parsing error: Unexpected token open
21:18:51 
21:18:51 /src/client/tests/selenium/specs/linkitem.js
21:18:51   9:19  error  Parsing error: Unexpected token =>
21:18:51 
21:18:51 /src/client/tests/selenium/wdio.conf.js
21:18:51   11:2  error  Parsing error: Unexpected token ..

https://integration.wikimedia.org/ci/job/mwgate-node20/38786/console

In T391089#10746455, @ArthurTaylor wrote:

Looks like it's failing with some parsing errors:
[…]
https://integration.wikimedia.org/ci/job/mwgate-node20/38786/console

I forgot to add the eslint config for the new folder. Fixed this afternoon.

ArthurTaylor removed ArthurTaylor as the assignee of this task.Thu, Apr 17, 6:47 AM

ArthurTaylor moved this task from In Peer Review to Ready for Tech Verification on the Wikidata-Omega (The Board) board.

Change #1136784 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add very basic selenium test for client's linkitem

https://gerrit.wikimedia.org/r/1136784

Maintenance_bot removed a project: Patch-For-Review.Thu, Apr 17, 7:30 AM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.27; 2025-04-29).Thu, Apr 17, 8:00 AM